已合并
refactor: correct English grammar, spelling, and style in log/warning messages #45399
wanglijun55创建于 9 天前
refactor: correct English grammar, spelling, and style in log/warning messages #45399
已合并
wanglijun55创建于 9 天前
wanglijun55成员
9 天前

【合入来源】

如有社区issue,请关联issue链接
请勿携带内部流程信息(需求链接、问题单、内部issue等)
https://gitcode.com/Ascend/pytorch/issues/3908

同步自 master 分支 PR #44119(refactor: correct English grammar, spelling, and style in log/warning messages)。

【修改方案】

将 PR #44119 在 master 分支上的告警日志英文语法/拼写修复同步至 v2.10.0 分支。

对 torch_npu 全仓 UserWarning / logger.warning / print 日志中的英文消息进行语法、拼写、标点审查和修复。共涉及 37 个文件,涵盖以下类别:

  1. 语法错误: will not to be linkedwill not be linkedshould to be initializedshould be initializedCreate ... failedFailed to create ...
  2. 逗号拼接句: 将逗号连接的两个独立句子拆分为两句或使用分号
  3. 拼写错误: Detecct_typeDetect_type
  4. 缺少冠词: in future versionin a future versiononly sets Global variableonly sets the global variable
  5. 主谓不一致: Environment variable ... is not setare not setThere is no ... eventsThere are no ... events
  6. 标点/格式: 中文顿号 → 英文逗号、多余空格、缺失句号、相邻字符串缺少空格拼接导致粘连
  7. 翻译不当: soft chainsymbolic link(软链接)
  8. 冗余前缀: warnings.warn() 中重复的 Warning: 前缀
  9. 代码 Bug: serialization.pyprint() 传入 tuple 而非 string
  10. 风格问题: for replacementas a replacementTorchinductorTorchInductorCan notCannotfunc/msgfunction/message

注:master PR 中对 test/unsupported_test_cases/.pytorch-disabled-tests.json 的修改为测试配置更新,与告警日志修复无关,不在本次同步范围内。

【资料变更】

不涉及

【接口变更】

不涉及

【功能验证】

仅修改日志/警告消息字符串,不影响任何功能逻辑。所有修改均为:

  • 英文语法/拼写/标点修正
  • 字符串拼接 bug 修复(serialization.py tuple → string)
  • 翻译术语规范化(soft chain → symbolic link)

【CheckList】

PR提交人对以下CheckList自检项进行全量自检,自检通过或不涉及,均修改 [ ] 为 [x]

likedislike
Pull Request已成功合入, 合并人@ascend-robot
(感谢 wanglijun55 的贡献)
Wwanglijun55成员
9 天前 创建了 pull request,commit 05b222bc
Wwanglijun55成员
9 天前 关联了issue:[Feature]: 整改所有Warning日志中的英文拼写或语法问题
atomgit-bot
atomgit-bot
9 天前 评论:

变更摘要

本 PR 将 master 分支 #44119 的告警日志英文质量修复同步至 v2.10.0 分支,对 torch_npu 全仓 UserWarning / logger.warning / logger.info / print 等日志消息中的英文语法、拼写、标点与措辞进行系统性修正,同时顺带清理了部分冗余格式与字符串拼接问题,不涉及任何功能逻辑、接口或资料变更。

主要改动

  • 日志消息英文语法与措辞规范化: 修复语法错误(如 will not to be linkedwill not be linkedshould to be initializedshould be initializedCreate ... failedFailed to create ...)、逗号拼接句拆分/改用分号、补充缺失冠词(in future versionin a future version)、主谓一致(Environment variable ... is not setare not setThere is no ... eventsThere are no ... events)并统一补充缺失句号,涉及 torch_npu/asd/asd.pytorch_npu/npu/utils.pytorch_npu/npu/npu_config.py 等文件。

  • 术语与拼写统一: 将 soft chain 统一改为 symbolic linktorch_npu/utils/_path_manager.pytorch_npu/profiler/analysis/prof_common_func/_path_manager.pytorch_npu/utils/collect_env.py),拼写修正 Detecct_typeDetect_typeTorchinductorTorchInductorCan notCannotfuncfunction,并将 for replacement 改为 as a replacementiou.pyactivations.pyfusedcolorjitter.py 等弃用提示)。

  • 去除冗余前缀与标点/拼接问题修复: 移除 warnings.warn() 中重复的 Warning: 前缀(如 asd.pytorch_npu/utils/_step.py 中 NPU_ASD_CONFIG 系列提示),将中文顿号 改为英文逗号(torch_npu/npu/_backends.py),并修复相邻字符串缺少空格导致消息粘连的问题(gemm_autotune.pytorch_npu/_inductor/__init__.pynpu/utils.py)。

  • 日志格式化方式优化: 将 loggerSilent.debug/info/warningself.logger.warning 等处的 f-string 拼接改为 %s 惰性参数化模板(asd.pytorch_npu/utils/_step.py_cann_file_parser.py_fwk_file_parser.py),并用 logger.exception 替代 logger.error(..., exc_info=True)_kernel_view_parser.py_basic_db_parser.py),使日志记录更规范、便于延迟求值。

  • 日志消息内容 Bug 修复: torch_npu/utils/serialization.py_npu_legacy_savewarn_massage 由逗号拼接的 tuple 修正为单个字符串;torch_npu/utils/npu_intercept.py 中无占位符的 f-string(print(f"Warning : ..."))改为普通字符串,避免无效格式化。

likedislike
atomgit-bot
atomgit-bot
9 天前 评论:

代码审查

✅ 未发现问题

likedislike
ascend-robotascend-robot成员
9 天前 添加了label:ascend-cla/yes
ascend-robot
ascend-robot成员
9 天前 评论:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.


PR Approval Progress

Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
repo-Ascend/pytorch liangsongwei, chengpeng25 (2/2) liangsongwei (1/1)
torch_npu/_inductor liangsongwei, chengpeng25 (2/2) liangsongwei (1/1)
torch_npu/contrib/transfer_to_npu.py liangsongwei, chengpeng25 (2/2) liangsongwei (1/1)
torch_npu/npu liangsongwei, chengpeng25 (2/2) liangsongwei (1/1)
torch_npu/profiler liangsongwei, chengpeng25 (2/2) liangsongwei (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

wanglijun55, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
ascend-robot
ascend-robot成员
9 天前 评论:

当前仓库存在以下 保护分支

Protected Branch Version Release
master
v2.7.1-26.1.0
v2.12.0
v2.11.0
v2.7.1
v2.10.0
v2.9.0
v2.9.0-26.1.0
v2.10.0-26.1.0
v2.11.0-26.1.0
v2.12.0-26.1.0
ci-test

评论 /sync <branch1> <branch2> ... 可将当前 PR 修改同步到其它分支(创建同步 PR):
a) 如果当前 PR 是 Open 状态,同步操作将延迟到 PR 被合并时执行
b) 如果当前 PR 已经 Merged,将立即执行同步操作

注意:

  1. /sync 命令可以指定同步到多个分支,仅最后一个 /sync 命令生效
  2. 如果创建的同步 PR 不正确,可通过向同步 PR 的源分支提交轻量级 PR 完善,或使用 /close 命令关闭
likedislike
AtlasAccountAtlasAccount成员
9 天前 添加了label:ci-pipeline-running
ascend-robot
ascend-robot成员
9 天前 评论:

ascend docs pipeline is running...

likedislike
ascend-robotascend-robot成员
9 天前 添加了label:docs-ci-pipeline-running
ascend-robot
ascend-robot成员
9 天前 评论:

✅ 跳过 docs ci 检查,没有需要检查的文档文件

likedislike
ascend-robotascend-robot成员
9 天前 删除了label:docs-ci-pipeline-running
ascend-robotascend-robot成员
9 天前 添加了label:docs-ci-pipeline-success
AtlasAccountAtlasAccount成员
9 天前 删除了label:ci-pipeline-running
AtlasAccountAtlasAccount成员
9 天前 添加了label:ci-pipeline-passed
AtlasAccount
AtlasAccount成员
9 天前 评论:
流水线 PR-pipeline_pytorch#64296 [ commitID:cacc3ead ] 已完成
>>>代码风格自动修复执行成功(无修复内容)
阶段 任务名 状态 详情
编译构建 Build_X86 >>>
Build_ARM >>>
Build_X86_torchair 🛑 >>>
Build_ARM_torchair 🛑 >>>
patch_test 🛑 >>>
Build_X86_213 🛑 >>>
Build_ARM_213 🛑 >>>
恶意代码检查 Antipoison >>>
编码安全与规范检查 codecheck_pre-commit >>>
check_error >>>
lintrunner >>>
开源片段检查 SCA >>>
开发者测试 UT_ARM_A3_Part_01 🛑 >>>
UT_ARM_A3_Part_02 🛑 >>>
UT_ARM_A2_Part_01 >>>
UT_ARM_A2_Part_02 >>>
UT_ARM_A2_Part_03 >>>
UT_inductor_Part_01 >>>
UT_inductor_Part_02 >>>
UT_inductor_Part_03 >>>
UT_inductor_Part_04 >>>
UT_DIST_ARM_Part_01 🛑 >>>
UT_DIST_ARM_Part_02 🛑 >>>
UT_DIST_ARM_Part_03 🛑 >>>
UT_DIST_ARM_Part_04 🛑 >>>
UT_ARM_A2_Select_Part_01 >>>
UT_ARM_A2_Select_Part_02 >>>
UT_ARM_A2_Part_213 🛑 >>>
UT_inductor_Part_213 🛑 >>>
UT_DIST_ARM_Part_213 🛑 >>>
UT_ARM_A2_Select_Part_213 🛑 >>>
流水线 PR-pipeline_pytorch >>>
此流水线已支持下列评论快捷指令,仅PR创建者和白名单成员[wujinyuan1, huangjingwei, liangsongwei, yashi999, culechan, Dring, wuyouqi1, L1919_snow, qq_52711437, WhiteNight12, nomiz, xiu_21, ffmh, wanglijun55, hss-shuai, husichao, smallsilly, lanshaozuishuai, jimmyisme1, lzy0920232, alpha-junh, Sunshine_Youngster, wei_zhuoyi, zhangyihuiben, zyw-hw, zzzkeke, rmch, yangch0324, LucciC, AACAES, renyujin, wjlflyer, senzhen-town, pengjingyou, qsc97, limuan, yule100, xiaoqi-zhou, kuhn7, chenxingying, hanye02, zichun_ye, anyrenwei, kkjocker, wangzili121, Lu_G, yvjc, puddingfjz, HandsoemLemon, bigprestigee1, huawuyi, zhenyu10, dairenjie, du-jin-hang, zou-jieyu, adelaideliu, TrHan, wanlinan, Windwindzzz, pengqihw, kisnwang, yuheng_wang, honghao_wang, jizewei, zhangguoguang, sunyu-xuan, chenrayray, hbhu_bin, liujunzhu, c_34, LiNuoh, maoyuanpeng1, zzhongmin, zhaoyu65, bellatan, jiabaolin, zhuofanshen, wencaiwen, lu_zhuge, caoshuyang, molly12, lyx324521, LQ1206, gitcode-chenjiao, cai-weiwei1989, CHDong, ogqin, yuanlipingGit, xuqinglin1, lqz2, zouwei1, chaoluoa, paradox325, jackzhang1116, yaoyao, akh, yujiacheng, dengjie0116, Hubert11111, Shine_Ws, wslhj555, longqiand, OYtao666, JiaqingQiang, luyyyy, Kingbelial, zhanghaiyu0101, wenxp1018, yanliu-luoluo, ksun_sekiro, liyong328, wgzheng, tangky, vivi_is_coding, aoiaoisola, weixin_44494597, wangmengmengwang65667, hid57809721, qq_35468730, comeonup, C547032, gcw_m5OQChA4, yao_yao_ling_xian, cnnbwcy, szqfes_12, cora_19, cann_lilin, can, shawnylee233, fanglanyue0916, hhz0, LiNuohang, taohuoquan, Jesse, WSs_321]评论有效
  • compile、compile_inductor、compile_torchair : 运行流水线
  • retry : 重试流水线所有失败子任务
  • retry <任务名> : 仅重试指定失败子任务
  • stop : 停止流水线
likedislike
Wwanglijun55成员
9 天前 关联了里程碑:v26.2.0
此处折叠了6条事件消息 查看更多
ascend-robotascend-robot成员
8 天前 添加了label:ascend-cla/yes
ascend-robot
ascend-robot成员
8 天前 评论:

ascend docs pipeline is running...

likedislike
ascend-robotascend-robot成员
8 天前 删除了label:docs-ci-pipeline-success
ascend-robotascend-robot成员
8 天前 添加了label:docs-ci-pipeline-running
ascend-robot
ascend-robot成员
8 天前 评论:

✅ 跳过 docs ci 检查,没有需要检查的文档文件

likedislike
ascend-robotascend-robot成员
8 天前 删除了label:docs-ci-pipeline-running
ascend-robotascend-robot成员
8 天前 添加了label:docs-ci-pipeline-success
Wwanglijun55成员
8 天前 修改了pull request 的描述
wanglijun55成员
8 天前 评论:

compile

likedislike
AtlasAccountAtlasAccount成员
8 天前 添加了label:ci-pipeline-running
ascend-robot
ascend-robot成员
8 天前 评论:

ascend docs pipeline is running...

likedislike
ascend-robotascend-robot成员
8 天前 删除了label:docs-ci-pipeline-success
ascend-robotascend-robot成员
8 天前 添加了label:docs-ci-pipeline-running
ascend-robot
ascend-robot成员
8 天前 评论:

✅ 跳过 docs ci 检查,没有需要检查的文档文件

likedislike
ascend-robotascend-robot成员
8 天前 删除了label:docs-ci-pipeline-running
ascend-robotascend-robot成员
8 天前 添加了label:docs-ci-pipeline-success
AtlasAccountAtlasAccount成员
8 天前 删除了label:ci-pipeline-running
AtlasAccountAtlasAccount成员
8 天前 添加了label:ci-pipeline-passed
AtlasAccount
AtlasAccount成员
8 天前 评论:
流水线 PR-pipeline_pytorch#64654 [ commitID:0352f068 ] 已完成
>>>代码风格自动修复执行成功(无修复内容)
阶段 任务名 状态 详情
编译构建 Build_X86 >>>
Build_ARM >>>
Build_X86_torchair 🛑 >>>
Build_ARM_torchair 🛑 >>>
patch_test 🛑 >>>
Build_X86_213 🛑 >>>
Build_ARM_213 🛑 >>>
恶意代码检查 Antipoison >>>
编码安全与规范检查 codecheck_pre-commit >>>
check_error >>>
lintrunner >>>
开源片段检查 SCA >>>
开发者测试 UT_ARM_A3_Part_01 🛑 >>>
UT_ARM_A3_Part_02 🛑 >>>
UT_ARM_A2_Part_01 >>>
UT_ARM_A2_Part_02 >>>
UT_ARM_A2_Part_03 >>>
UT_inductor_Part_01 >>>
UT_inductor_Part_02 >>>
UT_inductor_Part_03 >>>
UT_inductor_Part_04 >>>
UT_DIST_ARM_Part_01 🛑 >>>
UT_DIST_ARM_Part_02 🛑 >>>
UT_DIST_ARM_Part_03 🛑 >>>
UT_DIST_ARM_Part_04 🛑 >>>
UT_ARM_A2_Select_Part_01 >>>
UT_ARM_A2_Select_Part_02 >>>
UT_ARM_A2_Part_213 🛑 >>>
UT_inductor_Part_213 🛑 >>>
UT_DIST_ARM_Part_213 🛑 >>>
UT_ARM_A2_Select_Part_213 🛑 >>>
流水线 PR-pipeline_pytorch >>>
此流水线已支持下列评论快捷指令,仅PR创建者和白名单成员[wujinyuan1, huangjingwei, liangsongwei, yashi999, culechan, Dring, wuyouqi1, L1919_snow, qq_52711437, WhiteNight12, nomiz, xiu_21, ffmh, wanglijun55, hss-shuai, husichao, smallsilly, lanshaozuishuai, jimmyisme1, lzy0920232, alpha-junh, Sunshine_Youngster, wei_zhuoyi, zhangyihuiben, zyw-hw, zzzkeke, rmch, yangch0324, LucciC, AACAES, renyujin, wjlflyer, senzhen-town, pengjingyou, qsc97, limuan, yule100, xiaoqi-zhou, kuhn7, chenxingying, hanye02, zichun_ye, anyrenwei, kkjocker, wangzili121, Lu_G, yvjc, puddingfjz, HandsoemLemon, bigprestigee1, huawuyi, zhenyu10, dairenjie, du-jin-hang, zou-jieyu, adelaideliu, TrHan, wanlinan, Windwindzzz, pengqihw, kisnwang, yuheng_wang, honghao_wang, jizewei, zhangguoguang, sunyu-xuan, chenrayray, hbhu_bin, liujunzhu, c_34, LiNuoh, maoyuanpeng1, zzhongmin, zhaoyu65, bellatan, jiabaolin, zhuofanshen, wencaiwen, lu_zhuge, caoshuyang, molly12, lyx324521, LQ1206, gitcode-chenjiao, cai-weiwei1989, CHDong, ogqin, yuanlipingGit, xuqinglin1, lqz2, zouwei1, chaoluoa, paradox325, jackzhang1116, yaoyao, akh, yujiacheng, dengjie0116, Hubert11111, Shine_Ws, wslhj555, longqiand, OYtao666, JiaqingQiang, luyyyy, Kingbelial, zhanghaiyu0101, wenxp1018, yanliu-luoluo, ksun_sekiro, liyong328, wgzheng, tangky, vivi_is_coding, aoiaoisola, weixin_44494597, wangmengmengwang65667, hid57809721, qq_35468730, comeonup, C547032, gcw_m5OQChA4, yao_yao_ling_xian, cnnbwcy, szqfes_12, cora_19, cann_lilin, can, shawnylee233, fanglanyue0916, hhz0, LiNuohang, taohuoquan, Jesse, WSs_321]评论有效
  • compile、compile_inductor、compile_torchair : 运行流水线
  • retry : 重试流水线所有失败子任务
  • retry <任务名> : 仅重试指定失败子任务
  • stop : 停止流水线
likedislike
梁松伟
梁松伟成员
7 天前 评论:

/approve

likedislike
ascend-robotascend-robot成员
7 天前 添加了label:approved
chengpeng25成员
7 天前 评论:

/lgtm

likedislike
ascend-robotascend-robot成员
7 天前 添加了label:lgtm
ascend-robotascend-robot成员
7 天前 合入了pull request
AtlasAccount
AtlasAccount成员
7 天前 评论:
流水线 pytorch_gitcode_PR_multiVersion#14729 [ commitID:0352f068 ] 已完成
likedislike