Merged
Revert "modulate_grad无原型,仅支持aclnn,删除README.md"(回撤 #9177) #12478
babeieeAdd on Oct 21
Revert "modulate_grad无原型,仅支持aclnn,删除README.md"(回撤 #9177) #12478
Merged
babeieeAdd on Oct 21
babeiee
babeiee
Oct 21

描述

回撤已合入的 PR #9177,恢复被删除的 vfusion/modulate_grad/README.md 文档,并在 docs/zh/op_list.md 中补登 modulate_grad 算子条目(统一在本 PR 中处理)。

关联的Issue

https://gitcode.com/cann/ops-nn/issues/7103

回撤对象:https://gitcode.com/cann/ops-nn/pull/9177

测试

纯文档变更(恢复 README.md、登记 op_list.md),无代码逻辑变更,无需测试。

文档更新

  • 恢复 vfusion/modulate_grad/README.md(113 行)。
  • docs/zh/op_list.md 新增 modulate_grad 登记:vfusion 分类,op_kernel/op_host/op_api 均为 ✓,无原型(op_graph ✗),仅支持 aclnn 调用,AI Core 执行。

类型标签

AI/Agent生成声明

likedislike
Pull Request has been successfully merged by CANN-robot.
(Thank you for babeiee's contribution.)
babeieebabeiee
Oct 21 Created pull request, commit c5fd5f4a
atomgit-bot
atomgit-bot
Oct 21 Comments:

变更摘要

本 PR 回撤已合入的 #9177,恢复此前被删除的 vfusion/modulate_grad/README.md 文档(113 行),用于重新提供 ModulateGrad 算子的产品支持、功能与接口说明。属于纯文档恢复,代码逻辑与行为无变化。

主要改动

  • 恢复算子文档文件: 重新新增 vfusion/modulate_grad/README.md,恢复 ModulateGrad 算子的完整说明文档。
  • 恢复产品支持情况说明: 补充 ModulateGrad 对 Ascend 950PR/950DT、Atlas A3 训练/推理系列、Atlas A2 训练/推理系列的支持标记,以及 200I/500 A2、Atlas 推理系列、Atlas 训练系列的不支持标记。
  • 恢复功能与计算公式: 说明该算子完成 Modulate 反向传播中的参数计算与梯度更新,并给出 grad_x、grad_scale、grad_shift 的计算公式及符号说明(含沿序列维度 L 的求和与 scale 广播)。
  • 恢复参数说明表: 列出输入 grad_output、input、scale、shift 与输出 grad_input、grad_scale、grad_shift,均标注支持 FLOAT、FLOAT16、BFLOAT16 数据类型及 ND 数据格式。
  • 恢复调用说明: 补充通过 test_aclnn_modulatebackward 样例调用 aclnnModulateBackward 接口的方式,并链接至对应接口文档 docs/aclnnModulateBackward.md。

🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
atomgit-bot
atomgit-bot
Oct 21 Comments:

代码审查

✅ 未发现问题


🧩 本次 Review 已使用自定义 Skill:

likedislike
Incorrect?
CANN-robotCANN-robotCollaborators
Oct 21 Added label: cann-cla/yes
CANN-robot
CANN-robotCollaborators
Oct 21 Comments:

Thanks for your pull-request.
The full list of commands accepted by me can be found at here.
You can get sig-info at here.
You can self-configure the PR merge rules for this repository. For more details, please refer to Here.
For more, you also can visit HICANN.


PR Approval Progress

✅ Congratulations! All modules have met the lgtm and approve requirements.

Module Approval Details

module lgtm status approve status
*/*/README.md ✅ 陈娇, 唐玮玮, 王星 (3/2) ✅ 陈娇 (1/1)
*/*/docs/acl*.md ✅ 陈娇, 唐玮玮, 王星 (3/2) ✅ 陈娇 (1/1)
docs ✅ 陈娇, 唐玮玮 (2/2) ✅ 陈娇 (1/1)
vfusion ✅ 王星, 唐玮玮 (2/2) ✅ 王星 (1/1)

💡 Tip:

  • Committer can comment /approve or /lgtm
  • Commenting /approve implies both code review (lgtm) and intent to merge (approve)

CLA Signature Pass

babeiee, thanks for your pull request. All authors of the commits have signed the CLA. 👍

likedislike
155 messages are collapsed here。 See more
CANN-robotCANN-robotCollaborators
18 days ago Added label: lgtmapproved
CANN-robot
CANN-robotCollaborators
18 days ago Comments:

The MR can not be merged, because of CodeReview discussion not resolved

If you want to solve this problem, you can click here to do it in the FAQs.

likedislike
NerdddddNerdddddCollaborators
18 days ago Resolved final issue
CANN-robotCANN-robotCollaborators
18 days ago Merged pull request
CANN-robot
CANN-robotCollaborators
18 days ago Comments:

Pull Request 已合并或已关闭。

If you want to solve this problem, you can click here to do it in the FAQs.

likedislike