LLUCI CQReland "metadata/rla_approval: improve arg passing and error handling"

7dbbf3c2创建于 20 小时前历史提交

文件	最后提交记录	最后更新时间
fields	Reland "metadata/rla_approval: improve arg passing and error handling" This is a reland of commit 8a7b59a2990b4c12fdb592c9fa24329677074e4f This reland removes the vpython3.bat resolution that caused failure on linux-presubmit bots. Original change's description: > metadata/rla_approval: improve arg passing and error handling > > This CL changes RLA parsing to use env var to pass file paths to avoid > the need to deal with Windows cmd escaping, and adds exception handling > to tell the caller that the given textproto is invalid (instead of a > generic CalledProcessError that eats the important "invalid textproto" > error message. > > Fixed: 558123060 > Change-Id: I202331f00625b5b79d9d8a4419bbc74efb538d24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8366204 > Reviewed-by: Chenlin Fan <fancl@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> Change-Id: Iad175dd848450525adc4cae6e1db0aa01a58bf6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8369602 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by: Chenlin Fan <fancl@chromium.org>	20 小时前
scripts	Reland "metadata/rla_approval: improve arg passing and error handling" This is a reland of commit 8a7b59a2990b4c12fdb592c9fa24329677074e4f This reland removes the vpython3.bat resolution that caused failure on linux-presubmit bots. Original change's description: > metadata/rla_approval: improve arg passing and error handling > > This CL changes RLA parsing to use env var to pass file paths to avoid > the need to deal with Windows cmd escaping, and adds exception handling > to tell the caller that the given textproto is invalid (instead of a > generic CalledProcessError that eats the important "invalid textproto" > error message. > > Fixed: 558123060 > Change-Id: I202331f00625b5b79d9d8a4419bbc74efb538d24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8366204 > Reviewed-by: Chenlin Fan <fancl@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> Change-Id: Iad175dd848450525adc4cae6e1db0aa01a58bf6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8369602 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by: Chenlin Fan <fancl@chromium.org>	20 小时前
tests	Reland "metadata/rla_approval: improve arg passing and error handling" This is a reland of commit 8a7b59a2990b4c12fdb592c9fa24329677074e4f This reland removes the vpython3.bat resolution that caused failure on linux-presubmit bots. Original change's description: > metadata/rla_approval: improve arg passing and error handling > > This CL changes RLA parsing to use env var to pass file paths to avoid > the need to deal with Windows cmd escaping, and adds exception handling > to tell the caller that the given textproto is invalid (instead of a > generic CalledProcessError that eats the important "invalid textproto" > error message. > > Fixed: 558123060 > Change-Id: I202331f00625b5b79d9d8a4419bbc74efb538d24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8366204 > Reviewed-by: Chenlin Fan <fancl@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> Change-Id: Iad175dd848450525adc4cae6e1db0aa01a58bf6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8369602 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by: Chenlin Fan <fancl@chromium.org>	20 小时前
LICENSE_OWNERS	add crowbar CLI to depot_tools Adds an entrypoint to invoke Crowbar CLI in depot_tools. Crowbar CLI is a tool to manage, update, and vendor third-party source code dependencies into Chromium projects. Contributors will write a workflow to define fetch, unpack, and patch steps, then call the CLI in their checkout. The CLI is implemented in: https://source.chromium.org/chromium/infra/infra_superproject/+/main:infra/go/src/infra/tools/crowbar/ Bug: 464370533 Change-Id: Ibf253b8dbec37e2257dc5a1050f87ac40d16629b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7924447 Reviewed-by: Gavin Mak <gavinmak@google.com> Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com>	2 个月前
OWNERS	add crowbar CLI to depot_tools Adds an entrypoint to invoke Crowbar CLI in depot_tools. Crowbar CLI is a tool to manage, update, and vendor third-party source code dependencies into Chromium projects. Contributors will write a workflow to define fetch, unpack, and patch steps, then call the CLI in their checkout. The CLI is implemented in: https://source.chromium.org/chromium/infra/infra_superproject/+/main:infra/go/src/infra/tools/crowbar/ Bug: 464370533 Change-Id: Ibf253b8dbec37e2257dc5a1050f87ac40d16629b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7924447 Reviewed-by: Gavin Mak <gavinmak@google.com> Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com>	2 个月前
PRESUBMIT.py	Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>	1 个月前
README.md	Check `restrictive_license_approvals.textproto` for missing licenses * Update validate() api to accept kwargs * Checks in the generated protobuf file metadata/restrictive_license_approval_pb2.py * Checks if missing licenses are in a provided restrictive_license_allowlist.textproto * A script to parse the textproto with an embedded proto wheel Bug: b/504850951 Change-Id: I15400b78ce1194613b55ebdcde90f92d5c5c350e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7780974 Reviewed-by: Anne Redulla <aredulla@google.com> Commit-Queue: Jordan Brown <rop@google.com>	4 个月前
__init__.py	Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>	1 个月前
dependency_metadata.py	metadata: suppress "CPE requires version" when vuln scan is sufficient This CL suppresses CPE requires version when metadata is already sufficient for vulnerability scanning. Fixed: 556986334 Change-Id: Id7eea3ddf422072ff7c6960c9bd316a5d2595904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8357369 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by: Rachael Newitt <renewitt@google.com>	1 天前
discover.py	Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>	1 个月前
parse.py	Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com>	27 天前
restrictive_license_approval.proto	[metadata] Add restrictive_license_approval.proto Adds the protobuf schema for per-use restrictive license approvals, needed for license compliance automation and presubmit validation. Bug: b/504850951 Change-Id: I940d71281b32c01c9bc36c7be9c8f075f3479cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7781485 Commit-Queue: Jordan Brown <rop@google.com> Reviewed-by: Rachael Newitt <renewitt@google.com>	4 个月前
restrictive_license_approval_pb2.py	Check `restrictive_license_approvals.textproto` for missing licenses * Update validate() api to accept kwargs * Checks in the generated protobuf file metadata/restrictive_license_approval_pb2.py * Checks if missing licenses are in a provided restrictive_license_allowlist.textproto * A script to parse the textproto with an embedded proto wheel Bug: b/504850951 Change-Id: I15400b78ce1194613b55ebdcde90f92d5c5c350e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7780974 Reviewed-by: Anne Redulla <aredulla@google.com> Commit-Queue: Jordan Brown <rop@google.com>	4 个月前
scan.py	Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com>	27 天前
validate.py	Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com>	27 天前
validation_result.py	Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>	1 个月前

Validation for Chromium's Third Party Metadata Files

This directory contains the code to validate Chromium third party metadata files, i.e. README.chromium files.

Prerequisites

Have the Chromium source code checked out on disk
Ensure you've run gclient runhooks on your source checkout

Run

metadata/scan.py can be used to search for and validate all Chromium third party metadata files within a repository. For example, if your chromium/src checkout is at ~/my/path/to/chromium/src, run the following command from the root directory of depot_tools:

vpython3 --vpython-spec=.vpython3 metadata/scan.py ~/my/path/to/chromium/src

Protobuf generation

If you make any changes to metadata/restrictive_license_approval.proto, regenerate the Python bindings from the root directory of depot_tools by running:

protoc --proto_path=. --python_out=. metadata/restrictive_license_approval.proto