用户可借助此项目进行 Chromium 开发,包含 fetch、gclient 等核心工具,支持代码检出、依赖管理和代码审查,还集成 gn、ninja 等构建工具及 AI 代理相关工具。【此简介由AI生成】
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Disable pytest for vscode integration. vscode gets confused about which test provider to use. As such, disable pytests as most of our tests are in unittest. Change-Id: I42c0b54b2d2b8d081137dbd23a171ff56a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7273065 Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> | 9 个月前 | |
[Agents] Enhance luci-test-results script ergonomics and fallbacks Enhances the luci-test-results skill scripts: - Includes ResultDB result resource name ('res') and failure reason ('err') plus normalized boolean 'expected' in check_test.py so results can be passed directly to fetch_log.py. - Exposes fetch_log() helper alias in fetch_log.py for module import consistency. - Adds --test-substring and automatic QueryTests resolution (preferring exact suffix matches) for short Class#method arguments in test_history.py, and attaches resolved bucket/builder fields to multi-builder verdicts. - Falls back to up to 3 preceding patchsets in find_cl_builds.py with a stderr notice and 'patchset' field when the auto-detected latest patchset has 0 trybot builds. Bug: 521893129 Change-Id: Ibc8baa2871e0005fc803cdfab71686c209e90c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8435358 Reviewed-by: Peter Wen <wnwen@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> | 1 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
agents: Add CRAG-generated review agents and skills Sets up two AI review agents that run automatically on new changes. Bug: 539551931 Change-Id: I0fa9837152356b74b0034fc18517634bfa31f1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8159939 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Brian Gan <brgan@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8669874836680199025 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e9fbd61536cafa2cb0f2fd47807c5bf81d8a7991 e9fbd61 (chromium-autoroll@skia-public.iam.gserviceaccount.com) Roll CAS Client from 17aa2034a0c4 to b5ab8c6e7688 Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I34ab8ba0ca145ada52fd6a2c08ef216d13d10714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8446027 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> | 1 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Reland "metadata/rla_approval: improve arg passing and error handling" This is a reland of commit 8a7b59a2990b4c12fdb592c9fa24329677074e4f This reland removes the vpython3.bat resolution that caused failure on linux-presubmit bots. Original change's description: > metadata/rla_approval: improve arg passing and error handling > > This CL changes RLA parsing to use env var to pass file paths to avoid > the need to deal with Windows cmd escaping, and adds exception handling > to tell the caller that the given textproto is invalid (instead of a > generic CalledProcessError that eats the important "invalid textproto" > error message. > > Fixed: 558123060 > Change-Id: I202331f00625b5b79d9d8a4419bbc74efb538d24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8366204 > Reviewed-by: Chenlin Fan <fancl@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> Change-Id: Iad175dd848450525adc4cae6e1db0aa01a58bf6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8369602 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by: Chenlin Fan <fancl@chromium.org> | 16 天前 | |
Fix fetch v8 on unofficial platforms http://crrev.com/c/8333927 broke fetch on ppc64/s390x as we rely on our system provided python. Bug: b/537680330 Change-Id: Ia9c484f5ed939f9108dfe198ae5f6d0d5c5ae85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8367685 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Alex Ovsienko <ovsienko@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 15 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8669874836680199025 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e9fbd61536cafa2cb0f2fd47807c5bf81d8a7991 e9fbd61 (chromium-autoroll@skia-public.iam.gserviceaccount.com) Roll CAS Client from 17aa2034a0c4 to b5ab8c6e7688 Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I34ab8ba0ca145ada52fd6a2c08ef216d13d10714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8446027 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> | 1 天前 | |
Add a presubmit output_parser that accepts stderr / stdout separately Useful when stdout is of a parsable format (e.g. XML). Don't want warnings in stderr to corrupt it. E.g.: https://crrev.com/c/8415852 Removes the 1-arg variant, which was only recently added, and which had only a single usage (which was converted in this change). Bug: 534712288 Change-Id: Icf772b3d7d9c0a8a7266ada837d03ce41a97a67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8427445 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> | 5 天前 | |
Use local commit messages by default for git cl upload The RPC often takes ~.5-1 second, and runs before any other checks can start to run. Bug: 534712288 Change-Id: I31d6b998f627b2d44da6d29bc37338e8676e271a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8446123 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> | 19 小时前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Remove unmaintained "gclient export" command, introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=20990 It was intended for the tarball generation script, but there was a better and simpler way. BUG=80549 Review URL: http://codereview.chromium.org/6883263 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83708 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Add a config file for the flake8 linter. Part of my bigger auto{ninja,siso} refactoring. R=brucedawson@chromium.org, jwata@google.com, tikuta@chromium.org Bug: b/293657720 Change-Id: I2a7783b8675ecc7dac16a490a290b2edf4b9d64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4924716 Reviewed-by: Joanna Wang <jojwang@chromium.org> Commit-Queue: Joanna Wang <jojwang@chromium.org> Auto-Submit: Philipp Wollermann <philwo@chromium.org> | 2 年前 | |
Ruff lint: add relinting change to blame ignore. Bug: 539486220 Change-Id: Ib1c98d05ceaefb2849ab9e831fef61b36a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8254898 Commit-Queue: Junji Watanabe <jwata@google.com> Auto-Submit: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Junji Watanabe <jwata@google.com> | 1 个月前 | |
Add python-bin and bootstrap files to recipes in .gitattributes. Tools bundled into recipe bundles (such as ninja, autoninja, gn, and fetch) invoke python-bin/python3. When bundled via bundle_recipe, python-bin/ was omitted from the recipe bundle, causing invocations of these tools on recipe bots to fail with missing python-bin/python3. Additionally, bootstrapping depot_tools in recipe environments requires ensure_bootstrap, bootstrap_python3, and the bootstrap/ directory to be available in the bundle. This CL tags python-bin/**, bootstrap/**, bootstrap_python3*, and ensure_bootstrap* with the recipes attribute in .gitattributes so they are included in recipe bundles. Bug: b/537680330 TAG=agy CONV=b53bdf70-37e7-4696-be50-8ee6fc19b1f8 Change-Id: Ia6cfb80c6ed34c966341b09eb14979d46a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8385301 Reviewed-by: Fumitoshi Ukai <ukai@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 14 天前 | |
Revert "[depot_tools] Add top-level python3 wrappers with system python bypass" This reverts commit c55f47acb2cfd98f5b522541140d8844e4f0a2e6. Reason for revert: While there were no complaints yet, the lack of parity of CIPD Python and system python is concerning (mostly the fact that CIPD one lacks a lot of preinstalled libraries). We might want to rethink the approach here and devise some less invasive approach, especially as this revert does not affect the builders arm of the effort. Original change's description: > [depot_tools] Add top-level python3 wrappers with system python bypass > > Standardize depot_tools execution wrappers to use CIPD-provided > CPython directly instead of host system python3. > Supports DEPOT_TOOLS_PYTHON_BYPASS environment variable to allow falling > back to host system python3 if needed. > > Updates both POSIX shell script (python3) and Windows batch wrapper > (python3.bat) to directly resolve CIPD CPython via python3_bin_reldir.txt. > Also removes legacy root python3 deletion from update_depot_tools. > > Bug: 537680330 > TAG=agy > CONV=b1f27bd3-1fdc-47bd-a2a3-644f3858d1e5 > > Change-Id: Ie7f60be3c576654ef8e4b77ee81c0b5b6a6a6964 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8162440 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Alex Ovsienko <ovsienko@google.com> Bug: 537680330 Change-Id: I17884918d19719e95bf71eccf37d1bbefbb9dd04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8215807 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Include BUILD_OWNERS from the source of truth. Change-Id: I3b02c2e75fb831c00406b0587e1c956e6a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7480042 Auto-Submit: Matt Stark <msta@google.com> Commit-Queue: Matt Stark <msta@google.com> Reviewed-by: Philipp Wollermann <philwo@google.com> Reviewed-by: Fumitoshi Ukai <ukai@google.com> | 8 个月前 | |
CROS_OWNERS: switch to our common shared lists Change-Id: I7c05247729f4b569c9d6a95813d8849972c9b985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3849003 Reviewed-by: Cindy Lin <xcl@google.com> Commit-Queue: Cindy Lin <xcl@google.com> Auto-Submit: Mike Frysinger <vapier@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> | 4 年前 | |
[DIR_METADATA] Migrate from Monorail to Buganizer. Bug: none Change-Id: I6889f64ee04675b3da2c7f4c576d407cdb03d4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6935512 Reviewed-by: Brian Ryner <bryner@google.com> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Brian Ryner <bryner@google.com> | 1 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update LUCI_OWNERS to remove inactive members They either left Google or no longer works on LUCI Change-Id: I413ac847ceeaf2fd365e6f1c5ce0b68441cd676a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8178226 Commit-Queue: Yiwei Zhang <yiwzhang@google.com> Reviewed-by: Chan Li <chanli@chromium.org> Auto-Submit: Yiwei Zhang <yiwzhang@google.com> | 1 个月前 | |
Reland "UV: make the first conversion. Convert Ruff to UV." This reverts commit 88258c9ceb915fbc56b5b51e1c808514026e31a7. Reason for revert: reland again with vpython version update Original change's description: > Revert "UV: make the first conversion. Convert Ruff to UV." > > This reverts commit db395c47f653b18d647fd238e3fd0b1487da793b. > > Reason for revert: reported issue in the comment. > > Failure Link: <LINK TO FAILURE> > > Original change's description: > > UV: make the first conversion. Convert Ruff to UV. > > > > Additionally adjust ownership to give ownership of the lock file to the owner of the main file, in this case myself. > > > > Bug: b/491263752 > > Change-Id: Icef325612f39251d57c063d83562ed556a6a6964 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8179721 > > Reviewed-by: Richard Wang <richardwa@google.com> > > Commit-Queue: Alex Ovsienko <ovsienko@google.com> > > Bug: b/491263752 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I65ab58849897716ee3ca637c6fa42a9e865768e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8186536 > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Alex Ovsienko <ovsienko@google.com> Bug: b/491263752 Change-Id: I26017a8275f1d570275d8c283e81f6a5027bb40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8190014 Reviewed-by: Richard Wang <richardwa@google.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 1 个月前 | |
presubmit: activate CheckVPythonSpec for depot_tools Activate CheckVPythonSpec in depot_tools/PRESUBMIT.py to verify that changed vpython specification files (vpython.toml / PEP 723) match their companion uv.lock lockfiles. Also remove the obsolete -vpython-spec verify_spec invocation from presubmit_canned_checks.py since verify_lockfile.py now uses inline PEP 723 script metadata and runs directly with vpython3. Bug: b/491263752 TAG=agy CONV=b515f9ed-e0b3-471d-a9bf-26ccd1e4013c Change-Id: Ifdd4a79befd9952cffa6975d9e380b136a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8332727 Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Junji Watanabe <jwata@google.com> | 23 天前 | |
docs: Removing references to SVN BUG=643697 TEST=None Review-Url: https://codereview.chromium.org/2350293002 | 9 年前 | |
git cl format: Format .html.ts files for opted in directories Allow directories to opt-in to .html.ts file formatting using the WebUI Lit template formatter using the same file mechanism used to opt-in to other file formatting like markdown files. Add tests that the Lit template formatter is invoked when a marker file is present and that the correct flags are passed through from git cl format (--diff, --dry-run). Bug: 512911634 Change-Id: Ie3c4e8a8f0219318e9ae3a1650d6f67d982d9467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8066346 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> | 2 个月前 | |
Document the current state of LUCI GCS integration Change-Id: I39c01200208de15e5ce2101ecc273f823875bc0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6326717 Auto-Submit: Dan Le Febvre <dlf@google.com> Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Scott Lee <ddoman@chromium.org> | 1 年前 | |
agents: Add CRAG-generated review agents and skills Sets up two AI review agents that run automatically on new changes. Bug: 539551931 Change-Id: I0fa9837152356b74b0034fc18517634bfa31f1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8159939 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Brian Gan <brgan@google.com> | 1 个月前 | |
Add convenience wrapper for reclientreport for autoninja users This is designed to be called by a developer when they want to submit an reclient bug report. Developers could just call the //buildtools/reclient/reclientreport binary directly but this wrapper provides an easier way to set the same log flags that are set by ninja_reclient. I dont think we should bundle this logic into autoninja as this is not required in 99% of builds. Bug: b/277763387 Change-Id: I0204b6acc22f199b461ef710d0dfd07e05534af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4414921 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Ben Segall <bentekkie@google.com> | 3 年前 | |
add crowbar CLI to depot_tools Adds an entrypoint to invoke Crowbar CLI in depot_tools. Crowbar CLI is a tool to manage, update, and vendor third-party source code dependencies into Chromium projects. Contributors will write a workflow to define fetch, unpack, and patch steps, then call the CLI in their checkout. The CLI is implemented in: https://source.chromium.org/chromium/infra/infra_superproject/+/main:infra/go/src/infra/tools/crowbar/ Bug: 464370533 Change-Id: Ibf253b8dbec37e2257dc5a1050f87ac40d16629b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7924447 Reviewed-by: Gavin Mak <gavinmak@google.com> Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> | 3 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
git-cl: Lazy-import formatters and heavy dependencies on startup. Top-level module imports in git_cl.py accounted for ~540 ms of startup latency on every invocation of git-cl (including lightweight commands like status, diff, and issue). This CL introduces three optimizations: 1. Move legacy tag matching regex (TAG_LINE_RE) to git_footers.py, eliminating the top-level presubmit_support import (~325 ms savings). 2. Defer importing httplib2 in auth.py to Authenticator.authorize(), reducing auth.py import time from ~172 ms to ~1.1 ms. 3. Defer subcommand-specific formatters and linters (clang_format, google_java_format, ktfmt, rustfmt, swift_format, metrics_xml_format, presubmit_canned_checks, split_cl, git_new_branch, git_squash_branch, owners_finder) to their respective functions (~40 ms savings). Total startup latency drops from ~540 ms to ~145 ms (73% speedup). Test: vpython3 tests/git_cl_test.py Test: vpython3 tests/presubmit_support_test.py Test: vpython3 tests/auth_test.py Test: vpython3 tests/git_footers_test.py Change-Id: I916bc6b8ce179e04ea9b476a31915a66f9b50f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8266647 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Alex Ovsienko <ovsienko@google.com> | 1 个月前 | |
autoninja: check DEPOT_TOOLS_USE_VIRTUAL_BUILD_PATH Bug: 549548891 Change-Id: I4f2a71179d4693f5c32eafd81a9c15da836c09b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8255433 Commit-Queue: Fumitoshi Ukai <ukai@google.com> Commit-Queue: Junji Watanabe <jwata@google.com> Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Junji Watanabe <jwata@google.com> Reviewed-by: Neri Marschik <nerima@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Use relative path for cipd Using $base_dir/cipd as a path for the cipd command only works when $base_dir is an absolute path, not when it is a relative path, as the current directory is already $base_dir. Therefore, "./cipd" must be used to run a command located in $base_dir. Change-Id: Ia882a7fb404b7ff837944f80c0ace3f4e90e6a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4479169 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Commit-Queue: Yngve Pettersen <yngve@vivaldi.com> | 3 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
autoninja: Implement build_telemetry utils This will replace the user consent logics in ninjalog_uploader_wrapper.py and reclient_metrics.py See also https://crrev.com/c/5669094 for how this will be used. Bug: 345113094 Change-Id: Iffc4975c152ba63f7577c09e5254c499fe8973c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5671052 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Reviewed-by: Fumitoshi Ukai <ukai@google.com> Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org> | 2 年前 | |
autoninja: Implement build_telemetry utils This will replace the user consent logics in ninjalog_uploader_wrapper.py and reclient_metrics.py See also https://crrev.com/c/5669094 for how this will be used. Bug: 345113094 Change-Id: Iffc4975c152ba63f7577c09e5254c499fe8973c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5671052 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Reviewed-by: Fumitoshi Ukai <ukai@google.com> Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org> | 2 年前 | |
build_telemetry: Use temporary file for cipd auth-info json output When cipd auth-info --json-output - is executed, human-readable log messages (such as "Using CredentialHelperMethod ...") are also printed to stdout alongside the JSON object. This causes json.loads() to fail with JSONDecodeError: Expecting value: line 1 column 1 (char 0). By writing the JSON output to a temporary file via --json-output <path>, only valid JSON is written to the file and stdout logs do not pollute the parsed output. Bug: None Change-Id: I84d4cf6db01c6c0ab26922fdec254fae1aeedbe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8341711 Commit-Queue: Alex Ovsienko <ovsienko@google.com> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Alex Ovsienko <ovsienko@google.com> | 21 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Roll cipd to v2.9.2 Bug: 549356447 Change-Id: I532c2e2dfe69c7f9510b8834c6d94b81a20e9168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8332367 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Dan Le Febvre <dlf@google.com> | 23 天前 | |
Roll cipd to v2.9.2 Bug: 549356447 Change-Id: I532c2e2dfe69c7f9510b8834c6d94b81a20e9168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8332367 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Dan Le Febvre <dlf@google.com> | 23 天前 | |
Roll Crowbar CLI Change-Id: I1f5242af42587e40ed9d7e762456468b8f9c23c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8433903 Commit-Queue: Chenlin Fan <fancl@chromium.org> Reviewed-by: Chenlin Fan <fancl@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> | 1 天前 | |
Roll Crowbar CLI Change-Id: I1f5242af42587e40ed9d7e762456468b8f9c23c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8433903 Commit-Queue: Chenlin Fan <fancl@chromium.org> Reviewed-by: Chenlin Fan <fancl@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> | 1 天前 | |
remove goma CIPD package goma is not used by developers now. Bug: b/304421889 Change-Id: I68ffd73336f2303484dd44bce6c3984b06faa681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5395370 Reviewed-by: Junji Watanabe <jwata@google.com> Reviewed-by: Joanna Wang <jojwang@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Fumitoshi Ukai <ukai@google.com> | 2 年前 | |
Redirect cros calls to py2.7 scripts to the vpython2.7 package. Bug: 1245665 Change-Id: I1b75e2a515e6c8b1b7b0192946a2cfd5295a21f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4015440 Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Brian Ryner <bryner@google.com> | 3 年前 | |
ruff_chromium: port .yapfignore & CLI flags; delete _RunYapf Make ruff_chromium 100% self-contained for all Python formatting workflows (batch mode, CLI, and stdin formatting) so that cl_format.py no longer needs legacy YAPF fallback logic: - Port .yapfignore pattern loading and filtering (get_yapfignore_patterns, is_yapf_ignored, filter_yapf_ignored_files) into ruff_chromium for both --batch mode and single-file CLI invocations. - Translate Ruff's --check flag to YAPF's -q (--quiet) flag in translate_args(), and avoid appending -i when --check is passed. - Pass resolved --style from get_yapf_style() to single-file CLI YAPF invocations in main() so directories using setup.cfg or default pep8 style are formatted identically to batch mode. - When stdin ('-') is passed for an unconfigured or .yapfignore-excluded file and neither --diff nor --check is requested, echo stdin to stdout unchanged so editor/VCS filter pipelines (e.g. jj fix) do not wipe the file buffer. - Support --force-python on the CLI and force_python in --batch JSON to preserve 'git cl format --python' behavior when no .style.yapf or ruff.toml is present. - Delete dead _RunYapf, _FindYapfConfigFile, _IsRuffBatchSupported, and duplicate .yapfignore helpers from cl_format.py and git_cl.py. Change-Id: I0f884cb9c8c0cb8f8588a1d98bc3fcf6176febc0 TAG=agy CONV=f80af470-12c5-46b4-b4f7-6e95973f19de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8421779 Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Marc Jin <jmarc@google.com> | 7 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
update stale codereview.chromium.org links w/chromium-review.googlesource.com Change-Id: I8f024d68a3b89ae530fc1ce2806b9b12b83ba7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2585050 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: James Zern <jzern@google.com> | 5 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
cros: require Python 3.9 now Slowly step people up a version since we have no one testing/validating Python 3.8 anywhere, and Python 3.8 went EOL 2 years ago. Change-Id: I2c7978046e0dca61696a0a81434f141e6baf1412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8354505 Auto-Submit: Mike Frysinger <vapier@chromium.org> Reviewed-by: Raul Rangel <rrangel@chromium.org> Commit-Queue: Raul Rangel <rrangel@chromium.org> | 20 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
simplify the chromite wrappers The support/ dir has only ever been used to host a single CrOS file. We can move that to cros (which is the primary tool in the CrOS world), and have the few other wrapped programs point to that. Bug: None Change-Id: I3ba3cc7375d357d62fb464e1b6dc37e73bc83cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1876639 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> | 6 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Make some of the tools use hermetic python in the python-bin. Bug: b/537680330 Change-Id: I5227080c414792fb6c0fbe78626f5ebf6a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8333927 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 16 天前 | |
Make some of the tools use hermetic python in the python-bin. Bug: b/537680330 Change-Id: I5227080c414792fb6c0fbe78626f5ebf6a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8333927 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 16 天前 | |
gclient: add bootstrap cache mode detaching checkouts from the mirror fetch --git-cache leaves the checkout in the bot-oriented cache topology: origin's fetch URL is the local mirror path and objects are borrowed via .git/objects/info/alternates. For a developer that means plain git fetch/pull reads the stale local cache instead of the network, and deleting the cache directory corrupts every checkout cloned from it. Add cache_mode = "bootstrap" to .gclient (default "shared" keeps today's behavior for bots): the mirror only seeds checkouts that do not exist yet. The clone drops --shared (objects are hardlinked or copied) and the fetch URL is set to the real remote right after the clone, so the checkout is configured like one made without a cache and the cache can be deleted at any time. fetch --git-cache selects this mode. Change-Id: I176544693d66d727e062bf2b9c4c81b62647b910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8037665 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Neri Marschik <nerima@google.com> Reviewed-by: Philipp Wollermann <philwo@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
gclient-new-workdir: Refresh index stat cache after CoW copy When copying a workdir using copy-on-write on APFS or reflink-enabled filesystems, file inodes and ctimes change while modification times and file sizes are preserved. Because .git/index is copied directly from the source repository, its cached stat metadata contains the old inodes, causing the first git status in the new worktree to treat all files as stat-dirty and re-hash their contents on disk. This change runs update-index with core.checkStat=minimal immediately after copying the index. Under core.checkStat=minimal, Git matches files using mtime and size without hashing, refreshing the cached inodes in .git/index instantly. Bug: None Change-Id: I27c72330ece223de0e17518cba3c90d1c531cb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8126720 Reviewed-by: Gavin Mak <gavinmak@google.com> Auto-Submit: Justin Cohen <justincohen@google.com> Commit-Queue: Justin Cohen <justincohen@google.com> | 1 个月前 | |
Pad bat scripts so pre-fix checkouts update cleanly 84b69fc5b stopped gclient.bat, fetch.bat and gsutil.py.bat from resuming at a stale byte offset after update_depot_tools.bat rewrites them, by chaining the update call with a GOTO that rewinds cmd.exe's file pointer. That only helps checkouts that already have the fix. Checkouts that have not updated since 2026-08-05 still run the old scripts, which call update_depot_tools.bat on a line of its own, so they still resume mid-line in the newly checked out file. For gclient.bat the stale offset is byte 365, which in the current file is the middle of ":: Abort the script if we failed to update depot_tools.", so cmd.exe executes "date depot_tools." and blocks prompting for a new system date. Pad scripts with harmless colon labels across historical resume offsets (since 2013) so stale checkouts update cleanly. Removable once checkouts older than 2026-08-05 are gone. Bug: 542670559 Change-Id: I28c35fb2b4c6341494e9551880dd99ad1436a095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8284188 Auto-Submit: Gavin Mak <gavinmak@google.com> Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> | 29 天前 | |
Reland "Prevent argument injection in git commands and ref validation" This is a reland of commit 07a71782a10388962cdb12e939946fbec3a04866 Original change's description: > Prevent argument injection in git commands and ref validation > > Reject revisions, patch refs, and refspecs starting with '-' across > gclient and bot_update to prevent option injection into git. Also add > '--' and '--end-of-options' separators to git fetch, checkout, and > rev-parse invocations. > > Bug: 557923516 > Change-Id: I5fdbd39175527c2d2a4578f7aafd0a0c6b1312d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8394197 > Commit-Queue: Gavin Mak <gavinmak@google.com> > Reviewed-by: Brian Gan <brgan@google.com> Bug: 557923516 Change-Id: I24b0941d7d928d671035eb34cc484b62b73423e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8401307 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> | 7 天前 | |
Added basic completion (the commands) for gclient. To try it out, do . $DEPOT_TOOLS/gclient_completion.sh Review URL: https://codereview.chromium.org/100463007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245134 0039d316-1c4b-4281-b951-d872f2087c98 | 12 年前 | |
gclient: Allow relative gclient_gn_args_file starting with './'. Allow '.' segments in IsSafeGNArgsPath so relative paths like './build/args.gn' are accepted, while still rejecting paths ending in '.', empty segments, '..' traversals, and hidden files. Bug: 557838533 Change-Id: I52e3f23247f5b84ea10aa4034d34f3ed22768f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8410586 Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by: Brian Gan <brgan@google.com> | 8 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Gate --end-of-options in git checkout on Git >= 2.44.0 git checkout only added support for --end-of-options in Git 2.44.0. Older versions of Git fail when --end-of-options is passed to git checkout, treating it as a pathspec. Bug: 562758316 Bug: 557923516 Change-Id: Ic2718b8b8dcd7d0e4aa6beefd9943cc0f5e89ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8420430 Commit-Queue: Brian Gan <brgan@google.com> Auto-Submit: Gavin Mak <gavinmak@google.com> Reviewed-by: Brian Gan <brgan@google.com> | 6 天前 | |
Reland "Prevent argument injection in git commands and ref validation" This is a reland of commit 07a71782a10388962cdb12e939946fbec3a04866 Original change's description: > Prevent argument injection in git commands and ref validation > > Reject revisions, patch refs, and refspecs starting with '-' across > gclient and bot_update to prevent option injection into git. Also add > '--' and '--end-of-options' separators to git fetch, checkout, and > rev-parse invocations. > > Bug: 557923516 > Change-Id: I5fdbd39175527c2d2a4578f7aafd0a0c6b1312d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8394197 > Commit-Queue: Gavin Mak <gavinmak@google.com> > Reviewed-by: Brian Gan <brgan@google.com> Bug: 557923516 Change-Id: I24b0941d7d928d671035eb34cc484b62b73423e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8401307 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> | 7 天前 | |
Symlink gerrit CLI into depot_tools The "gerrit" tool works just fine outside the SDK. Let's start teaching people to use it outside the SDK by putting it in their PATH. Bug: b:275597798 Change-Id: I79c8090d4e5e205bcac2b763751537791caafe91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4377791 Auto-Submit: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> | 3 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
git_cl: Remove TBR feature Remove the TBR feature from git cl entirely: - Stop parsing TBR= lines as reviewers in ChangeDescription. - Remove the tbr_only option from ChangeDescription.get_reviewers(). - Stop injecting Code-Review votes for TBRs in Changelist._GetRefSpecOptions(). - Remove unused gerrit_util.GetCodeReviewTbrScore(). Fixed: 558048537,40767138 Change-Id: Ia118fd3b571fb4eb07607e9c744e931d8539f79f TAG=agy CONV=94abcbd5-00af-4c7f-a146-81191dac9c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8424922 Commit-Queue: Joey Scarr <jsca@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> | 3 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Revert "Remove unused functionality in bot_update.py" This reverts commit 8b64ddec2a54503ca802a545cd19ca368ab27448. Reason for revert: it appears we need this, since .DEPS.git specifies custom dependencies needed for tryjob. Original change's description: > Remove unused functionality in bot_update.py > > .DEPS.git has been removed in 2014 and no longer supported. It was > deleted in https://codereview.chromium.org/497313003 (August 2014). Last > entry in chromium/src is from tag 44.0.2403.47 in June 2015. > > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited > Recipe-Nontrivial-Roll: chrome_release > Recipe-Nontrivial-Roll: chromiumos > Recipe-Nontrivial-Roll: infra > Change-Id: I3ffb8813af867df959098c02d399c8d745894aae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3439573 > Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> Change-Id: I36bcd352a984b4b762096197a384e86347418290 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3448707 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> | 4 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
git_auth: Add a divider for readability There's some slightly spammy output above this, so make it friendly to read the closing instructions. Change-Id: I2b23bf0686f37cc0f5704fd38ffef34e600c7636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8198527 Commit-Queue: Allen Li <ayatane@chromium.org> Auto-Submit: Allen Li <ayatane@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> | 1 个月前 | |
git_cache: heal mirrors whose HEAD is dead after a default-branch rename A bare mirror's HEAD is set at creation and never updated by fetch. When the remote renames its default branch, the mirror's HEAD either dangles (old branch deleted) or stays on the frozen old branch. Both break the bootstrap generation number: update-bootstrap then skips the snapshot upload while reporting success, so the snapshot silently freezes at the rename date. On chromium.googlesource.com this froze e.g. VK-GL-CTS (2021-05) and project-oak/oak; every bootstrap from such a snapshot re-downloads and re-indexes all history since the freeze (126,490 objects for VK-GL-CTS). Heal in populate: when HEAD dangles (existing check) and also when HEAD's branch is much older than the newest branch in the mirror, point HEAD at the remote's advertised default branch. If the remote does not advertise one (several GitHub mirrors on chromium.googlesource.com have a HEAD broken the same way), or advertises a branch this mirror does not carry, fall back to the most recently committed well-known branch name (a frozen pre-rename master must not beat a live upstream/main), else the newest branch. Only a ref the mirror actually holds is ever installed, so healing cannot swap one dead HEAD for another. Values git prints are read with stderr discarded: RunGit folds stderr into its result, and one warning line there would make the staleness check parse garbage and silently report "not stale", re-freezing the snapshot this change exists to unfreeze. And when update-bootstrap still cannot compute a generation number, fail instead of returning success, so updater builders go red rather than freezing snapshots quietly. Bug: 492363028 Change-Id: I538f0a5770c6e5005f6ff700710a165449da9afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8038341 Reviewed-by: Philipp Wollermann <philwo@google.com> Commit-Queue: Neri Marschik <nerima@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> | 3 天前 | |
Use local commit messages by default for git cl upload The RPC often takes ~.5-1 second, and runs before any other checks can start to run. Bug: 534712288 Change-Id: I31d6b998f627b2d44da6d29bc37338e8676e271a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8446123 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> | 19 小时前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Reland "Ruff lint: add support for Python linting to git cl lint." This reverts commit 65cd67ed5cf5995455999fcc0e189e8c113dccc0. Reason for revert: Amending the previously discovered issues. Fix output_parser for Ruff to be returncode-aware (return None on exit code 0) and remove output_parser from legacy Pylint to avoid treating Pylint's score banner as an error. Original change's description: > Revert "Ruff lint: add support for Python linting to git cl lint." > > This reverts commit 8ff4a322a17ea014561931720c8153904cd0a9c3. > > Reason for revert: Presubmit repeatedly failing with 16 errors > > Failure Link: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-presubmit > > Original change's description: > > Ruff lint: add support for Python linting to git cl lint. > > > > The algorithm will parse files above to find the presubmit, > > and from that presubmit will infer what engine to use > > (ruff or pylint). > > > > Additionally it also support --fix flag now > > (supported for Ruff) > > > > When the Python presubmit fails, the presubmit will > > now print the message for the user directing them > > how to reproduce the linting issues locally. > > > > Proposal doc: https://docs.google.com/document/d/1PpSFS8EMZmyf2boX5CfXWO76cEB0t1V7JB18TfSbaDA/edit?tab=t.0#heading=h.1yrdgwok80g9 > > > > Bug: 539486220 > > Change-Id: I565f9731bfc8e1cf9f52c2d65f6aff936a6a6964 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8259909 > > Reviewed-by: Richard Wang <richardwa@google.com> > > Commit-Queue: Alex Ovsienko <ovsienko@google.com> > > Bug: 539486220 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I1b2f3247ce00ec5a6a62ddd97130644290316613 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8268044 > Reviewed-by: Alex Ovsienko <ovsienko@google.com> > Owners-Override: Orin Jaworski <orinj@chromium.org> > Reviewed-by: Orin Jaworski <orinj@chromium.org> > Commit-Queue: Orin Jaworski <orinj@chromium.org> TAG=agy CONV=313ef9b4-5753-46c3-bb80-5aa0b6a0a53b Bug: 539486220 Change-Id: Id523af93d411d25b5480d6e4ed64c13df4ab0cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8408967 Reviewed-by: Richard Wang <richardwa@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 9 天前 | |
git_map_branches: Eliminate per-branch git log in --show-subject Previously, passing --show-subject to git map-branches spawned a separate git log -n1 --format=%s <branch> -- process for every branch in the repository (N + R processes). This change: 1. Includes %(subject) in the for-each-ref call inside get_branches_info(), adding subject to BranchesInfo. 2. Reads branch_info.subject directly in __append_branch(), eliminating the per-branch git log subprocesses. 3. Guards __is_dormant_branch() so config checks are skipped when dormant status is neither hidden nor displayed. 4. Updates unit test expectations in git_common_test.py. Change-Id: Idb97fcb539e5b36f974916bfb6cd3623b4c9f7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8338048 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Patrick Monette <pmonette@chromium.org> | 21 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
git-cl: Lazy-import formatters and heavy dependencies on startup. Top-level module imports in git_cl.py accounted for ~540 ms of startup latency on every invocation of git-cl (including lightweight commands like status, diff, and issue). This CL introduces three optimizations: 1. Move legacy tag matching regex (TAG_LINE_RE) to git_footers.py, eliminating the top-level presubmit_support import (~325 ms savings). 2. Defer importing httplib2 in auth.py to Authenticator.authorize(), reducing auth.py import time from ~172 ms to ~1.1 ms. 3. Defer subcommand-specific formatters and linters (clang_format, google_java_format, ktfmt, rustfmt, swift_format, metrics_xml_format, presubmit_canned_checks, split_cl, git_new_branch, git_squash_branch, owners_finder) to their respective functions (~40 ms savings). Total startup latency drops from ~540 ms to ~145 ms (73% speedup). Test: vpython3 tests/git_cl_test.py Test: vpython3 tests/presubmit_support_test.py Test: vpython3 tests/auth_test.py Test: vpython3 tests/git_footers_test.py Change-Id: I916bc6b8ce179e04ea9b476a31915a66f9b50f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8266647 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Alex Ovsienko <ovsienko@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
git_map_branches: Eliminate per-branch git log in --show-subject Previously, passing --show-subject to git map-branches spawned a separate git log -n1 --format=%s <branch> -- process for every branch in the repository (N + R processes). This change: 1. Includes %(subject) in the for-each-ref call inside get_branches_info(), adding subject to BranchesInfo. 2. Reads branch_info.subject directly in __append_branch(), eliminating the per-branch git log subprocesses. 3. Guards __is_dormant_branch() so config checks are skipped when dormant status is neither hidden nor displayed. 4. Updates unit test expectations in git_common_test.py. Change-Id: Idb97fcb539e5b36f974916bfb6cd3623b4c9f7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8338048 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Patrick Monette <pmonette@chromium.org> | 21 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
git rebase-update: Guard in-memory replay against git.current_branch() Previously, rebase_branch() checked branch != return_branch to determine whether a branch was safe to rebase in-memory using git replay and git update-ref. When resuming a previously interrupted rebase-update, return_branch (read from depot-tools.rebase-update.starting-branch in git config) can differ from the currently checked-out branch (HEAD). In that scenario, rebase_branch() treated the checked-out branch as a background branch and updated its ref via git update-ref. Updating the checked-out branch via git update-ref moves HEAD to the new commit without updating the index or working tree on disk, leaving the index full of staged reverse diffs and causing subsequent rebases to fail. Fix this by checking branch != git.current_branch() so the currently checked-out branch is never updated in-memory via git update-ref. Change-Id: I1a3967c8b848e272928add3f76d883d25dc76368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8370641 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by: Brian Gan <brgan@google.com> | 15 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Pad bat scripts so pre-fix checkouts update cleanly 84b69fc5b stopped gclient.bat, fetch.bat and gsutil.py.bat from resuming at a stale byte offset after update_depot_tools.bat rewrites them, by chaining the update call with a GOTO that rewinds cmd.exe's file pointer. That only helps checkouts that already have the fix. Checkouts that have not updated since 2026-08-05 still run the old scripts, which call update_depot_tools.bat on a line of its own, so they still resume mid-line in the newly checked out file. For gclient.bat the stale offset is byte 365, which in the current file is the middle of ":: Abort the script if we failed to update depot_tools.", so cmd.exe executes "date depot_tools." and blocks prompting for a new system date. Pad scripts with harmless colon labels across historical resume offsets (since 2013) so stale checkouts update cleanly. Removable once checkouts older than 2026-08-05 are gone. Bug: 542670559 Change-Id: I28c35fb2b4c6341494e9551880dd99ad1436a095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8284188 Auto-Submit: Gavin Mak <gavinmak@google.com> Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> | 29 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Add support for ktfmt We plan on using ktfmt as our official Kotlin formatter. Bug: 539988177 Change-Id: I2258e8324f7c8d1c5b26ad8d9ed636472ef80fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8232441 Auto-Submit: Sam Maier <smaier@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Add LUCI CLI tool to depot_tools. This adds the unified LUCI CLI tool (infra/tools/luci/luci) to depot_tools CIPD manifest and adds wrapper shims. BUG=None TEST=None TAG=agy CONV=2062bf49-70f8-45ff-9da6-10f7dd9354b3 Change-Id: I28cdfa77bb4d834c90a03816f3adc09aa68d9a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8073818 Reviewed-by: Chenlin Fan <fancl@chromium.org> Auto-Submit: Matthew Warton <mwarton@google.com> Commit-Queue: Chenlin Fan <fancl@chromium.org> Reviewed-by: Allen Xie <zhihuixie@google.com> Commit-Queue: Allen Xie <zhihuixie@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Add luci-auth-fido2-plugin This plugin handles FIDO2 security keys for doing auth and integrates with luci-auth (specifically git-credential-luci). (It's in Python because tl;dr the Python library is much better.) Bug: 433851494 Change-Id: Ib956b614588aad8ad4fda7619bfbae17a670438f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6804585 Reviewed-by: Scott Lee <ddoman@chromium.org> Commit-Queue: Allen Li <ayatane@chromium.org> | 1 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Add LUCI CLI tool to depot_tools. This adds the unified LUCI CLI tool (infra/tools/luci/luci) to depot_tools CIPD manifest and adds wrapper shims. BUG=None TEST=None TAG=agy CONV=2062bf49-70f8-45ff-9da6-10f7dd9354b3 Change-Id: I28cdfa77bb4d834c90a03816f3adc09aa68d9a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8073818 Reviewed-by: Chenlin Fan <fancl@chromium.org> Auto-Submit: Matthew Warton <mwarton@google.com> Commit-Queue: Chenlin Fan <fancl@chromium.org> Reviewed-by: Allen Xie <zhihuixie@google.com> Commit-Queue: Allen Xie <zhihuixie@google.com> | 2 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
[metrics] Add new auth metric Bug: b/358442026 Change-Id: If91494b52fe27177f68e42ec40977fd8ca1fd4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5786166 Commit-Queue: Allen Li <ayatane@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> | 2 年前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Remove histogram_suffixes_list.xml from metrics_xml_format.py Support for histogram suffixes has been removed from Chromium metrics tools (crrev.com/c/8334171) and the Tricium metrics analyzer (crrev.com/c/8396106), as histogram suffixes are no longer used in Chromium. This removes histogram_suffixes_list.xml from the set of supported XML filenames in metrics_xml_format.py. TAG=agy CONV=31ad291a-6159-47e0-b03a-336e19f6987a Bug: 402455327 Change-Id: I00dbb6b3558e60acd8ce613b41aa5648e10a3131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8402465 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Brian Gan <brgan@google.com> | 9 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Make some of the tools use hermetic python in the python-bin. Bug: b/537680330 Change-Id: I5227080c414792fb6c0fbe78626f5ebf6a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8333927 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 16 天前 | |
Make some of the tools use hermetic python in the python-bin. Bug: b/537680330 Change-Id: I5227080c414792fb6c0fbe78626f5ebf6a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8333927 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 16 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Add a presubmit output_parser that accepts stderr / stdout separately Useful when stdout is of a parsable format (e.g. XML). Don't want warnings in stderr to corrupt it. E.g.: https://crrev.com/c/8415852 Removes the 1-arg variant, which was only recently added, and which had only a single usage (which was converted in this change). Bug: 534712288 Change-Id: Icf772b3d7d9c0a8a7266ada837d03ce41a97a67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8427445 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> | 5 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
presubmit: Extract ThreadPool and result types to separate modules. This refactoring separates the presubmit execution engine and result data types out of presubmit_support.py into standalone modules: 1. presubmit_results.py: Contains _PresubmitResult, _PresubmitError, _PresubmitPromptWarning, _PresubmitNotifyResult, _MailTextResult, and _PresubmitResultLocation without external depot_tools dependencies. - Extracts module-level _ensure_str function. - Adds a newline separator before appending call stacks to non-empty long_text in _PresubmitResult. - Fixes _MailTextResult initialization by raising NotImplementedError directly rather than failing with TypeError on zero-arg base call. 2. presubmit_thread_pool.py: Contains ThreadPool, CommandData, SigintHandler, Timer, and time_time (-284 lines in presubmit_support.py), consuming presubmit_results.py directly to eliminate circular imports, and modernizes worker thread construction with daemon=True. 3. Tests: Adds dedicated unit tests in tests/presubmit_results_test.py and moves thread pool unit tests into tests/presubmit_thread_pool_test.py. All extracted symbols are re-exported in presubmit_support.py for full backward compatibility. Bug: none Test: vpython3 tests/presubmit_results_test.py Test: vpython3 tests/presubmit_thread_pool_test.py Test: vpython3 tests/presubmit_unittest.py Change-Id: Id2a5337631163a84ee8ed68c0e1ec6355ac53305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8283087 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: James Hawkins <jhawkins@chromium.org> | 29 天前 | |
presubmit: Add InputApi.HasAffectedFiles() helper Nested PRESUBMIT.py scripts frequently run unit tests and linters unconditionally across an entire directory tree even when no relevant files were modified (e.g. running Python unit tests when only editing GN build configs, Markdown docs, or test data). While bool(input_api.AffectedFiles()) can detect whether *any* file in the directory was touched, most checks care about specific file types or specific subdirectories. Using AffectedFiles(file_filter=...) or manual comprehension filters is repetitive, error-prone (handling Windows vs POSIX separators, case sensitivity, deleted files), and requires iterating over the file list. In contrast, HasAffectedFiles() provides a clean 1-line query and leverages the pre-cached AffectedExtensions() for an O(1) set intersection check. This change adds InputApi.HasAffectedFiles(*, extensions=None, path=None, recursive=True, include_deletes=True). All arguments are keyword-only to avoid accidentally passing a path string as an extension. Callers can query whether any affected files match either: 1. A file extension or list of extensions (e.g. extensions='.py'), leveraging the cached AffectedExtensions() for fast O(1) checks across the presubmit directory tree, or checking direct children when recursive=False. 2. A path, exact filename, or list of paths/files (e.g. path='machine_times' or path=['PRESUBMIT.py', 'PRESUBMIT_test.py']). 'extensions' and 'path' are mutually exclusive to avoid ambiguity. Also adds HasAffectedFiles to MockInputApi and unit test coverage in presubmit_unittest.py. An audit across chromium/src revealed 108 test runner invocations across 94 nested PRESUBMIT.py files exhibiting this pattern. In presubmit benchmarks across representative commits, spawning these unneeded test subprocesses adds 0.8s–1.2s+ of overhead (e.g., editing Markdown files under agents/skills/ spawned 5 test subprocesses taking ~1.1s, and editing GN configs under build/ spawned 6 test subprocesses taking ~0.8s). This helper will immediately be used in chromium/src to scope checks in high-traffic directories (build/, testing/, tools/, agents/skills/, content/test/gpu/, tools/mb/). Bug: 534712288 Test: vpython3 tests/presubmit_unittest.py Change-Id: Ibba0b93007b9ccbd4a1ada14ed8ad0f62d623000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8406664 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Alex Ovsienko <ovsienko@google.com> | 9 天前 | |
Add a presubmit output_parser that accepts stderr / stdout separately Useful when stdout is of a parsable format (e.g. XML). Don't want warnings in stderr to corrupt it. E.g.: https://crrev.com/c/8415852 Removes the 1-arg variant, which was only recently added, and which had only a single usage (which was converted in this change). Bug: 534712288 Change-Id: Icf772b3d7d9c0a8a7266ada837d03ce41a97a67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8427445 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> | 5 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
pylint: add v3.2 support Change-Id: I120bd70adda6ea53e976ba47aa63d1dc622c6663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6150454 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> | 1 年前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
pylintrc: version all of them When running pylint tools in depot_tools itself, we default to the pylintrc file all the time even though we have versioned ones we want to use instead. This breaks things like ./pylint-2.17 foo.py. Rename the existing pylintrc to 2.6 and duplicate it to 2.7 so we clear out the 'pylintrc' file and the wrappers always default to the versioned ones. We've been riding on pylint being a bit compatible across versions, but it seems to be accelerating in adding/removing diagnostics and settings, so this is more churn to add new versions, but we don't have much choice. Change-Id: I5c20a41ed8aead3e90b6dda8f5f2fc3b87cfb251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6150453 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Auto-Submit: Mike Frysinger <vapier@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org> | 1 年前 | |
pylintrc: version all of them When running pylint tools in depot_tools itself, we default to the pylintrc file all the time even though we have versioned ones we want to use instead. This breaks things like ./pylint-2.17 foo.py. Rename the existing pylintrc to 2.6 and duplicate it to 2.7 so we clear out the 'pylintrc' file and the wrappers always default to the versioned ones. We've been riding on pylint being a bit compatible across versions, but it seems to be accelerating in adding/removing diagnostics and settings, so this is more churn to add new versions, but we don't have much choice. Change-Id: I5c20a41ed8aead3e90b6dda8f5f2fc3b87cfb251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6150453 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Auto-Submit: Mike Frysinger <vapier@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org> | 1 年前 | |
pylintrc: version all of them When running pylint tools in depot_tools itself, we default to the pylintrc file all the time even though we have versioned ones we want to use instead. This breaks things like ./pylint-2.17 foo.py. Rename the existing pylintrc to 2.6 and duplicate it to 2.7 so we clear out the 'pylintrc' file and the wrappers always default to the versioned ones. We've been riding on pylint being a bit compatible across versions, but it seems to be accelerating in adding/removing diagnostics and settings, so this is more churn to add new versions, but we don't have much choice. Change-Id: I5c20a41ed8aead3e90b6dda8f5f2fc3b87cfb251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6150453 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Auto-Submit: Mike Frysinger <vapier@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org> | 1 年前 | |
pylint: add v3.2 support Change-Id: I120bd70adda6ea53e976ba47aa63d1dc622c6663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6150454 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> | 1 年前 | |
Add coverage library to vpython3 so that we can have better insight in how we stand wrt our test coverage in depot_tools. Bug: b/459690822 Change-Id: I17d67e0530755fa9c07bbc4dabf6d81b6a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7244730 Auto-Submit: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 9 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
ruff_chromium: port .yapfignore & CLI flags; delete _RunYapf Make ruff_chromium 100% self-contained for all Python formatting workflows (batch mode, CLI, and stdin formatting) so that cl_format.py no longer needs legacy YAPF fallback logic: - Port .yapfignore pattern loading and filtering (get_yapfignore_patterns, is_yapf_ignored, filter_yapf_ignored_files) into ruff_chromium for both --batch mode and single-file CLI invocations. - Translate Ruff's --check flag to YAPF's -q (--quiet) flag in translate_args(), and avoid appending -i when --check is passed. - Pass resolved --style from get_yapf_style() to single-file CLI YAPF invocations in main() so directories using setup.cfg or default pep8 style are formatted identically to batch mode. - When stdin ('-') is passed for an unconfigured or .yapfignore-excluded file and neither --diff nor --check is requested, echo stdin to stdout unchanged so editor/VCS filter pipelines (e.g. jj fix) do not wipe the file buffer. - Support --force-python on the CLI and force_python in --batch JSON to preserve 'git cl format --python' behavior when no .style.yapf or ruff.toml is present. - Delete dead _RunYapf, _FindYapfConfigFile, _IsRuffBatchSupported, and duplicate .yapfignore helpers from cl_format.py and git_cl.py. Change-Id: I0f884cb9c8c0cb8f8588a1d98bc3fcf6176febc0 TAG=agy CONV=f80af470-12c5-46b4-b4f7-6e95973f19de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8421779 Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Marc Jin <jmarc@google.com> | 7 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Reland "UV: make the first conversion. Convert Ruff to UV." This reverts commit 88258c9ceb915fbc56b5b51e1c808514026e31a7. Reason for revert: reland again with vpython version update Original change's description: > Revert "UV: make the first conversion. Convert Ruff to UV." > > This reverts commit db395c47f653b18d647fd238e3fd0b1487da793b. > > Reason for revert: reported issue in the comment. > > Failure Link: <LINK TO FAILURE> > > Original change's description: > > UV: make the first conversion. Convert Ruff to UV. > > > > Additionally adjust ownership to give ownership of the lock file to the owner of the main file, in this case myself. > > > > Bug: b/491263752 > > Change-Id: Icef325612f39251d57c063d83562ed556a6a6964 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8179721 > > Reviewed-by: Richard Wang <richardwa@google.com> > > Commit-Queue: Alex Ovsienko <ovsienko@google.com> > > Bug: b/491263752 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I65ab58849897716ee3ca637c6fa42a9e865768e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8186536 > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Alex Ovsienko <ovsienko@google.com> Bug: b/491263752 Change-Id: I26017a8275f1d570275d8c283e81f6a5027bb40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8190014 Reviewed-by: Richard Wang <richardwa@google.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 1 个月前 | |
run_alint: Ignore submodule diffs in alint's internal git commands alint internally runs git commands (such as git diff and git show) on the repository to discover changed files and retrieve their full contents. When a commit touches a submodule (gitlink mode 160000), git diff includes the submodule path in the diff, and alint subsequently fails with: `` fatal: bad object HEAD:<submodule> Failed to build request proto: failed to get file diff: failed to parse git diff: failed to get full file content bytes: failed to get full file content with command git show HEAD:<submodule>: exit status 128 `` This causes AyeAye execution to fail completely during presubmit, preventing any actual analyzer findings (e.g. IfThisThenAnalyzer) from being reported. This CL sets diff.ignoreSubmodules=all via GIT_CONFIG_PARAMETERS in the environment passed to alint, mirroring how status.showUntrackedFiles=no is configured. This ensures submodule entries are ignored in diff generation and prevents alint from crashing on subproject commits. Bug: none Change-Id: I0173d2262b9d2e2996fc72ede1d5d6837385ee02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8406012 Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Victor Vianna <victorvianna@google.com> | 9 天前 | |
create run_in_virtual_path command Create run_in_virtual_path wrapper script and remove virtual build path support from siso.py. Changed to use DEPOT_TOOLS_USE_VIRTUAL_BUILD_PATH instead of SISO_USE_VIRTUAL_BUILD_PATH. Bug: b/528372534, b/527765051, b/529158482 Change-Id: I81646c27d4c247b65175d356129c0b470d402dd2 TAG=agy CONV=7636c0df-0efc-42f5-9e0f-65e282e96753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8095362 Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com> | 1 个月前 | |
create run_in_virtual_path command Create run_in_virtual_path wrapper script and remove virtual build path support from siso.py. Changed to use DEPOT_TOOLS_USE_VIRTUAL_BUILD_PATH instead of SISO_USE_VIRTUAL_BUILD_PATH. Bug: b/528372534, b/527765051, b/529158482 Change-Id: I81646c27d4c247b65175d356129c0b470d402dd2 TAG=agy CONV=7636c0df-0efc-42f5-9e0f-65e282e96753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8095362 Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Reland "Prevent argument injection in git commands and ref validation" This is a reland of commit 07a71782a10388962cdb12e939946fbec3a04866 Original change's description: > Prevent argument injection in git commands and ref validation > > Reject revisions, patch refs, and refspecs starting with '-' across > gclient and bot_update to prevent option injection into git. Also add > '--' and '--end-of-options' separators to git fetch, checkout, and > rev-parse invocations. > > Bug: 557923516 > Change-Id: I5fdbd39175527c2d2a4578f7aafd0a0c6b1312d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8394197 > Commit-Queue: Gavin Mak <gavinmak@google.com> > Reviewed-by: Brian Gan <brgan@google.com> Bug: 557923516 Change-Id: I24b0941d7d928d671035eb34cc484b62b73423e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8401307 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> | 7 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
create run_in_virtual_path command Create run_in_virtual_path wrapper script and remove virtual build path support from siso.py. Changed to use DEPOT_TOOLS_USE_VIRTUAL_BUILD_PATH instead of SISO_USE_VIRTUAL_BUILD_PATH. Bug: b/528372534, b/527765051, b/529158482 Change-Id: I81646c27d4c247b65175d356129c0b470d402dd2 TAG=agy CONV=7636c0df-0efc-42f5-9e0f-65e282e96753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8095362 Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Reland "gclient: Add Chrome Trace Event format support for Perfetto UI" This is a reland of commit c56fec68473515b44f1ddaea7a23fb66d88e4048 Diff from the original: In Python < 3.9, collections.abc.Iterator is not subscriptable and raises TypeError: 'ABCMeta' object is not subscriptable when evaluated as Iterator[None] at import time (e.g. when imported via gsutil.py). Import Iterator from typing instead to ensure compatibility with older Python environments. Original change's description: > gclient: Add Chrome Trace Event format support for Perfetto UI > > Add lightweight, zero-dependency tracing support to gclient to record > timelines of parallel git syncs, CIPD downloads, and individual hooks. > Traces can be viewed directly in https://ui.perfetto.dev. > > This is for investigating why gclient is slow. > > Examples: > > - https://drive.google.com/file/d/1BQfoNwi8hpOwMxgTnGG3LpVMqkidu63w/view?usp=drive_link > - https://drive.google.com/file/d/1xHc1ZGo-QiyPi9UDEQRiT2yMT4TbSBV6/view?usp=drive_link > > See also https://crrev.com/c/8256812. > > Bug: none > Change-Id: I5ebbcc86d6d940b1198d62afe911665c794b9b52 > Co-Authored-By: Gemini <noreply@google.com> > TAG=agy > CONV=a8dcce58-7d95-4a6e-822b-4816067f284f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8260569 > Reviewed-by: Gavin Mak <gavinmak@google.com> > Commit-Queue: Gavin Mak <gavinmak@google.com> > Auto-Submit: Ken Okada <kenoss@chromium.org> Bug: none Change-Id: I92dadf3a502b5aeecc01f80ff17259d4da14eb29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8356909 Commit-Queue: Ken Okada <kenoss@chromium.org> Reviewed-by: Alex Ovsienko <ovsienko@google.com> | 16 天前 | |
Revert "[depot_tools] Add top-level python3 wrappers with system python bypass" This reverts commit c55f47acb2cfd98f5b522541140d8844e4f0a2e6. Reason for revert: While there were no complaints yet, the lack of parity of CIPD Python and system python is concerning (mostly the fact that CIPD one lacks a lot of preinstalled libraries). We might want to rethink the approach here and devise some less invasive approach, especially as this revert does not affect the builders arm of the effort. Original change's description: > [depot_tools] Add top-level python3 wrappers with system python bypass > > Standardize depot_tools execution wrappers to use CIPD-provided > CPython directly instead of host system python3. > Supports DEPOT_TOOLS_PYTHON_BYPASS environment variable to allow falling > back to host system python3 if needed. > > Updates both POSIX shell script (python3) and Windows batch wrapper > (python3.bat) to directly resolve CIPD CPython via python3_bin_reldir.txt. > Also removes legacy root python3 deletion from update_depot_tools. > > Bug: 537680330 > TAG=agy > CONV=b1f27bd3-1fdc-47bd-a2a3-644f3858d1e5 > > Change-Id: Ie7f60be3c576654ef8e4b77ee81c0b5b6a6a6964 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8162440 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Alex Ovsienko <ovsienko@google.com> Bug: 537680330 Change-Id: I17884918d19719e95bf71eccf37d1bbefbb9dd04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8215807 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
watchlists: Cache compiled rules and skip on --bypass-watchlists. Benchmarks (Cloudtop Linux, 501 WATCHLISTS rules): - Warm-cache instantiation: 8.98 ms -> 0.24 ms (37.4x) - Multi-pass upload flow (3x load): 25.43 ms -> 10.13 ms (-60.2%) - Upload with --bypass-watchlists: 25.43 ms -> 0.00 ms (100% saved) Watchlists was previously re-evaluating AST and re-compiling all regular expressions on every Watchlists() instantiation. In Chromium, where WATCHLISTS defines 500+ rules, each instantiation costs ~9 ms. During a typical upload or stacked branch flow, Watchlists() is instantiated multiple times sequentially. Additionally, _PrepareChange() in git_cl.py unconditionally evaluated watchlists even when --bypass-watchlists was specified. This CL: 1. Adds _ParseAndCompileWatchlistRules() with @functools.lru_cache to reuse compiled regex dictionaries across instances in the same process. 2. Performs dictionary/list comprehension copying upon assignment to prevent accidental in-place mutations from leaking across instances. 3. Hardens rule parsing against malformed non-dict schemas and re.error regex compilation failures. 4. Guards Watchlists execution in git_cl.py (_PrepareChange and CMDUpload) behind getattr(options, "bypass_watchlists", False). 5. Adds unit tests for caching, mutation isolation, invalid regex handling, non-dict schemas, and the --bypass-watchlists flag. Test: vpython3 tests/watchlists_unittest.py Test: vpython3 tests/git_cl_test.py Bug: none Change-Id: I6b344dff6afcd871ca55656d8a57fdd69769dc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8261249 Reviewed-by: Alex Ovsienko <ovsienko@google.com> Commit-Queue: James Hawkins <jhawkins@chromium.org> | 1 个月前 | |
Change whitespace.txt Test implicit owners approval. Change-Id: I1f38e1b931b191909659298a7e6e39c42603c1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2897275 Reviewed-by: Yulan Lin <yulanlin@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> | 5 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 2 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 24 天前 |
depot_tools
Tools for Chromium development. Requires Python 3.8+.
gsutil: Python 3.9–3.13 required.
Tools
The most important tools are:
fetch: Agclientwrapper to checkout a project. Usefetch --helpfor more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient helpfor more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Usegit cl helpfor more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Also, includes shell script/batch file for tools required to build chromium, e.g.
gn: a meta-build system that generates build files for Ninjaautoninja: a wrapper forsisoandninja.siso: a build tool that aims to significantly speed up Chromium's build.ninja: a small build system with a focus on speed. deprecated by Siso.
These shell script/batch file runs python script with python-bin/python3
that find binaries in chromium checkout, and run with proper setup/check.
To use these wrappers, you need to initialize/bootstrap depot_tools (using
gclient, update_depot_tools or ensure_bootstrap).
AI agent tooling
This repository contains two separate directories of agent-related tooling with distinct audiences:
agents/: Skills and configuration meant for Chromium developers (and their AI agents) working in the Chromium codebase using depot_tools.depot_tools_agents/: AI review agents (e.g. Gerrit review agents) meant only for maintainers of depot_tools working on thedepot_toolscode itself. This is not intended for use with the Chromium codebase.
Installing
See set-up documentation.
depot_tools is also available in
-
chromium's third_party/depot_tools: propagated by autoroller.
-
on builder: infra_internal/recipe_bundles/chrome-internal.googlesource.com/chrome/tools/build bundles depot_tools. propagated by build_internal recipe roller
These depot_tools would not be initialized/bootstrapped (i.e. no
python-bin/python3 binary available), so the build tool wrapper won't work,
unless it is explicitly initialized by ensure_bootstrap.
Or, directly call the python script instead of using the shell script/batch
file.
Updating
depot_tools updates itself automatically when running gclient tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or
run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
Running gclient will install python3 binary.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py in depot_tools, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.
项目介绍
用户可借助此项目进行 Chromium 开发,包含 fetch、gclient 等核心工具,支持代码检出、依赖管理和代码审查,还集成 gn、ninja 等构建工具及 AI 代理相关工具。【此简介由AI生成】
定制我的领域