用户可借助此项目进行 Chromium 开发,包含 fetch、gclient 等核心工具,支持代码检出、依赖管理和代码审查,还集成 gn、ninja 等构建工具及 AI 代理相关工具。【此简介由AI生成】
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Disable pytest for vscode integration. vscode gets confused about which test provider to use. As such, disable pytests as most of our tests are in unittest. Change-Id: I42c0b54b2d2b8d081137dbd23a171ff56a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7273065 Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> | 8 个月前 | |
Update skill-validator owner email Update the skill-validator OWNERS file from ziwlin@microsoft.com to ziwenlin@chromium.org following the Chromium account migration. Use the persistent Chromium account for ongoing ownership and maintenance. Change-Id: I95fa5487b3550cd459062608cff55f5b03a60e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8294178 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> | 7 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
agents: Add CRAG-generated review agents and skills Sets up two AI review agents that run automatically on new changes. Bug: 539551931 Change-Id: I0fa9837152356b74b0034fc18517634bfa31f1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8159939 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Brian Gan <brgan@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8671794987747414657 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/60562389e63b852caa6303ab42ba3c160cb01a35 6056238 (dlf@google.com) [cipd] Add resolve method to recipe module Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I7d8fa18797755ff82956cd7e7a8cbfc37f1711b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8342250 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> | 16 小时前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8671794987747414657 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/60562389e63b852caa6303ab42ba3c160cb01a35 6056238 (dlf@google.com) [cipd] Add resolve method to recipe module Please check the following references for more information: - autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller - rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback - cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I7d8fa18797755ff82956cd7e7a8cbfc37f1711b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8342250 Commit-Queue: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> | 16 小时前 | |
Revert "presubmit: Scope CheckAyeAye (alint) to upstream branch." This reverts commit 10ecc97a648755dcb12c3e9d82ff4031f850b279. Reason for revert: Issues causing false positives. Original change's description: > presubmit: Scope CheckAyeAye (alint) to upstream branch. > > Benchmarks (chromium/src Presubmit Evaluation): > - Unscoped alint: ~5.50s > - Scoped alint (--commit <upstream>): ~3.03s (~2.47s / 1.8x faster) > > Historically, CheckAyeAye invoked alint without specifying an > upstream branch or target revision. This caused alint to execute an > unconstrained working tree diff scan across the entire repository, > taking ~5.5s on chromium/src and crashing on git submodules. > > This CL: > 1. Early-exits in CheckAyeAye when no files are affected in the > changeset (if not input_api.AffectedFiles():). Deletion-only > changesets are intentionally retained so analyzers checking > deletions (such as IfThisThenAnalyzer) continue to execute. > 2. Forwards the upstream branch (--commit <upstream>) when valid > to scope alint analysis to the changelist delta. > 3. Adds unit test coverage in tests/presubmit_canned_checks_test.py > for CheckAyeAye and run_alint.py. > 4. Updates MockInputApi.AffectedFiles to return a list matching > production InputApi.AffectedFiles. > > Bug: none > Test: vpython3 tests/presubmit_canned_checks_test.py > Test: vpython3 tests/presubmit_unittest.py > Test: vpython3 tests/git_cl_test.py > Change-Id: I43f66329908348e00f036238ae62857873353b9b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8281497 > Commit-Queue: James Hawkins <jhawkins@chromium.org> > Reviewed-by: Brian Gan <brgan@google.com> Bug: none Change-Id: I8253ca0fd50407d0134bfb43f52d3d128eaaf7f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8326107 Auto-Submit: James Hawkins <jhawkins@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Brian Gan <brgan@google.com> | 2 天前 | |
git_map_branches: Eliminate per-branch git log in --show-subject Previously, passing --show-subject to git map-branches spawned a separate git log -n1 --format=%s <branch> -- process for every branch in the repository (N + R processes). This change: 1. Includes %(subject) in the for-each-ref call inside get_branches_info(), adding subject to BranchesInfo. 2. Reads branch_info.subject directly in __append_branch(), eliminating the per-branch git log subprocesses. 3. Guards __is_dormant_branch() so config checks are skipped when dormant status is neither hidden nor displayed. 4. Updates unit test expectations in git_common_test.py. Change-Id: Idb97fcb539e5b36f974916bfb6cd3623b4c9f7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8338048 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Patrick Monette <pmonette@chromium.org> | 4 小时前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Remove unmaintained "gclient export" command, introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=20990 It was intended for the tarball generation script, but there was a better and simpler way. BUG=80549 Review URL: http://codereview.chromium.org/6883263 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83708 0039d316-1c4b-4281-b951-d872f2087c98 | 15 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Add a config file for the flake8 linter. Part of my bigger auto{ninja,siso} refactoring. R=brucedawson@chromium.org, jwata@google.com, tikuta@chromium.org Bug: b/293657720 Change-Id: I2a7783b8675ecc7dac16a490a290b2edf4b9d64d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4924716 Reviewed-by: Joanna Wang <jojwang@chromium.org> Commit-Queue: Joanna Wang <jojwang@chromium.org> Auto-Submit: Philipp Wollermann <philwo@chromium.org> | 2 年前 | |
Ruff lint: add relinting change to blame ignore. Bug: 539486220 Change-Id: Ib1c98d05ceaefb2849ab9e831fef61b36a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8254898 Commit-Queue: Junji Watanabe <jwata@google.com> Auto-Submit: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Junji Watanabe <jwata@google.com> | 20 天前 | |
vpython: make depot_tools bundle in all partner vpython scripts, all toml configs for UV and uv lock files. Additionally take in the ruff formatter. Bug: b/491263752 Change-Id: Idd8d0cf287def67bfdbdd8a1b4bb04396a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8217007 Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Victor Vianna <victorvianna@google.com> | 27 天前 | |
Revert "[depot_tools] Add top-level python3 wrappers with system python bypass" This reverts commit c55f47acb2cfd98f5b522541140d8844e4f0a2e6. Reason for revert: While there were no complaints yet, the lack of parity of CIPD Python and system python is concerning (mostly the fact that CIPD one lacks a lot of preinstalled libraries). We might want to rethink the approach here and devise some less invasive approach, especially as this revert does not affect the builders arm of the effort. Original change's description: > [depot_tools] Add top-level python3 wrappers with system python bypass > > Standardize depot_tools execution wrappers to use CIPD-provided > CPython directly instead of host system python3. > Supports DEPOT_TOOLS_PYTHON_BYPASS environment variable to allow falling > back to host system python3 if needed. > > Updates both POSIX shell script (python3) and Windows batch wrapper > (python3.bat) to directly resolve CIPD CPython via python3_bin_reldir.txt. > Also removes legacy root python3 deletion from update_depot_tools. > > Bug: 537680330 > TAG=agy > CONV=b1f27bd3-1fdc-47bd-a2a3-644f3858d1e5 > > Change-Id: Ie7f60be3c576654ef8e4b77ee81c0b5b6a6a6964 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8162440 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Alex Ovsienko <ovsienko@google.com> Bug: 537680330 Change-Id: I17884918d19719e95bf71eccf37d1bbefbb9dd04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8215807 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 27 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Include BUILD_OWNERS from the source of truth. Change-Id: I3b02c2e75fb831c00406b0587e1c956e6a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7480042 Auto-Submit: Matt Stark <msta@google.com> Commit-Queue: Matt Stark <msta@google.com> Reviewed-by: Philipp Wollermann <philwo@google.com> Reviewed-by: Fumitoshi Ukai <ukai@google.com> | 7 个月前 | |
CROS_OWNERS: switch to our common shared lists Change-Id: I7c05247729f4b569c9d6a95813d8849972c9b985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3849003 Reviewed-by: Cindy Lin <xcl@google.com> Commit-Queue: Cindy Lin <xcl@google.com> Auto-Submit: Mike Frysinger <vapier@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> | 3 年前 | |
[DIR_METADATA] Migrate from Monorail to Buganizer. Bug: none Change-Id: I6889f64ee04675b3da2c7f4c576d407cdb03d4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6935512 Reviewed-by: Brian Ryner <bryner@google.com> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Brian Ryner <bryner@google.com> | 11 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update LUCI_OWNERS to remove inactive members They either left Google or no longer works on LUCI Change-Id: I413ac847ceeaf2fd365e6f1c5ce0b68441cd676a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8178226 Commit-Queue: Yiwei Zhang <yiwzhang@google.com> Reviewed-by: Chan Li <chanli@chromium.org> Auto-Submit: Yiwei Zhang <yiwzhang@google.com> | 1 个月前 | |
Reland "UV: make the first conversion. Convert Ruff to UV." This reverts commit 88258c9ceb915fbc56b5b51e1c808514026e31a7. Reason for revert: reland again with vpython version update Original change's description: > Revert "UV: make the first conversion. Convert Ruff to UV." > > This reverts commit db395c47f653b18d647fd238e3fd0b1487da793b. > > Reason for revert: reported issue in the comment. > > Failure Link: <LINK TO FAILURE> > > Original change's description: > > UV: make the first conversion. Convert Ruff to UV. > > > > Additionally adjust ownership to give ownership of the lock file to the owner of the main file, in this case myself. > > > > Bug: b/491263752 > > Change-Id: Icef325612f39251d57c063d83562ed556a6a6964 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8179721 > > Reviewed-by: Richard Wang <richardwa@google.com> > > Commit-Queue: Alex Ovsienko <ovsienko@google.com> > > Bug: b/491263752 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I65ab58849897716ee3ca637c6fa42a9e865768e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8186536 > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Alex Ovsienko <ovsienko@google.com> Bug: b/491263752 Change-Id: I26017a8275f1d570275d8c283e81f6a5027bb40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8190014 Reviewed-by: Richard Wang <richardwa@google.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 29 天前 | |
presubmit: activate CheckVPythonSpec for depot_tools Activate CheckVPythonSpec in depot_tools/PRESUBMIT.py to verify that changed vpython specification files (vpython.toml / PEP 723) match their companion uv.lock lockfiles. Also remove the obsolete -vpython-spec verify_spec invocation from presubmit_canned_checks.py since verify_lockfile.py now uses inline PEP 723 script metadata and runs directly with vpython3. Bug: b/491263752 TAG=agy CONV=b515f9ed-e0b3-471d-a9bf-26ccd1e4013c Change-Id: Ifdd4a79befd9952cffa6975d9e380b136a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8332727 Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Junji Watanabe <jwata@google.com> | 1 天前 | |
docs: Removing references to SVN BUG=643697 TEST=None Review-Url: https://codereview.chromium.org/2350293002 | 9 年前 | |
git cl format: Format .html.ts files for opted in directories Allow directories to opt-in to .html.ts file formatting using the WebUI Lit template formatter using the same file mechanism used to opt-in to other file formatting like markdown files. Add tests that the Lit template formatter is invoked when a marker file is present and that the correct flags are passed through from git cl format (--diff, --dry-run). Bug: 512911634 Change-Id: Ie3c4e8a8f0219318e9ae3a1650d6f67d982d9467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8066346 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> | 1 个月前 | |
Document the current state of LUCI GCS integration Change-Id: I39c01200208de15e5ce2101ecc273f823875bc0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6326717 Auto-Submit: Dan Le Febvre <dlf@google.com> Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Scott Lee <ddoman@chromium.org> | 1 年前 | |
agents: Add CRAG-generated review agents and skills Sets up two AI review agents that run automatically on new changes. Bug: 539551931 Change-Id: I0fa9837152356b74b0034fc18517634bfa31f1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8159939 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Brian Gan <brgan@google.com> | 1 个月前 | |
Add convenience wrapper for reclientreport for autoninja users This is designed to be called by a developer when they want to submit an reclient bug report. Developers could just call the //buildtools/reclient/reclientreport binary directly but this wrapper provides an easier way to set the same log flags that are set by ninja_reclient. I dont think we should bundle this logic into autoninja as this is not required in 99% of builds. Bug: b/277763387 Change-Id: I0204b6acc22f199b461ef710d0dfd07e05534af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4414921 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Ben Segall <bentekkie@google.com> | 3 年前 | |
add crowbar CLI to depot_tools Adds an entrypoint to invoke Crowbar CLI in depot_tools. Crowbar CLI is a tool to manage, update, and vendor third-party source code dependencies into Chromium projects. Contributors will write a workflow to define fetch, unpack, and patch steps, then call the CLI in their checkout. The CLI is implemented in: https://source.chromium.org/chromium/infra/infra_superproject/+/main:infra/go/src/infra/tools/crowbar/ Bug: 464370533 Change-Id: Ibf253b8dbec37e2257dc5a1050f87ac40d16629b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7924447 Reviewed-by: Gavin Mak <gavinmak@google.com> Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> | 2 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
git-cl: Lazy-import formatters and heavy dependencies on startup. Top-level module imports in git_cl.py accounted for ~540 ms of startup latency on every invocation of git-cl (including lightweight commands like status, diff, and issue). This CL introduces three optimizations: 1. Move legacy tag matching regex (TAG_LINE_RE) to git_footers.py, eliminating the top-level presubmit_support import (~325 ms savings). 2. Defer importing httplib2 in auth.py to Authenticator.authorize(), reducing auth.py import time from ~172 ms to ~1.1 ms. 3. Defer subcommand-specific formatters and linters (clang_format, google_java_format, ktfmt, rustfmt, swift_format, metrics_xml_format, presubmit_canned_checks, split_cl, git_new_branch, git_squash_branch, owners_finder) to their respective functions (~40 ms savings). Total startup latency drops from ~540 ms to ~145 ms (73% speedup). Test: vpython3 tests/git_cl_test.py Test: vpython3 tests/presubmit_support_test.py Test: vpython3 tests/auth_test.py Test: vpython3 tests/git_footers_test.py Change-Id: I916bc6b8ce179e04ea9b476a31915a66f9b50f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8266647 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Alex Ovsienko <ovsienko@google.com> | 13 天前 | |
autoninja: check DEPOT_TOOLS_USE_VIRTUAL_BUILD_PATH Bug: 549548891 Change-Id: I4f2a71179d4693f5c32eafd81a9c15da836c09b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8255433 Commit-Queue: Fumitoshi Ukai <ukai@google.com> Commit-Queue: Junji Watanabe <jwata@google.com> Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Junji Watanabe <jwata@google.com> Reviewed-by: Neri Marschik <nerima@google.com> | 12 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Use relative path for cipd Using $base_dir/cipd as a path for the cipd command only works when $base_dir is an absolute path, not when it is a relative path, as the current directory is already $base_dir. Therefore, "./cipd" must be used to run a command located in $base_dir. Change-Id: Ia882a7fb404b7ff837944f80c0ace3f4e90e6a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4479169 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Commit-Queue: Yngve Pettersen <yngve@vivaldi.com> | 3 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
autoninja: Implement build_telemetry utils This will replace the user consent logics in ninjalog_uploader_wrapper.py and reclient_metrics.py See also https://crrev.com/c/5669094 for how this will be used. Bug: 345113094 Change-Id: Iffc4975c152ba63f7577c09e5254c499fe8973c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5671052 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Reviewed-by: Fumitoshi Ukai <ukai@google.com> Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org> | 2 年前 | |
autoninja: Implement build_telemetry utils This will replace the user consent logics in ninjalog_uploader_wrapper.py and reclient_metrics.py See also https://crrev.com/c/5669094 for how this will be used. Bug: 345113094 Change-Id: Iffc4975c152ba63f7577c09e5254c499fe8973c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5671052 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Reviewed-by: Fumitoshi Ukai <ukai@google.com> Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org> | 2 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Roll cipd to v2.9.2 Bug: 549356447 Change-Id: I532c2e2dfe69c7f9510b8834c6d94b81a20e9168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8332367 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Dan Le Febvre <dlf@google.com> | 1 天前 | |
Roll cipd to v2.9.2 Bug: 549356447 Change-Id: I532c2e2dfe69c7f9510b8834c6d94b81a20e9168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8332367 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Dan Le Febvre <dlf@google.com> | 1 天前 | |
VPython: roll vpython to the version containing https://crrev.com/c/8342107 Bug: b/491263752 Change-Id: I797d13a8ddcb52e075f9c2f572d4fdb46a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8343727 Commit-Queue: Junji Watanabe <jwata@google.com> Auto-Submit: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Junji Watanabe <jwata@google.com> | 19 小时前 | |
VPython: roll vpython to the version containing https://crrev.com/c/8342107 Bug: b/491263752 Change-Id: I797d13a8ddcb52e075f9c2f572d4fdb46a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8343727 Commit-Queue: Junji Watanabe <jwata@google.com> Auto-Submit: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Junji Watanabe <jwata@google.com> | 19 小时前 | |
remove goma CIPD package goma is not used by developers now. Bug: b/304421889 Change-Id: I68ffd73336f2303484dd44bce6c3984b06faa681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5395370 Reviewed-by: Junji Watanabe <jwata@google.com> Reviewed-by: Joanna Wang <jojwang@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Fumitoshi Ukai <ukai@google.com> | 2 年前 | |
Redirect cros calls to py2.7 scripts to the vpython2.7 package. Bug: 1245665 Change-Id: I1b75e2a515e6c8b1b7b0192946a2cfd5295a21f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4015440 Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Brian Ryner <bryner@google.com> | 3 年前 | |
presubmit: Run CheckPatchFormatted asynchronously via ThreadPool. Benchmarks (Presubmit Hook Evaluation): - Synchronous CheckPatchFormatted: ~1339 ms - Asynchronous CheckPatchFormatted: ~891 ms (~448 ms / 1.50x faster) Historically, CheckPatchFormatted in presubmit_canned_checks.py executed synchronously on the main thread during script evaluation, blocking the main thread for ~400ms before subprocess tests in thread_pool.RunAsync() (such as Ruff, AyeAye, or unit tests) began. Furthermore, it wrote change diffs to disk temp files. This CL: 1. Updates git_cl.py to support reading diffs from stdin when --input_diff_file - is specified. 2. Updates CheckPatchFormatted to dispatch git cl format as an asynchronous input_api.Command passing diff content via stdin. 3. Updates ThreadPool.CallCommand to support returncode-aware output_parser(returncode, stdout) callbacks. 4. Updates test mocks and test suites in tests/presubmit_unittest.py and tests/presubmit_canned_checks_test.py. Bug: none Test: vpython3 tests/presubmit_canned_checks_test.py Test: vpython3 tests/presubmit_unittest.py Test: vpython3 tests/git_cl_test.py Change-Id: Ia1cfe6850dc470b1d00917e11ad925cdabf99b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8280571 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Brian Gan <brgan@google.com> | 7 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
update stale codereview.chromium.org links w/chromium-review.googlesource.com Change-Id: I8f024d68a3b89ae530fc1ce2806b9b12b83ba7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2585050 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: James Zern <jzern@google.com> | 5 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
simplify the chromite wrappers The support/ dir has only ever been used to host a single CrOS file. We can move that to cros (which is the primary tool in the CrOS world), and have the few other wrapped programs point to that. Bug: None Change-Id: I3ba3cc7375d357d62fb464e1b6dc37e73bc83cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1876639 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> | 6 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Pad bat scripts so pre-fix checkouts update cleanly 84b69fc5b stopped gclient.bat, fetch.bat and gsutil.py.bat from resuming at a stale byte offset after update_depot_tools.bat rewrites them, by chaining the update call with a GOTO that rewinds cmd.exe's file pointer. That only helps checkouts that already have the fix. Checkouts that have not updated since 2026-08-05 still run the old scripts, which call update_depot_tools.bat on a line of its own, so they still resume mid-line in the newly checked out file. For gclient.bat the stale offset is byte 365, which in the current file is the middle of ":: Abort the script if we failed to update depot_tools.", so cmd.exe executes "date depot_tools." and blocks prompting for a new system date. Pad scripts with harmless colon labels across historical resume offsets (since 2013) so stale checkouts update cleanly. Removable once checkouts older than 2026-08-05 are gone. Bug: 542670559 Change-Id: I28c35fb2b4c6341494e9551880dd99ad1436a095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8284188 Auto-Submit: Gavin Mak <gavinmak@google.com> Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> | 8 天前 | |
gclient: add bootstrap cache mode detaching checkouts from the mirror fetch --git-cache leaves the checkout in the bot-oriented cache topology: origin's fetch URL is the local mirror path and objects are borrowed via .git/objects/info/alternates. For a developer that means plain git fetch/pull reads the stale local cache instead of the network, and deleting the cache directory corrupts every checkout cloned from it. Add cache_mode = "bootstrap" to .gclient (default "shared" keeps today's behavior for bots): the mirror only seeds checkouts that do not exist yet. The clone drops --shared (objects are hardlinked or copied) and the fetch URL is set to the real remote right after the clone, so the checkout is configured like one made without a cache and the cache can be deleted at any time. fetch --git-cache selects this mode. Change-Id: I176544693d66d727e062bf2b9c4c81b62647b910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8037665 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Neri Marschik <nerima@google.com> Reviewed-by: Philipp Wollermann <philwo@google.com> | 13 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
gclient-new-workdir: Refresh index stat cache after CoW copy When copying a workdir using copy-on-write on APFS or reflink-enabled filesystems, file inodes and ctimes change while modification times and file sizes are preserved. Because .git/index is copied directly from the source repository, its cached stat metadata contains the old inodes, causing the first git status in the new worktree to treat all files as stat-dirty and re-hash their contents on disk. This change runs update-index with core.checkStat=minimal immediately after copying the index. Under core.checkStat=minimal, Git matches files using mtime and size without hashing, refreshing the cached inodes in .git/index instantly. Bug: None Change-Id: I27c72330ece223de0e17518cba3c90d1c531cb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8126720 Reviewed-by: Gavin Mak <gavinmak@google.com> Auto-Submit: Justin Cohen <justincohen@google.com> Commit-Queue: Justin Cohen <justincohen@google.com> | 30 天前 | |
Pad bat scripts so pre-fix checkouts update cleanly 84b69fc5b stopped gclient.bat, fetch.bat and gsutil.py.bat from resuming at a stale byte offset after update_depot_tools.bat rewrites them, by chaining the update call with a GOTO that rewinds cmd.exe's file pointer. That only helps checkouts that already have the fix. Checkouts that have not updated since 2026-08-05 still run the old scripts, which call update_depot_tools.bat on a line of its own, so they still resume mid-line in the newly checked out file. For gclient.bat the stale offset is byte 365, which in the current file is the middle of ":: Abort the script if we failed to update depot_tools.", so cmd.exe executes "date depot_tools." and blocks prompting for a new system date. Pad scripts with harmless colon labels across historical resume offsets (since 2013) so stale checkouts update cleanly. Removable once checkouts older than 2026-08-05 are gone. Bug: 542670559 Change-Id: I28c35fb2b4c6341494e9551880dd99ad1436a095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8284188 Auto-Submit: Gavin Mak <gavinmak@google.com> Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> | 8 天前 | |
gclient: add bootstrap cache mode detaching checkouts from the mirror fetch --git-cache leaves the checkout in the bot-oriented cache topology: origin's fetch URL is the local mirror path and objects are borrowed via .git/objects/info/alternates. For a developer that means plain git fetch/pull reads the stale local cache instead of the network, and deleting the cache directory corrupts every checkout cloned from it. Add cache_mode = "bootstrap" to .gclient (default "shared" keeps today's behavior for bots): the mirror only seeds checkouts that do not exist yet. The clone drops --shared (objects are hardlinked or copied) and the fetch URL is set to the real remote right after the clone, so the checkout is configured like one made without a cache and the cache can be deleted at any time. fetch --git-cache selects this mode. Change-Id: I176544693d66d727e062bf2b9c4c81b62647b910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8037665 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Neri Marschik <nerima@google.com> Reviewed-by: Philipp Wollermann <philwo@google.com> | 13 天前 | |
Added basic completion (the commands) for gclient. To try it out, do . $DEPOT_TOOLS/gclient_completion.sh Review URL: https://codereview.chromium.org/100463007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@245134 0039d316-1c4b-4281-b951-d872f2087c98 | 12 年前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
gclient: add bootstrap cache mode detaching checkouts from the mirror fetch --git-cache leaves the checkout in the bot-oriented cache topology: origin's fetch URL is the local mirror path and objects are borrowed via .git/objects/info/alternates. For a developer that means plain git fetch/pull reads the stale local cache instead of the network, and deleting the cache directory corrupts every checkout cloned from it. Add cache_mode = "bootstrap" to .gclient (default "shared" keeps today's behavior for bots): the mirror only seeds checkouts that do not exist yet. The clone drops --shared (objects are hardlinked or copied) and the fetch URL is set to the real remote right after the clone, so the checkout is configured like one made without a cache and the cache can be deleted at any time. fetch --git-cache selects this mode. Change-Id: I176544693d66d727e062bf2b9c4c81b62647b910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8037665 Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Neri Marschik <nerima@google.com> Reviewed-by: Philipp Wollermann <philwo@google.com> | 13 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Symlink gerrit CLI into depot_tools The "gerrit" tool works just fine outside the SDK. Let's start teaching people to use it outside the SDK by putting it in their PATH. Bug: b:275597798 Change-Id: I79c8090d4e5e205bcac2b763751537791caafe91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4377791 Auto-Submit: Jack Rosenthal <jrosenth@chromium.org> Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> | 3 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
gerrit_util: Add temp message for error Bug: 541179825 Change-Id: I2ef4b1c128c2e33abb713c70f6fe3fd4d1991cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8342228 Auto-Submit: Allen Li <ayatane@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> | 22 小时前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Revert "Remove unused functionality in bot_update.py" This reverts commit 8b64ddec2a54503ca802a545cd19ca368ab27448. Reason for revert: it appears we need this, since .DEPS.git specifies custom dependencies needed for tryjob. Original change's description: > Remove unused functionality in bot_update.py > > .DEPS.git has been removed in 2014 and no longer supported. It was > deleted in https://codereview.chromium.org/497313003 (August 2014). Last > entry in chromium/src is from tag 44.0.2403.47 in June 2015. > > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited > Recipe-Nontrivial-Roll: chrome_release > Recipe-Nontrivial-Roll: chromiumos > Recipe-Nontrivial-Roll: infra > Change-Id: I3ffb8813af867df959098c02d399c8d745894aae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3439573 > Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> Change-Id: I36bcd352a984b4b762096197a384e86347418290 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3448707 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> | 4 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
git_auth: Add a divider for readability There's some slightly spammy output above this, so make it friendly to read the closing instructions. Change-Id: I2b23bf0686f37cc0f5704fd38ffef34e600c7636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8198527 Commit-Queue: Allen Li <ayatane@chromium.org> Auto-Submit: Allen Li <ayatane@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> | 27 天前 | |
git_cache: Pin ref format to files when initializing bare repos When host Git defaults to reftables, git init --bare creates .git/refs/heads as a placeholder text file. When git_cache bootstraps from GCS, it extracts a snapshot that uses the standard files backend. Because GCS does not overwrite .git/refs/heads, the leftover placeholder file causes subsequent git fetch calls to fail with: fatal: bad object refs/heads. Also, re-initializing existing bare cache mirrors on such systems causes git init --bare to fail with: fatal: could not open '.../refs/heads' for writing: Is a directory. Fix this by explicitly passing --ref-format=files to git init invocations in bootstrap_repo and _ensure_bootstrapped when Git >= 2.45.0 is detected. Bug: 532590208 Change-Id: I24e653eaaaff6c8f1ddcd5547615e06e70b4d48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8285363 Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by: Brian Gan <brgan@google.com> | 8 天前 | |
git_cl: generalize bug and fix extraction from branch names Allow branch names with bug/fix patterns like b/XXXX, b-XXXX, bXXXX, bugXXXX, bug:XXXX, fixXXXX, fixes/XXXX at the start of branch or delineated by separators (-, _, /, :) to automatically populate the Bug: or Fixed: trailer in CL description. R=ovsienko@google.com Bug: None Change-Id: If0a0db824964d7712d336bb26111bcf1fcf42550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8290990 Reviewed-by: Alex Ovsienko <ovsienko@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Commit-Queue: Jenna Himawan <jhimawan@google.com> | 2 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
git_cl: Extract Settings and git execution primitives to git_cl_core. This refactoring extracts Settings, settings, and repository configuration helpers (FindCodereviewSettingsFile, LoadCodereviewSettingsFromFile) along with low-level git and subprocess execution primitives (DieWithError, RunCommand, RunGit, RunGitDiffCmd, RunGitSilent, RunGitWithCode, _SplitArgsByCmdLineLimit) out of the git_cl.py monolith into a standalone base git_cl_core.py module. Extracting these core configuration and execution primitives establishes a clean foundational layer for modularizing git_cl subcommands (such as cl_format.py), eliminating circular module initialization dependencies across depot_tools. All extracted symbols are re-exported in git_cl.py for full backward compatibility with external callers. Bug: none Test: vpython3 tests/git_cl_core_test.py Test: vpython3 tests/git_cl_test.py Change-Id: I590105ca86977c267191bc7698c901d95922c7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8280780 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Brian Gan <brgan@google.com> | 8 天前 | |
git_map_branches: Eliminate per-branch git log in --show-subject Previously, passing --show-subject to git map-branches spawned a separate git log -n1 --format=%s <branch> -- process for every branch in the repository (N + R processes). This change: 1. Includes %(subject) in the for-each-ref call inside get_branches_info(), adding subject to BranchesInfo. 2. Reads branch_info.subject directly in __append_branch(), eliminating the per-branch git log subprocesses. 3. Guards __is_dormant_branch() so config checks are skipped when dormant status is neither hidden nor displayed. 4. Updates unit test expectations in git_common_test.py. Change-Id: Idb97fcb539e5b36f974916bfb6cd3623b4c9f7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8338048 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Patrick Monette <pmonette@chromium.org> | 4 小时前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
git-cl: Lazy-import formatters and heavy dependencies on startup. Top-level module imports in git_cl.py accounted for ~540 ms of startup latency on every invocation of git-cl (including lightweight commands like status, diff, and issue). This CL introduces three optimizations: 1. Move legacy tag matching regex (TAG_LINE_RE) to git_footers.py, eliminating the top-level presubmit_support import (~325 ms savings). 2. Defer importing httplib2 in auth.py to Authenticator.authorize(), reducing auth.py import time from ~172 ms to ~1.1 ms. 3. Defer subcommand-specific formatters and linters (clang_format, google_java_format, ktfmt, rustfmt, swift_format, metrics_xml_format, presubmit_canned_checks, split_cl, git_new_branch, git_squash_branch, owners_finder) to their respective functions (~40 ms savings). Total startup latency drops from ~540 ms to ~145 ms (73% speedup). Test: vpython3 tests/git_cl_test.py Test: vpython3 tests/presubmit_support_test.py Test: vpython3 tests/auth_test.py Test: vpython3 tests/git_footers_test.py Change-Id: I916bc6b8ce179e04ea9b476a31915a66f9b50f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8266647 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Alex Ovsienko <ovsienko@google.com> | 13 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
git_map_branches: Eliminate per-branch git log in --show-subject Previously, passing --show-subject to git map-branches spawned a separate git log -n1 --format=%s <branch> -- process for every branch in the repository (N + R processes). This change: 1. Includes %(subject) in the for-each-ref call inside get_branches_info(), adding subject to BranchesInfo. 2. Reads branch_info.subject directly in __append_branch(), eliminating the per-branch git log subprocesses. 3. Guards __is_dormant_branch() so config checks are skipped when dormant status is neither hidden nor displayed. 4. Updates unit test expectations in git_common_test.py. Change-Id: Idb97fcb539e5b36f974916bfb6cd3623b4c9f7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8338048 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Patrick Monette <pmonette@chromium.org> | 4 小时前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
git rebase-update: Optimize rebasing using git replay and for-each-ref - Attempt fast in-memory rebases using git replay directly in the Git object store to avoid checking out intermediate branches into the working tree and thrashing disk I/O. - Seamlessly fall back to standard git rebase if merge conflicts occur. - Optimize get_branch_tree() to fetch upstream refs in a single git for-each-ref plumbing call instead of $O(N)$ subprocesses. - Optimize fetch_remotes() by batching symbolic ref parsing and fetching all needed remotes in a single git fetch --multiple call. - Optimize remove_empty_branches() by batching tree hash lookups via git.hash_multi and batching branch deletions via git branch -d. - Avoid redundant upstream lookups by passing orig_parent to git.get_or_create_merge_base(). - Restore starting branch and thaw uncommitted changes when --keep-going is active and the repository is not left in mid- rebase. - Add unit test coverage for replay_rebase in git_rebase_update_test. Change-Id: Id816673accc83ddd19cda18f67186bee6433afb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246775 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> | 9 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Pad bat scripts so pre-fix checkouts update cleanly 84b69fc5b stopped gclient.bat, fetch.bat and gsutil.py.bat from resuming at a stale byte offset after update_depot_tools.bat rewrites them, by chaining the update call with a GOTO that rewinds cmd.exe's file pointer. That only helps checkouts that already have the fix. Checkouts that have not updated since 2026-08-05 still run the old scripts, which call update_depot_tools.bat on a line of its own, so they still resume mid-line in the newly checked out file. For gclient.bat the stale offset is byte 365, which in the current file is the middle of ":: Abort the script if we failed to update depot_tools.", so cmd.exe executes "date depot_tools." and blocks prompting for a new system date. Pad scripts with harmless colon labels across historical resume offsets (since 2013) so stale checkouts update cleanly. Removable once checkouts older than 2026-08-05 are gone. Bug: 542670559 Change-Id: I28c35fb2b4c6341494e9551880dd99ad1436a095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8284188 Auto-Submit: Gavin Mak <gavinmak@google.com> Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> | 8 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Add support for ktfmt We plan on using ktfmt as our official Kotlin formatter. Bug: 539988177 Change-Id: I2258e8324f7c8d1c5b26ad8d9ed636472ef80fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8232441 Auto-Submit: Sam Maier <smaier@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Add LUCI CLI tool to depot_tools. This adds the unified LUCI CLI tool (infra/tools/luci/luci) to depot_tools CIPD manifest and adds wrapper shims. BUG=None TEST=None TAG=agy CONV=2062bf49-70f8-45ff-9da6-10f7dd9354b3 Change-Id: I28cdfa77bb4d834c90a03816f3adc09aa68d9a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8073818 Reviewed-by: Chenlin Fan <fancl@chromium.org> Auto-Submit: Matthew Warton <mwarton@google.com> Commit-Queue: Chenlin Fan <fancl@chromium.org> Reviewed-by: Allen Xie <zhihuixie@google.com> Commit-Queue: Allen Xie <zhihuixie@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Add luci-auth-fido2-plugin This plugin handles FIDO2 security keys for doing auth and integrates with luci-auth (specifically git-credential-luci). (It's in Python because tl;dr the Python library is much better.) Bug: 433851494 Change-Id: Ib956b614588aad8ad4fda7619bfbae17a670438f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6804585 Reviewed-by: Scott Lee <ddoman@chromium.org> Commit-Queue: Allen Li <ayatane@chromium.org> | 1 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Add LUCI CLI tool to depot_tools. This adds the unified LUCI CLI tool (infra/tools/luci/luci) to depot_tools CIPD manifest and adds wrapper shims. BUG=None TEST=None TAG=agy CONV=2062bf49-70f8-45ff-9da6-10f7dd9354b3 Change-Id: I28cdfa77bb4d834c90a03816f3adc09aa68d9a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8073818 Reviewed-by: Chenlin Fan <fancl@chromium.org> Auto-Submit: Matthew Warton <mwarton@google.com> Commit-Queue: Chenlin Fan <fancl@chromium.org> Reviewed-by: Allen Xie <zhihuixie@google.com> Commit-Queue: Allen Xie <zhihuixie@google.com> | 1 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
[metrics] Add new auth metric Bug: b/358442026 Change-Id: If91494b52fe27177f68e42ec40977fd8ca1fd4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5786166 Commit-Queue: Allen Li <ayatane@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> | 2 年前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
presubmit: Attribute AyeAye warnings and format tool execution failures Prefix AyeAye findings with [AyeAye] in run_alint.py so developers can easily identify the source analyzer for presubmit warnings. In addition, separate unhandled tool crashes/errors into a dedicated execution_error payload instead of mixing raw stderr into standard rule findings, and format tool crashes in CheckAyeAye as clear execution failures with exit code and output details. Fixed: 555809061 Change-Id: Id4a939d510d87bbded9cafce8f16fc750e6ec12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8339029 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Mike Wittman <wittman@chromium.org> | 4 小时前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
presubmit: Extract ThreadPool and result types to separate modules. This refactoring separates the presubmit execution engine and result data types out of presubmit_support.py into standalone modules: 1. presubmit_results.py: Contains _PresubmitResult, _PresubmitError, _PresubmitPromptWarning, _PresubmitNotifyResult, _MailTextResult, and _PresubmitResultLocation without external depot_tools dependencies. - Extracts module-level _ensure_str function. - Adds a newline separator before appending call stacks to non-empty long_text in _PresubmitResult. - Fixes _MailTextResult initialization by raising NotImplementedError directly rather than failing with TypeError on zero-arg base call. 2. presubmit_thread_pool.py: Contains ThreadPool, CommandData, SigintHandler, Timer, and time_time (-284 lines in presubmit_support.py), consuming presubmit_results.py directly to eliminate circular imports, and modernizes worker thread construction with daemon=True. 3. Tests: Adds dedicated unit tests in tests/presubmit_results_test.py and moves thread pool unit tests into tests/presubmit_thread_pool_test.py. All extracted symbols are re-exported in presubmit_support.py for full backward compatibility. Bug: none Test: vpython3 tests/presubmit_results_test.py Test: vpython3 tests/presubmit_thread_pool_test.py Test: vpython3 tests/presubmit_unittest.py Change-Id: Id2a5337631163a84ee8ed68c0e1ec6355ac53305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8283087 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: James Hawkins <jhawkins@chromium.org> | 8 天前 | |
presubmit: Eagerly execute parallel tests in ThreadPool workers. Benchmarks (Presubmit Execution): - depot_tools: ~0.380s -> 0.231s (~150ms saved / ~40% faster) - chromium/src: ~0.420s -> 0.229s (~190ms saved / ~45% faster) Historically, DoPresubmitChecks operated in a two-phase sequential model: PRESUBMIT.py scripts evaluated sequentially on the main thread, adding tests to thread_pool._tests, and worker threads only started executing tests when thread_pool.RunAsync() was called at the end. This left background checks waiting idle in a queue for hundreds of milliseconds while the main thread compiled and ran Python AST checks. This CL: 1. Implements an eager streaming ThreadPool worker pool using queue.Queue, starting worker threads immediately when tests are registered via AddTests(parallel=True). 2. Overlaps background subprocess startup and network I/O with ongoing PRESUBMIT.py evaluation on the main thread. 3. Enforces barrier synchronization (_DrainInFlightParallelTasks()) before executing parallel=False non-parallel tests. 4. Wraps presubmit execution in a ThreadPool context manager to guarantee clean cancellation, task draining, and worker joining on exceptions or SIGINT. 5. Normalizes test working directories (cwd) to absolute paths upon task registration, eliminating process CWD mutation races. 6. Defers temporary file deletion until ThreadPool teardown. 7. Adds dedicated unit test coverage in tests/presubmit_thread_pool_test.py and tests/presubmit_unittest.py. Bug: none Test: vpython3 tests/presubmit_thread_pool_test.py Test: vpython3 tests/presubmit_unittest.py Test: vpython3 tests/presubmit_canned_checks_test.py Change-Id: I15ba2e2a222b363b9b7d320a622e917a7089f876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8278341 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Brian Gan <brgan@google.com> | 8 天前 | |
presubmit: Run CheckPatchFormatted asynchronously via ThreadPool. Benchmarks (Presubmit Hook Evaluation): - Synchronous CheckPatchFormatted: ~1339 ms - Asynchronous CheckPatchFormatted: ~891 ms (~448 ms / 1.50x faster) Historically, CheckPatchFormatted in presubmit_canned_checks.py executed synchronously on the main thread during script evaluation, blocking the main thread for ~400ms before subprocess tests in thread_pool.RunAsync() (such as Ruff, AyeAye, or unit tests) began. Furthermore, it wrote change diffs to disk temp files. This CL: 1. Updates git_cl.py to support reading diffs from stdin when --input_diff_file - is specified. 2. Updates CheckPatchFormatted to dispatch git cl format as an asynchronous input_api.Command passing diff content via stdin. 3. Updates ThreadPool.CallCommand to support returncode-aware output_parser(returncode, stdout) callbacks. 4. Updates test mocks and test suites in tests/presubmit_unittest.py and tests/presubmit_canned_checks_test.py. Bug: none Test: vpython3 tests/presubmit_canned_checks_test.py Test: vpython3 tests/presubmit_unittest.py Test: vpython3 tests/git_cl_test.py Change-Id: Ia1cfe6850dc470b1d00917e11ad925cdabf99b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8280571 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Brian Gan <brgan@google.com> | 7 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
pylint: add v3.2 support Change-Id: I120bd70adda6ea53e976ba47aa63d1dc622c6663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6150454 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> | 1 年前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
pylintrc: version all of them When running pylint tools in depot_tools itself, we default to the pylintrc file all the time even though we have versioned ones we want to use instead. This breaks things like ./pylint-2.17 foo.py. Rename the existing pylintrc to 2.6 and duplicate it to 2.7 so we clear out the 'pylintrc' file and the wrappers always default to the versioned ones. We've been riding on pylint being a bit compatible across versions, but it seems to be accelerating in adding/removing diagnostics and settings, so this is more churn to add new versions, but we don't have much choice. Change-Id: I5c20a41ed8aead3e90b6dda8f5f2fc3b87cfb251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6150453 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Auto-Submit: Mike Frysinger <vapier@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org> | 1 年前 | |
pylintrc: version all of them When running pylint tools in depot_tools itself, we default to the pylintrc file all the time even though we have versioned ones we want to use instead. This breaks things like ./pylint-2.17 foo.py. Rename the existing pylintrc to 2.6 and duplicate it to 2.7 so we clear out the 'pylintrc' file and the wrappers always default to the versioned ones. We've been riding on pylint being a bit compatible across versions, but it seems to be accelerating in adding/removing diagnostics and settings, so this is more churn to add new versions, but we don't have much choice. Change-Id: I5c20a41ed8aead3e90b6dda8f5f2fc3b87cfb251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6150453 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Auto-Submit: Mike Frysinger <vapier@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org> | 1 年前 | |
pylintrc: version all of them When running pylint tools in depot_tools itself, we default to the pylintrc file all the time even though we have versioned ones we want to use instead. This breaks things like ./pylint-2.17 foo.py. Rename the existing pylintrc to 2.6 and duplicate it to 2.7 so we clear out the 'pylintrc' file and the wrappers always default to the versioned ones. We've been riding on pylint being a bit compatible across versions, but it seems to be accelerating in adding/removing diagnostics and settings, so this is more churn to add new versions, but we don't have much choice. Change-Id: I5c20a41ed8aead3e90b6dda8f5f2fc3b87cfb251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6150453 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Auto-Submit: Mike Frysinger <vapier@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org> | 1 年前 | |
pylint: add v3.2 support Change-Id: I120bd70adda6ea53e976ba47aa63d1dc622c6663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6150454 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> | 1 年前 | |
Add coverage library to vpython3 so that we can have better insight in how we stand wrt our test coverage in depot_tools. Bug: b/459690822 Change-Id: I17d67e0530755fa9c07bbc4dabf6d81b6a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7244730 Auto-Submit: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 8 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
ruff_chromium: support multi-range formatting over stdin When formatting modified lines in editor extensions (e.g. Cider's "Format Modified Lines" or "Format Modified Lines in All Files"), multiple --range arguments are passed along with --stdin-filename and - for stdin streaming. Previously, run_ruff_with_ranges() explicitly rejected stdin with multiple ranges, requiring target files to reside on disk. This caused IDE range formatting on files with multiple modified diff hunks to fail with exit code 1. Support stdin (-) in run_ruff_with_ranges() by reading the initial buffer from sys.stdin.buffer.read(), chaining in-memory Ruff passes, and writing the final formatted result directly to sys.stdout.buffer.write(). Bug: 40874143 CONV=185b507c-c6f0-451e-bd64-dc4fd38c23a1 TAG=agy Change-Id: I57ab803ff0e5c4c4a8a5c33bdc04337c6a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8264729 Reviewed-by: Richard Wang <richardwa@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 14 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Reland "UV: make the first conversion. Convert Ruff to UV." This reverts commit 88258c9ceb915fbc56b5b51e1c808514026e31a7. Reason for revert: reland again with vpython version update Original change's description: > Revert "UV: make the first conversion. Convert Ruff to UV." > > This reverts commit db395c47f653b18d647fd238e3fd0b1487da793b. > > Reason for revert: reported issue in the comment. > > Failure Link: <LINK TO FAILURE> > > Original change's description: > > UV: make the first conversion. Convert Ruff to UV. > > > > Additionally adjust ownership to give ownership of the lock file to the owner of the main file, in this case myself. > > > > Bug: b/491263752 > > Change-Id: Icef325612f39251d57c063d83562ed556a6a6964 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8179721 > > Reviewed-by: Richard Wang <richardwa@google.com> > > Commit-Queue: Alex Ovsienko <ovsienko@google.com> > > Bug: b/491263752 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I65ab58849897716ee3ca637c6fa42a9e865768e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8186536 > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Alex Ovsienko <ovsienko@google.com> Bug: b/491263752 Change-Id: I26017a8275f1d570275d8c283e81f6a5027bb40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8190014 Reviewed-by: Richard Wang <richardwa@google.com> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 29 天前 | |
presubmit: Attribute AyeAye warnings and format tool execution failures Prefix AyeAye findings with [AyeAye] in run_alint.py so developers can easily identify the source analyzer for presubmit warnings. In addition, separate unhandled tool crashes/errors into a dedicated execution_error payload instead of mixing raw stderr into standard rule findings, and format tool crashes in CheckAyeAye as clear execution failures with exit code and output details. Fixed: 555809061 Change-Id: Id4a939d510d87bbded9cafce8f16fc750e6ec12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8339029 Reviewed-by: Brian Gan <brgan@google.com> Commit-Queue: Mike Wittman <wittman@chromium.org> | 4 小时前 | |
create run_in_virtual_path command Create run_in_virtual_path wrapper script and remove virtual build path support from siso.py. Changed to use DEPOT_TOOLS_USE_VIRTUAL_BUILD_PATH instead of SISO_USE_VIRTUAL_BUILD_PATH. Bug: b/528372534, b/527765051, b/529158482 Change-Id: I81646c27d4c247b65175d356129c0b470d402dd2 TAG=agy CONV=7636c0df-0efc-42f5-9e0f-65e282e96753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8095362 Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com> | 30 天前 | |
create run_in_virtual_path command Create run_in_virtual_path wrapper script and remove virtual build path support from siso.py. Changed to use DEPOT_TOOLS_USE_VIRTUAL_BUILD_PATH instead of SISO_USE_VIRTUAL_BUILD_PATH. Bug: b/528372534, b/527765051, b/529158482 Change-Id: I81646c27d4c247b65175d356129c0b470d402dd2 TAG=agy CONV=7636c0df-0efc-42f5-9e0f-65e282e96753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8095362 Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com> | 30 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
scm: Thread-safe batch caching and path resolution for git config. Benchmarks (Cloudtop Linux): - Subprocess git config latency: 2.84 ms / query - Cached in-memory read: 0.028 ms / query (102x speedup) - 50 config reads (typical upload): 141.7 ms -> 1.4 ms (140 ms saved) depot_tools scripts repeatedly query git configuration settings and branch configs (e.g. user.email, rietveld.server, branch.<name>.remote, branch.<name>.merge, gerrit.host). Spawning individual git config subprocesses costs ~2.8 ms per lookup, adding 100ms–250ms of overhead to commands like git cl upload and git cl presubmit that inspect dozens of settings across stacked branches. While scm.py provides CachedGitConfigState, several edge cases caused duplicate subprocess spawns, scope misalignment, and multi-threading races: 1. CachedGitConfigState._maybe_load_config was unsynchronized, causing concurrent background threads (such as AsyncWarmChangeDetail) to race and spawn multiple redundant git config --list processes. 2. GIT._get_config_state keyed on pathlib.Path(cwd).absolute(), meaning relative paths, subdirectories (e.g. /path/to/repo/src), and symlinks did not share the same cache instance. 3. GitConfigStateReal.load_config only recognized local, global, and system scopes, causing modern Git scopes (worktree, command, submodule) from git config --list -z --show-scope to be misparsed as config entries. This CL: 1. Adds an instance lock to CachedGitConfigState so multi-threaded queries synchronize safely and load configuration exactly once. 2. Canonicalizes cwd using pathlib.Path(cwd).resolve() in GIT._get_config_state to share cache instances across repository paths and symlinks. 3. Expands GitConfigStateReal scope parsing to support worktree, command, and submodule scopes. 4. Adds unit tests covering path canonicalization, multi-threaded safety with concurrency barriers, and multi-scope parsing. Bug: none Test: vpython3 tests/scm_unittest.py Change-Id: Icf643ecb1ebcdab6ae79318399f70d60cc5df625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8274874 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Alex Ovsienko <ovsienko@google.com> | 12 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
create run_in_virtual_path command Create run_in_virtual_path wrapper script and remove virtual build path support from siso.py. Changed to use DEPOT_TOOLS_USE_VIRTUAL_BUILD_PATH instead of SISO_USE_VIRTUAL_BUILD_PATH. Bug: b/528372534, b/527765051, b/529158482 Change-Id: I81646c27d4c247b65175d356129c0b470d402dd2 TAG=agy CONV=7636c0df-0efc-42f5-9e0f-65e282e96753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8095362 Auto-Submit: Fumitoshi Ukai <ukai@google.com> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com> | 30 天前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Ruff lint: relint depot_tools with ruff and remove pylint usage. Migrate depot_tools python codebase to use Ruff for linting. Remove legacy pylint usage and clean up obsolete pylint directives. Bug: 539486220 Change-Id: I04cfd5c349e3657971d791b113ed20526a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8246879 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> Reviewed-by: Richard Wang <richardwa@google.com> | 20 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Revert "[depot_tools] Add top-level python3 wrappers with system python bypass" This reverts commit c55f47acb2cfd98f5b522541140d8844e4f0a2e6. Reason for revert: While there were no complaints yet, the lack of parity of CIPD Python and system python is concerning (mostly the fact that CIPD one lacks a lot of preinstalled libraries). We might want to rethink the approach here and devise some less invasive approach, especially as this revert does not affect the builders arm of the effort. Original change's description: > [depot_tools] Add top-level python3 wrappers with system python bypass > > Standardize depot_tools execution wrappers to use CIPD-provided > CPython directly instead of host system python3. > Supports DEPOT_TOOLS_PYTHON_BYPASS environment variable to allow falling > back to host system python3 if needed. > > Updates both POSIX shell script (python3) and Windows batch wrapper > (python3.bat) to directly resolve CIPD CPython via python3_bin_reldir.txt. > Also removes legacy root python3 deletion from update_depot_tools. > > Bug: 537680330 > TAG=agy > CONV=b1f27bd3-1fdc-47bd-a2a3-644f3858d1e5 > > Change-Id: Ie7f60be3c576654ef8e4b77ee81c0b5b6a6a6964 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8162440 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Alex Ovsienko <ovsienko@google.com> Bug: 537680330 Change-Id: I17884918d19719e95bf71eccf37d1bbefbb9dd04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8215807 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 27 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
watchlists: Cache compiled rules and skip on --bypass-watchlists. Benchmarks (Cloudtop Linux, 501 WATCHLISTS rules): - Warm-cache instantiation: 8.98 ms -> 0.24 ms (37.4x) - Multi-pass upload flow (3x load): 25.43 ms -> 10.13 ms (-60.2%) - Upload with --bypass-watchlists: 25.43 ms -> 0.00 ms (100% saved) Watchlists was previously re-evaluating AST and re-compiling all regular expressions on every Watchlists() instantiation. In Chromium, where WATCHLISTS defines 500+ rules, each instantiation costs ~9 ms. During a typical upload or stacked branch flow, Watchlists() is instantiated multiple times sequentially. Additionally, _PrepareChange() in git_cl.py unconditionally evaluated watchlists even when --bypass-watchlists was specified. This CL: 1. Adds _ParseAndCompileWatchlistRules() with @functools.lru_cache to reuse compiled regex dictionaries across instances in the same process. 2. Performs dictionary/list comprehension copying upon assignment to prevent accidental in-place mutations from leaking across instances. 3. Hardens rule parsing against malformed non-dict schemas and re.error regex compilation failures. 4. Guards Watchlists execution in git_cl.py (_PrepareChange and CMDUpload) behind getattr(options, "bypass_watchlists", False). 5. Adds unit tests for caching, mutation isolation, invalid regex handling, non-dict schemas, and the --bypass-watchlists flag. Test: vpython3 tests/watchlists_unittest.py Test: vpython3 tests/git_cl_test.py Bug: none Change-Id: I6b344dff6afcd871ca55656d8a57fdd69769dc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8261249 Reviewed-by: Alex Ovsienko <ovsienko@google.com> Commit-Queue: James Hawkins <jhawkins@chromium.org> | 12 天前 | |
Change whitespace.txt Test implicit owners approval. Change-Id: I1f38e1b931b191909659298a7e6e39c42603c1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2897275 Reviewed-by: Yulan Lin <yulanlin@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> | 5 年前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 | |
Update license boilerplate text in source code files Normally we don't do this, but enough changes have accumulated that we're doing a tree-wide one-off update of the name & style. Bug: 40136831 Change-Id: I3ae5f2d1032ec8901acbff2299e68d8b4ec4e96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8141242 Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> | 1 个月前 | |
vpython: generate new vpython config for the entire depot_tools. The conversion is performed with vpython3 -vpython-tool upgrade -legacy command. Some manual adjustments are made: gsutil was fixed to execute vpython3 with the toml config now, and the infra_lib/telemetry was pushed to Py 3.11 to resolve the dependencies correctly. Bug: b/491263752 Change-Id: I60bb32f8a7e06a074f2d759219fec3f06a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/8319027 Reviewed-by: Junji Watanabe <jwata@google.com> Commit-Queue: Alex Ovsienko <ovsienko@google.com> | 2 天前 |
depot_tools
Tools for Chromium development. Requires Python 3.8+.
gsutil: Python 3.9–3.13 required.
Tools
The most important tools are:
fetch: Agclientwrapper to checkout a project. Usefetch --helpfor more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient helpfor more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Usegit cl helpfor more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Also, includes shell script/batch file for tools required to build chromium, e.g.
gn: a meta-build system that generates build files for Ninjaautoninja: a wrapper forsisoandninja.siso: a build tool that aims to significantly speed up Chromium's build.ninja: a small build system with a focus on speed. deprecated by Siso.
These shell script/batch file runs python script with python-bin/python3
that find binaries in chromium checkout, and run with proper setup/check.
To use these wrappers, you need to initialize/bootstrap depot_tools (using
gclient, update_depot_tools or ensure_bootstrap).
AI agent tooling
This repository contains two separate directories of agent-related tooling with distinct audiences:
agents/: Skills and configuration meant for Chromium developers (and their AI agents) working in the Chromium codebase using depot_tools.depot_tools_agents/: AI review agents (e.g. Gerrit review agents) meant only for maintainers of depot_tools working on thedepot_toolscode itself. This is not intended for use with the Chromium codebase.
Installing
See set-up documentation.
depot_tools is also available in
-
chromium's third_party/depot_tools: propagated by autoroller.
-
on builder: infra_internal/recipe_bundles/chrome-internal.googlesource.com/chrome/tools/build bundles depot_tools. propagated by build_internal recipe roller
These depot_tools would not be initialized/bootstrapped (i.e. no
python-bin/python3 binary available), so the build tool wrapper won't work,
unless it is explicitly initialized by ensure_bootstrap.
Or, directly call the python script instead of using the shell script/batch
file.
Updating
depot_tools updates itself automatically when running gclient tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or
run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
Running gclient will install python3 binary.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py in depot_tools, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.
项目介绍
用户可借助此项目进行 Chromium 开发,包含 fetch、gclient 等核心工具,支持代码检出、依赖管理和代码审查,还集成 gn、ninja 等构建工具及 AI 代理相关工具。【此简介由AI生成】
定制我的领域