Ggdk@chromium.orgChanging USB API buffer ownership.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Make sure that a given app/extension requests only its own resources. All ApiResources of a given type live in a single pool. Until now, one app could send arbitrary resource IDs in and get another app's resources if it were lucky. Now we check that an app is getting back only its own resources. Note that this CL could have been shorter if I hadn't decided to break out the owner_extension_id in ApiResource's constructor. I decided to do this anyway because the other way to get that information (asking ApiResourceEventNotifier) violated the Law of Demeter, or even if it was a technical non-violation, I didn't feel good about relying on the incidental fact that AREN knew the extension ID. Ben for OWNERS TBR=ben@chromium.org BUG=142521 TEST=added Review URL: https://chromiumcodereview.appspot.com/10919201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156149 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Make sure that a given app/extension requests only its own resources. All ApiResources of a given type live in a single pool. Until now, one app could send arbitrary resource IDs in and get another app's resources if it were lucky. Now we check that an app is getting back only its own resources. Note that this CL could have been shorter if I hadn't decided to break out the owner_extension_id in ApiResource's constructor. I decided to do this anyway because the other way to get that information (asking ApiResourceEventNotifier) violated the Law of Demeter, or even if it was a technical non-violation, I didn't feel good about relying on the incidental fact that AREN knew the extension ID. Ben for OWNERS TBR=ben@chromium.org BUG=142521 TEST=added Review URL: https://chromiumcodereview.appspot.com/10919201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156149 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Changing USB API buffer ownership. This change changes the ownership of the buffer used in the final transfer callback to the UsbDevice itself instead of having the USB API keep a reference to its own buffer. BUG=151987 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10972018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158608 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Changing USB API buffer ownership. This change changes the ownership of the buffer used in the final transfer callback to the UsbDevice itself instead of having the USB API keep a reference to its own buffer. BUG=151987 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10972018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158608 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Changing USB API buffer ownership. This change changes the ownership of the buffer used in the final transfer callback to the UsbDevice itself instead of having the USB API keep a reference to its own buffer. BUG=151987 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10972018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158608 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |