Ttfarina@chromium.orgRevert 158199 - extensions: Add ExtensionView interface.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Fix typo that resulted in us screwing up the after-translate infobar menu models on views. BUG=151546 TEST=none TBR=sky Review URL: https://codereview.chromium.org/10956056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158168 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify the translate infobar code some. The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific. In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it. Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate. (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.) Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden. Finally there are a bunch of other small code simplifications. BUG=100840 TEST=none Review URL: https://codereview.chromium.org/10952016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify the translate infobar code some. The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific. In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it. Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate. (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.) Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden. Finally there are a bunch of other small code simplifications. BUG=100840 TEST=none Review URL: https://codereview.chromium.org/10952016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify the translate infobar code some. The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific. In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it. Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate. (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.) Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden. Finally there are a bunch of other small code simplifications. BUG=100840 TEST=none Review URL: https://codereview.chromium.org/10952016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename InfoBarTabService -> InfoBarService. This addresses a TODO where I noticed that the InfoBArService API has no notion of a tab and in some implementations might not be tied to a tab. TBR=trivialusageupdates@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10879037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154023 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Setup field trial for one-click signin inforbar. BUG=147227 TEST=There are two variants: the normal infobar and the blue-on-white infobar. Start chrome with one of the following command line options to force one or the other: --force-fieldtrials="OneClickSignIn/Standard/" --force-fieldtrials="OneClickSignIn/BlueOnWhite/" Review URL: https://chromiumcodereview.appspot.com/10911169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156715 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Revert 158199 - extensions: Add ExtensionView interface. We abstract all ports (android, cocoa, gtk and views) behind this interface. That way chrome/browser/extensions/ does not need to include any platform-specific ui header files. Popup window was not appearing for externsions. Hence the revert. BUG=125846,151843 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10913243 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/10961066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158219 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Setup field trial for one-click signin inforbar. BUG=147227 TEST=There are two variants: the normal infobar and the blue-on-white infobar. Start chrome with one of the following command line options to force one or the other: --force-fieldtrials="OneClickSignIn/Standard/" --force-fieldtrials="OneClickSignIn/BlueOnWhite/" Review URL: https://chromiumcodereview.appspot.com/10911169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156715 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Setup field trial for one-click signin inforbar. BUG=147227 TEST=There are two variants: the normal infobar and the blue-on-white infobar. Start chrome with one of the following command line options to force one or the other: --force-fieldtrials="OneClickSignIn/Standard/" --force-fieldtrials="OneClickSignIn/BlueOnWhite/" Review URL: https://chromiumcodereview.appspot.com/10911169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156715 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Converts ui/views/controls, ui/views/examples, ui/base/models to use gfx::ImageSkia Converts all instances using an SkBitmap to use a gfx::ImageSkia instead Replaces method names, variables and comments which include "bitmap" to use "image" instead Sed script used for conversion: 1 # Modify comments. 2 /\/\// { 3 # Save line in hold buffer. 4 h 5 # Extract portion of line which represents comment 6 # and put that into pattern space. 7 s|.*//\(.*\)|\1| 8 # Perform changes. 9 s| SkBitmap| ImageSkia|g 10 s| a bitmap| an image|g 11 s| Bitmap| Image|g 12 s| bitmap| image|g 13 # Append hold buffer to pattern space, 14 G 15 # Put everything back together. 16 s|\(.*\)\n\(.*\)//.*|\2//\1| 17 } 18 19 # Modify code. 20 # 21 # Store in hold buffer [code part ]//[comment part(including //)]. 22 # Thus you would get 4 consecutive slashes if the line actually does 23 # have a comment. 24 # Extract portion of line which has code and put that into pattern space. 25 26 # Line has a comment. 27 /\/\// { 28 s|\(.*\)//\(.*\)|\1////\2| 29 h 30 s|\(.*\)//.*|\1| 31 } 32 # No comment on line 33 /\/\// !{ 34 s|\(.*\)|\1//| 35 h 36 s|\(.*\)//|\1| 37 } 38 39 # Perform Changes 40 41 # Delete calls. 42 /buildMipMap(false)/d 43 # Replace includes. 44 s|third_party/skia/include/core/SkBitmap\.h|ui/gfx/image/image_skia\.h|g 45 s|ToSkBitmap|ToImageSkia|g 46 s|GetBitmapNamed|GetImageSkiaNamed|g 47 # Rename variables of type SkBitmap to variables of type gfx::ImageSkia 48 # Try to avoid renaming function names and classes which have 'SkBitmap' 49 # in them. 50 s|SkBitmap\([ (*&>),]\)|gfx::ImageSkia\1|g 51 # Modify variable names. 52 s|_bitmap|_image|g 53 s|bitmap|image_skia|g 54 s|bmp|image_skia|g 55 # Rename functions and classes which have 'SkBitmap' in them to use 'ImageSkia' instead 56 s|SkBitmap|ImageSkia|g 57 s|Bitmap|Image|g 58 # Restore things we didn't mean to change. 59 # SkImageOperations 60 s|ImageSkiaOperations|SkBitmapOperations|g 61 s|SkBitmapOperations::Create\(.*\)Image(|SkBitmapOperations::Create\1Bitmap(|g 62 s|skimage_skia_operations|skbitmap_operations|g 63 # SkPaint 64 s|setFilterImage|setFilterBitmap|g 65 s|isFilterImage|isFilterBitmap|g 66 # gfx::Canvas 67 s|ExtractImage|ExtractBitmap|g 68 # We will want to rename this function after everything else has changed. 69 s|DrawImageInt|DrawBitmapInt|g 70 71 # Append hold buffer to pattern space. 72 # Pattern space will look like: [code part]\n[code part]//[comment part (includi ng //). 73 G 74 # Put everything back together. 75 s|\(.*\)\n\(.*\)//\(.*\)|\1\3| I modified the following files manually afterwards: 1 ash/wm/workspace/frame_maximize_button.cc 2 ash/wm/workspace/frame_maximize_button.h 3 chrome/browser/chromeos/login/helper.cc 4 chrome/browser/chromeos/status/network_menu.cc 5 chrome/browser/cookies_tree_model.cc 6 chrome/browser/cookies_tree_model.h 7 chrome/browser/ui/gtk/gtk_tree.cc 8 chrome/browser/ui/gtk/menu_gtk.cc 9 chrome/browser/ui/search_engines/template_url_table_model.cc 10 chrome/browser/ui/search_engines/template_url_table_model.h 11 chrome/browser/ui/toolbar/back_forward_menu_model.cc 12 chrome/browser/ui/toolbar/back_forward_menu_model.h 13 chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc 14 chrome/browser/ui/toolbar/wrench_menu_model.cc 15 chrome/browser/ui/toolbar/wrench_menu_model.h 16 chrome/browser/ui/views/hung_renderer_view.cc 17 chrome/browser/ui/views/infobars/infobar_button_border.cc 18 chrome/browser/ui/views/infobars/infobar_view.cc 19 chrome/browser/ui/views/task_manager_view.cc 20 chrome/browser/ui/views/web_intent_picker_views.cc 21 chrome/browser/ui/views/wrench_menu.cc 22 chrome/browser/ui/webui/chromeos/login/network_dropdown.cc 23 ui/views/controls/button/image_button.cc 24 ui/views/controls/button/image_button_unittest.cc 25 ui/views/controls/image_view.cc 26 ui/views/controls/image_view.h 27 ui/views/controls/scrollbar/bitmap_scroll_bar.cc 28 ui/views/controls/scrollbar/bitmap_scroll_bar.h 29 ui/views/controls/scrollbar/scroll_bar.h 30 ui/views/controls/table/table_view_win.cc 31 ui/views/controls/tree/tree_view_views.h 32 ui/views/controls/tree/tree_view_win.cc 33 ui/views/examples/table_example.cc 34 ui/views/view_unittest.cc Whitespace changes and changes in includes in: 1 ui/base/models/menu_model.h 2 ui/base/models/table_model.h 3 ui/base/models/tree_model.h 4 ui/views/controls/glow_hover_controller.h 5 ui/views/controls/menu/menu.h 6 ui/views/controls/menu/menu_config_views.cc 7 ui/views/controls/menu/native_menu_win.cc 8 ui/views/controls/message_box_view.h 9 ui/views/controls/table/table_view_views.cc 10 ui/views/controls/throbber.h 11 ui/views/examples/table_example.h TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10437006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138800 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert some more view methods to the ui/views style. BUG=72040 TEST=none Review URL: http://codereview.chromium.org/7349021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92705 0039d316-1c4b-4281-b951-d872f2087c98 | 14 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Setup field trial for one-click signin inforbar. BUG=147227 TEST=There are two variants: the normal infobar and the blue-on-white infobar. Start chrome with one of the following command line options to force one or the other: --force-fieldtrials="OneClickSignIn/Standard/" --force-fieldtrials="OneClickSignIn/BlueOnWhite/" Review URL: https://chromiumcodereview.appspot.com/10911169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156715 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Rename InfoBarTabService -> InfoBarService. This addresses a TODO where I noticed that the InfoBArService API has no notion of a tab and in some implementations might not be tied to a tab. TBR=trivialusageupdates@chromium.org BUG=140037 Review URL: https://chromiumcodereview.appspot.com/10879037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154023 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Begin adding support for tab mirroring via the MediaStream audio/video capturing framework. Expanded the scope of the content::MediaStreamDeviceType enum to support the new concept of "internal capture devices." From there, many modules were tweaked to account for the new concept. In some cases, significant new functionality was added (described below). In this change, tab mirroring audio and video capture devices have been introduced, but stubbed-out. The following proposal provides more backrgound on this and the overall motivation for the code changes at-hand: http://dev.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/webrtc-tab-content-capture Significant changes: 1. content/common/media and content/public/common -- a) Expand content::MediaStreamDeviceType enum; b) Update media_stream::StreamOptions so that extension API bindings can ask for any of the MediaStreamTypes. 2. content/browser/renderer_host/media -- Minor refactoring: MediaStreamManager handles all MediaStreamDeviceTypes. Only supports EnumerateDevices and OpenDevice for physical device types. Add new GenerateStreamForDevice() API. 3. chrome/browser/media and chrome/browser/ui -- Enhance "Allow/Deny and device selection" infobar to handle all MediaStreamDeviceTypes. Review URL: https://chromiumcodereview.appspot.com/10912004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155925 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Create chrome/browser/api directory. Move infobar delegates used by Autofill to the directory. Also, consolidate infobar delegate interfaces under infobars/ rather than some under infobars/ and some under tab_contents/, as the ones under tab_contents/ were not coupled with tab_contents/ in any way. Remove feedback/proto/extension.pb.h from Autofill's DEPS file simply by dropping the include, it was not being used. BUG=140037,138280 Review URL: https://chromiumcodereview.appspot.com/10843071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151279 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Setup field trial for one-click signin inforbar. BUG=147227 TEST=There are two variants: the normal infobar and the blue-on-white infobar. Start chrome with one of the following command line options to force one or the other: --force-fieldtrials="OneClickSignIn/Standard/" --force-fieldtrials="OneClickSignIn/BlueOnWhite/" Review URL: https://chromiumcodereview.appspot.com/10911169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156715 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Setup field trial for one-click signin inforbar. BUG=147227 TEST=There are two variants: the normal infobar and the blue-on-white infobar. Start chrome with one of the following command line options to force one or the other: --force-fieldtrials="OneClickSignIn/Standard/" --force-fieldtrials="OneClickSignIn/BlueOnWhite/" Review URL: https://chromiumcodereview.appspot.com/10911169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156715 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify the translate infobar code some. The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific. In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it. Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate. (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.) Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden. Finally there are a bunch of other small code simplifications. BUG=100840 TEST=none Review URL: https://codereview.chromium.org/10952016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify the translate infobar code some. The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific. In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it. Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate. (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.) Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden. Finally there are a bunch of other small code simplifications. BUG=100840 TEST=none Review URL: https://codereview.chromium.org/10952016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify the translate infobar code some. The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific. In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it. Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate. (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.) Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden. Finally there are a bunch of other small code simplifications. BUG=100840 TEST=none Review URL: https://codereview.chromium.org/10952016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Simplify the translate infobar code some. The primary change here is to take LanguagesMenuModel, which was used by views, unused by GTK, and only "used" by Cocoa to get the appropriate language names for a menu (which can be done by calling functions on the TranslateInfobarDelegate directly), and make it truly views-specific. In turn this means we can get rid of the TranslateInfoBarView class, which was only ever used by views even though all platforms included it. Instead, the SetOriginalLanguage() and SetTargetLanguage() functions on the infobar delegate now become simple setters, and each platform calls Translate() as a followup directly where appropriate. (This split was necessary because views needed to maintain the current calling order, where the delegate updates the language index, then the infobar updates the button text, then Translate() is called.) Along the way we also make a number of delegate functions unix_hacker()-style inline getters/setters, and remove some unnecessary "virtual" declarations on functions never overridden. Finally there are a bunch of other small code simplifications. BUG=100840 TEST=none Review URL: https://codereview.chromium.org/10952016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157889 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |