Star0
64
代码
代码
Issues350
Pull Requests45
流水线
讨论
Wiki
分析
Star0
64
Jjam@chromium.orgRemove WebContentsDelegate::ExecuteContextMenuCommand since it's not called by content. Since it's only used for ChromeFrame, move it to the ExternalTabContainer interface instead.
9a22bccc创建于 2012年9月27日历史提交
文件最后提交记录最后更新时间
accessibility
Allow the Views Delegate to provide the native widget. This is necessary because we will need to construct a different NW depending on the world that owns the parent window. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/10913237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156660 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
app_list
Position apps list on Windows near the cursor. This change makes the app list on Windows appear either above or below the cursor. Above the cursor is preferred but the list will be moved below the cursor if there is not enough room. BUG=138632 Review URL: https://chromiumcodereview.appspot.com/10937008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158375 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
ash
make --desktop-aura work again on windows R=stevenjb@chromium.org,pkasting@chromium.org TBR=ben@chromium.org BUG=152266 Review URL: https://chromiumcodereview.appspot.com/10984025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158681 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
autofill
Start of New Autofill UI for Windows Add some very basic functionality for the new Autofill UI system for windows. It currently just shows an empty popup in the correct location. Future cls will add the actual functionality. BUG=51644 Review URL: https://chromiumcodereview.appspot.com/10825324 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155476 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
bookmarks
Context menus on view elements should be positioned above the finger when invoked using long press. BUG=142015 Review URL: https://codereview.chromium.org/10916180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157005 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
download
Move cancelable_request.cc/h to chrome/browser/common. It is a commonly shared utility. Also move "!chrome/browser/browser_process.h" to test section in bookmarks/DEPS BUG=144783 Review URL: https://codereview.chromium.org/10958031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158151 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
extensions
[views] Windows with min_size == max_size should be non-resizable. R=mihaip@chromium.org,ben@chromium.org BUG=152097 Review URL: https://chromiumcodereview.appspot.com/10981013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158669 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
frame
Fixed problem with disappearing window controls for applications when maximizing / minimizing / maximizing BUG=151632 TEST=unit test to see that the locations of the controls are always at the right side of the screen Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158692 Review URL: https://chromiumcodereview.appspot.com/10986003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158751 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
importer
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
infobars
Revert 158199 - extensions: Add ExtensionView interface. We abstract all ports (android, cocoa, gtk and views) behind this interface. That way chrome/browser/extensions/ does not need to include any platform-specific ui header files. Popup window was not appearing for externsions. Hence the revert. BUG=125846,151843 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10913243 TBR=tfarina@chromium.org Review URL: https://codereview.chromium.org/10961066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158219 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
location_bar
Switch WebIntentPickerController to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10959045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158650 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
notifications
make --desktop-aura work again on windows R=stevenjb@chromium.org,pkasting@chromium.org TBR=ben@chromium.org BUG=152266 Review URL: https://chromiumcodereview.appspot.com/10984025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158681 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
omnibox
Add RenderText::SetFont() function to simplify some call sites. BUG=none TEST=existing unit tests Review URL: https://chromiumcodereview.appspot.com/10933129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157365 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
status_icons
Implement status tray notifications in Windows 8 metro chrome using metro style notifications. We don't support running native context menu's in these notifications. BUG=141159 R=sky Review URL: https://chromiumcodereview.appspot.com/10869037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153303 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
sync
Rid the world of the last of views::Event types: TouchEvent, GestureEvent, MouseWheelEvent, ScrollEvent and DropTargetEvent, in favor of ui::Event derivatives. http://crbug.com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151602 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
tab_contents
Switch SadTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10949011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157575 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
tabs
Attempt 3 at: Makes tab dragging code set bounds before creating window, that way window sizer doesn't kick in and have side effects. This is the same as the first version. I reverted the last (second version) since the waterfall was happy and I need a clean version to merge over. TBR since same as first. BUG=150868 TEST=create a single window with two tabs. Drag tab out and make sure windows don't change position. Also covered by tests now. R=skuhne@chromium.org TBR=skuhne@chromium.org Review URL: https://codereview.chromium.org/10986029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158611 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
test
Add new PathService paths for Windows' All Users Desktop and Quick Launch folders. Re-commit, reverted in http://crrev.com/157680 (original commit in http://crrev.com/157667). This allows usage of PathService to cache the shortcut install paths and more importantly to mock them in shortcut tests! Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo. TBR=brettw@chromium.org BUG=148539 TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user) Desktop shortcuts installed in the right place (both All Users and per-user installs). installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest* unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* base_unittests --gtest_filter=PathServiceTest* Review URL: https://chromiumcodereview.appspot.com/10964007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157779 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
website_settings
[Views] Make the permissions menus on the Website Settings UI focusable by the TAB key and provuide accasability information. BUG=151589 Review URL: https://chromiumcodereview.appspot.com/10961048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158295 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
DEPS
browser: Add include rules to prevent people including from chrome/browser/ui/views. Whitelist some includes for now until they are fixed. BUG=125846 TEST= run ./tools/checkdeps/checkdeps.py, it should succeed. R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10407025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137704 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
OWNERS
Add OWNERS file to chrome/browser/ui/views/ We already have OWNERS file in chrome/browser/ui/cocoa, chrome/browser/ui/gtk/ chrome/browser/ui/ash/. Just views is missing one. R=ben@chromium.org,pkasting@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10905056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154753 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
PRESUBMIT.py
Renamed old bot to existing trybot. TBR=ben@chromium.org BUG=112154 TEST=none Review URL: https://chromiumcodereview.appspot.com/9325016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120259 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
about_ipc_dialog.cc
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
about_ipc_dialog.h
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
accelerator_table.cc
Notes: F4 was recently changed to toggle between Maximize/Restored unless in Fullscreen. In Fullscreen F4 toggles out of it. This fix adds Shift-F4 to toggle Fullscreen (as F4 used to do). TOGGLE_MAXIMIZED must be in kReservedActions in ash/accelerators/accelerator_table.cc. It was recently removed. BUG=151544 TEST=Press Shift F4 to toggle fullscreen; Ctrl-Alt-/ for keyboard overlay, then Shift. Review URL: https://chromiumcodereview.appspot.com/10987034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158811 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
accelerator_table.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
accelerator_table_unittest.cc
New Behavior on pressing F4: Restored -> Maximized Maximized -> Restored Fullscreen -> not fullscreen (what is was before) BUG=145402 TEST=On chromeos press F4 when in Restored, Maximize, Fullscreen windows. Review URL: https://chromiumcodereview.appspot.com/10914231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157147 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
action_box_menu.cc
Adjusted action box menu position relative to omnibox and action box menu button. BUG=147287 Review URL: https://chromiumcodereview.appspot.com/10905296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156958 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
action_box_menu.h
Adjusted action box menu position relative to omnibox and action box menu button. BUG=147287 Review URL: https://chromiumcodereview.appspot.com/10905296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156958 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
app_menu_button_win.cc
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
app_menu_button_win.h
Remove views::KeyEvent, replacing uses of it with ui::KeyEvent. http://crbug.com/125937 TEST=existing TBR=jochen@chromium.org Review URL: https://chromiumcodereview.appspot.com/10825254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150895 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
avatar_menu_bubble_view.cc
Replace views::MouseEvent with ui::MouseEvent http://crbug/com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10832282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151418 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
avatar_menu_bubble_view.h
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
avatar_menu_button.cc
Change View::HitTest to View::HitTestRect This change makes HitTest more general by allowing hit tests on rects. Hit testing on a point can be done by calling View::HitTestPoint, which calls View::HitTestRect with a rect of width and height 1. Since gesture events can now store a bounding box to represent the area of the gesture rather than just a single point, this change is needed for the implementation of gesture target fuzzing in views (https://chromiumcodereview.appspot.com/10790019/). BUG=129794 Review URL: https://chromiumcodereview.appspot.com/10827198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150954 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
avatar_menu_button.h
Change View::HitTest to View::HitTestRect This change makes HitTest more general by allowing hit tests on rects. Hit testing on a point can be done by calling View::HitTestPoint, which calls View::HitTestRect with a rect of width and height 1. Since gesture events can now store a bounding box to represent the area of the gesture rather than just a single point, this change is needed for the implementation of gesture target fuzzing in views (https://chromiumcodereview.appspot.com/10790019/). BUG=129794 Review URL: https://chromiumcodereview.appspot.com/10827198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150954 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
browser_action_test_util_views.cc
Update browserAction.setIcon and pageAction.setIcon for hidpi added support to defining icon as dictionary of paths/imageDatas with keys 19, 38. (new optional details parameters details.imageDataSet, details.pathSet) Dictionary values define icon's imageSkia representations for 1x and 2x scale respectively. BUG= 138025 Review URL: https://chromiumcodereview.appspot.com/10855154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155856 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
browser_action_view.cc
Change browser/page action default icon defined in manifest to support hidpi. To support hidpi for browser action default icons, ability to define dictionary of icon in manifest as default icons is added. Defining images of sizes 19 and 38 is allowed (other dictionary values will be ignored). The image to be painted will be determined based on screen density. Similary, for script badges, default icon is determined using 16 and 32 px icon defined in extension manifest. I have extracted actual icon loading code to extension_action_icon_factory.h/.cc, so it doesn't have to be implemented for all platform specific solutions. BUG=138025,135271 Review URL: https://chromiumcodereview.appspot.com/10905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157309 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
browser_action_view.h
Change browser/page action default icon defined in manifest to support hidpi. To support hidpi for browser action default icons, ability to define dictionary of icon in manifest as default icons is added. Defining images of sizes 19 and 38 is allowed (other dictionary values will be ignored). The image to be painted will be determined based on screen density. Similary, for script badges, default icon is determined using 16 and 32 px icon defined in extension manifest. I have extracted actual icon loading code to extension_action_icon_factory.h/.cc, so it doesn't have to be implemented for all platform specific solutions. BUG=138025,135271 Review URL: https://chromiumcodereview.appspot.com/10905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157309 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
browser_actions_container.cc
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
browser_actions_container.h
Make extension commands grant the activeTab permission. BUG=138203 TEST=Install an extension with commands and the activeTab permission. Activating commands should grant it. See chrome/test/data/extensions/api_test/keybinding/... for examples. Review URL: https://chromiumcodereview.appspot.com/10880064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158224 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
browser_actions_container_browsertest.cc
Change browser/page action default icon defined in manifest to support hidpi. To support hidpi for browser action default icons, ability to define dictionary of icon in manifest as default icons is added. Defining images of sizes 19 and 38 is allowed (other dictionary values will be ignored). The image to be painted will be determined based on screen density. Similary, for script badges, default icon is determined using 16 and 32 px icon defined in extension manifest. I have extracted actual icon loading code to extension_action_icon_factory.h/.cc, so it doesn't have to be implemented for all platform specific solutions. BUG=138025,135271 Review URL: https://chromiumcodereview.appspot.com/10905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157309 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
browser_dialogs.h
views: Remove the implementation of about chrome dialog. Now that http://crbug.com/115123 is fixed, we can remove the views implementation, and along the way we can remove the ShowAboutChromeDialog function from BrowseWindow and the platform-specific overridden functions. BUG=138724 R=pkasting@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10800096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148474 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
button_dropdown_test.cc
Fixed memory leak. Untangled confusing code with menu initialization and ownership. BUG=141037 TEST=Make sure memory bots passed. Review URL: https://chromiumcodereview.appspot.com/10832184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150469 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
certificate_viewer_win.cc
Remove BrowserList::GetLastActive usage from WebUI pages. I've plumbed the TabContents to the page bubble code so that the webui certificate viewer can get the Browser from it. BUG=129187 Review URL: https://chromiumcodereview.appspot.com/10554010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142963 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
chrome_browser_main_extra_parts_views.cc
browser: Put more files in chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145102 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
chrome_browser_main_extra_parts_views.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
chrome_to_mobile_bubble_view.cc
Integrate Chrome To Mobile with Action Box UI. Gate IsChromeToMobileEnabled on Action Box flag. Nix commandline flags, and about:flags entry. Nix IDS_FLAGS_[EN|DIS]ABLE_CHROME_TO_MOBILE_[NAME|DESCRIPTION]. Remove page action icons, anchor to action box button: Nix chrome_to_mobile_decoration.[h|mm] and use. Nix chrome_to_mobile_view.[h|cc] and use. Nix LocationBarViewGtk::CreateChromeToMobileButton, etc. Nix Command observation from LocationBarView[Mac|Gtk|<win>]. Nix chromeToMobileBubblePoint, GetChromeToMobileBubblePoint, etc. Nix SetChromeToMobileDecorationLit, VIEW_ID_CHROME_TO_MOBILE_BUTTON, etc. Add SetActionBoxIcon, call from bubble show/close. Revise SetTextButtonIconToId for TextButton anchor view. Disable ShowChromeToMobileBubble on GTK :( TODO(followup): Refine updating/observation of IDC_CHROME_TO_MOBILE_PAGE. TODO(followup): TBD GTK Action Box, fallback UI, or more cleanup. BUG=102709,120905,125307 TEST=Chrome To Mobile is enabled iff Action Box is enabled; disabled on GTK. Review URL: https://chromiumcodereview.appspot.com/10885024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154120 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
chrome_to_mobile_bubble_view.h
Avoid overriding Bubble's GetAnchorRect() where possible. Use the new BubbleDelegateView::set_anchor_insets() instead. Remove redundant DCHECK, fix indent, revise comments. BUG=none TEST=No noticable changes (placement or otherwise). Review URL: https://chromiumcodereview.appspot.com/10830366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152375 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
chrome_views_delegate.cc
Make cursors work on win aura. BUG=146077 Review URL: https://codereview.chromium.org/10939006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157553 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
chrome_views_delegate.h
Allow the Views Delegate to provide the native widget. This is necessary because we will need to construct a different NW depending on the world that owns the parent window. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/10913237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156660 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
chrome_web_dialog_view.cc
Move WebDialogView to ui/views/controls/webview. Also move WebDialogView into views namespace. BUG=124222,125846 TEST=None Review URL: https://chromiumcodereview.appspot.com/10805047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147876 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
collected_cookies_views.cc
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
collected_cookies_views.h
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
color_chooser_aura.cc
Fix color chooser cleanup process. - In case of crbug.com/139441, End() should close the window but it also schedules OnColorChooserDialogClosed() and this has been released already. That call isn't necessary in this case, so set_listener to NULL. - tab is expected to call DidEndColorChooser() everytime it ends, thus it should be called in End() too. the callback to prevent the calling BUG=139441 Review URL: https://chromiumcodereview.appspot.com/10821087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149380 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
color_chooser_dialog.cc
Initial implementation of ColorChooser for Aura. BUG=121837 TEST=manually verified, see crbug.com/121837#c14 Review URL: https://chromiumcodereview.appspot.com/10442020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144111 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
color_chooser_dialog.h
Part 3 of Move SelectFileDialog implementation to ui/base/dialogs/ - Actually move the SelectFileDialog class to ui::, leaving a compatibility header in the interim. - Because of linking reasons, create a factory interface for the SelectFileDialogExtension to use to inject itself from chrome/browser/views/ui/ - Because of linking reasons, move SelectFileDialogWin in this patch. - wstring code moved to win only files. BUG=134529 TEST=none First Review URL: https://chromiumcodereview.appspot.com/10695066 Review URL: https://chromiumcodereview.appspot.com/10698168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147263 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
color_chooser_win.cc
Initial implementation of ColorChooser for Aura. BUG=121837 TEST=manually verified, see crbug.com/121837#c14 Review URL: https://chromiumcodereview.appspot.com/10442020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144111 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
confirm_bubble_views.cc
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
confirm_bubble_views.h
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
constrained_web_dialog_delegate_views.cc
Add WebContents* to some more delegate methods This are required to identify the correct java peer-object on Android BUG= Review URL: https://chromiumcodereview.appspot.com/10837112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150470 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
constrained_window_frame_simple.cc
Change style of ConstrainedWindowViews. Removes the "baby blue" bar and close button in certain dialogs. Instead, these dialogs will draw with no frame and the dialogs themselves will now be responsible for providing the ability to close. Impact on derived classes: Print preview has a cancel button already, but we'll add a close button in a separate CL. This CL adds a close button in the web intents picker. The htaccess dialog already has a cancel button and is frameless on Mac and Linux without a close button. I don't think a change is required. BUG=133363 TEST=Verify 133363 Review URL: https://chromiumcodereview.appspot.com/10631010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146466 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
constrained_window_frame_simple.h
Change style of ConstrainedWindowViews. Removes the "baby blue" bar and close button in certain dialogs. Instead, these dialogs will draw with no frame and the dialogs themselves will now be responsible for providing the ability to close. Impact on derived classes: Print preview has a cancel button already, but we'll add a close button in a separate CL. This CL adds a close button in the web intents picker. The htaccess dialog already has a cancel button and is frameless on Mac and Linux without a close button. I don't think a change is required. BUG=133363 TEST=Verify 133363 Review URL: https://chromiumcodereview.appspot.com/10631010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146466 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
constrained_window_views.cc
Attempt 2 at: Fixes crash that occured because NativeViewHostAura::Detach was not changing the parent of the attached window. This meant that if the parent was destroyed the attached window would be destroyed. Fix for windows was done here: https://chromiumcodereview.appspot.com/10832011 This differs from first patch in that I needed to add checks for RootWindow in a couple of places. BUG=132090, 141870 TEST=see bug R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10910034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154477 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
constrained_window_views.h
media galleries config dialog on views BUG=134929 Review URL: https://chromiumcodereview.appspot.com/10828166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151758 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
constrained_window_views_browsertest.cc
Move RunAllPendingInMessageLoop from ui_test_utils.h to test_utils.h, so that it can be reused by content_browsertests. I put it in test_utils.h instead of browser_test_utils.h because this is also used by unit tests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10825085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149026 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
content_setting_bubble_contents.cc
Remove PluginFinder async interface Depends on this CL: http://codereview.chromium.org/10910168/ BUG=124396 Review URL: https://chromiumcodereview.appspot.com/10917189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158799 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
content_setting_bubble_contents.h
views: ContentSettingBubbleContents does not need to store a pointer to Profile. It's unused, so we can remove. R=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10823391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152760 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
cookie_info_view.cc
Move CanonicalCookie into separate files BUG=137014,112155 TEST=no TBR=sky@chromium.org, erg@chromium.org, tony@chromium.org, eroman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10785017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147222 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
cookie_info_view.h
Move CanonicalCookie into separate files BUG=137014,112155 TEST=no TBR=sky@chromium.org, erg@chromium.org, tony@chromium.org, eroman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10785017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147222 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
create_application_shortcut_view.cc
Switch Extensions::TabHelper to use WebContents, WebContentsUserData. BUG=107201 TEST=no visible change TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155743 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=155901 Review URL: https://chromiumcodereview.appspot.com/10917026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156366 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
create_application_shortcut_view.h
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
critical_notification_bubble_view.cc
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
critical_notification_bubble_view.h
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
crypto_module_password_dialog_view.cc
chrome: Move crypto_module_password_dialog.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10956061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158225 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
crypto_module_password_dialog_view.h
chrome: Move crypto_module_password_dialog.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10956061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158225 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
crypto_module_password_dialog_view_unittest.cc
chrome: Move crypto_module_password_dialog.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10956061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158225 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
detachable_toolbar_view.cc
This CL moves the contents of ui_resources_standard.grd into ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
detachable_toolbar_view.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
dropdown_bar_host.cc
Use new find in page resource on Windows too. Screenshots are in bug. BUG=129757 TEST=None. Review URL: https://codereview.chromium.org/10965042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158560 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
dropdown_bar_host.h
Remove views::KeyEvent, replacing uses of it with ui::KeyEvent. http://crbug.com/125937 TEST=existing TBR=jochen@chromium.org Review URL: https://chromiumcodereview.appspot.com/10825254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150895 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
dropdown_bar_host_aura.cc
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
dropdown_bar_host_delegate.h
The initial prototype code for the compact navigation (cnav) prototype, currently only active in windows. This is well hidden behind a flag and a context menu option. Loosely based off oshima's original prototype patch: http://codereview.chromium.org/165272 BUG=None TEST=Activate the cnav prototype in about:flags. Right click a tab and select "Hide Toolbar" to go into cnav mode. Ensure that the compact location bar provides the same basic functionality as the toolbar (except browser actions). Review URL: http://codereview.chromium.org/6913026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84971 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
dropdown_bar_host_win.cc
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
dropdown_bar_view.cc
Replace views::LocatedEvent with ui::LocatedEvent http://crbug.com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10828265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151362 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
dropdown_bar_view.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
edit_search_engine_dialog.cc
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
edit_search_engine_dialog.h
Remove views::KeyEvent, replacing uses of it with ui::KeyEvent. http://crbug.com/125937 TEST=existing TBR=jochen@chromium.org Review URL: https://chromiumcodereview.appspot.com/10825254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150895 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
event_utils.cc
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
event_utils.h
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
external_protocol_dialog.cc
views: Add a new ctor to MessageBoxView that takes only a InitParams. This simplifies many consumers of this API. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10378086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136804 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
external_protocol_dialog.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
external_tab_container_win.cc
Remove WebContentsDelegate::ExecuteContextMenuCommand since it's not called by content. Since it's only used for ChromeFrame, move it to the ExternalTabContainer interface instead. Also remove WebContentsDelegate::GetFrameNativeWindow which isn't used. Review URL: https://codereview.chromium.org/10987047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158861 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
external_tab_container_win.h
Remove WebContentsDelegate::ExecuteContextMenuCommand since it's not called by content. Since it's only used for ChromeFrame, move it to the ExternalTabContainer interface instead. Also remove WebContentsDelegate::GetFrameNativeWindow which isn't used. Review URL: https://codereview.chromium.org/10987047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158861 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
find_bar_host.cc
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
find_bar_host.h
Remove views::KeyEvent, replacing uses of it with ui::KeyEvent. http://crbug.com/125937 TEST=existing TBR=jochen@chromium.org Review URL: https://chromiumcodereview.appspot.com/10825254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150895 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
find_bar_host_aura.cc
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
find_bar_host_interactive_uitest.cc
Disable FindInPageTest.PrepopulateRespectBlank on windows BUG=152100 TBR=finnur@chromium.org Review URL: https://codereview.chromium.org/10978014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158492 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
find_bar_host_win.cc
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
find_bar_view.cc
Use new find in page resource on Windows too. Screenshots are in bug. BUG=129757 TEST=None. Review URL: https://codereview.chromium.org/10965042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158560 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
find_bar_view.h
Replace views::MouseEvent with ui::MouseEvent http://crbug/com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10832282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151418 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
first_run_bubble.cc
Avoid overriding Bubble's GetAnchorRect() where possible. Use the new BubbleDelegateView::set_anchor_insets() instead. Remove redundant DCHECK, fix indent, revise comments. BUG=none TEST=No noticable changes (placement or otherwise). Review URL: https://chromiumcodereview.appspot.com/10830366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152375 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
first_run_bubble.h
Avoid overriding Bubble's GetAnchorRect() where possible. Use the new BubbleDelegateView::set_anchor_insets() instead. Remove redundant DCHECK, fix indent, revise comments. BUG=none TEST=No noticable changes (placement or otherwise). Review URL: https://chromiumcodereview.appspot.com/10830366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152375 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
first_run_bubble_unittest.cc
views: Pass only Browser pointer to FirstRunBubble. We don't need to pass Profile because we can get it from Browser API, and we are trying to reduce the usage of Profile. R=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10830254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151220 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
fullscreen_exit_bubble_views.cc
Replace views::LocatedEvent with ui::LocatedEvent http://crbug.com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10828265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151362 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
fullscreen_exit_bubble_views.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
global_error_bubble_view.cc
Avoid overriding Bubble's GetAnchorRect() where possible. Use the new BubbleDelegateView::set_anchor_insets() instead. Remove redundant DCHECK, fix indent, revise comments. BUG=none TEST=No noticable changes (placement or otherwise). Review URL: https://chromiumcodereview.appspot.com/10830366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152375 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
global_error_bubble_view.h
Avoid overriding Bubble's GetAnchorRect() where possible. Use the new BubbleDelegateView::set_anchor_insets() instead. Remove redundant DCHECK, fix indent, revise comments. BUG=none TEST=No noticable changes (placement or otherwise). Review URL: https://chromiumcodereview.appspot.com/10830366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152375 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
hung_renderer_view.cc
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
hung_renderer_view.h
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
hung_renderer_view_win.cc
Add support for invoking the Windows 8 metro style hung renderer dialog box. This functionality is provided by the newly added class HungRendererDialogMetro. The actual dialog box is displayed by the metro driver.dll and the functionality to create and display this is invoked via the exported functions ShowDialogBox and DismissDialogBox. The handlers to be run when the user clicks on the kill process/wait buttons are passed into the ShowDialogBox function. Factored out the platform specific portion of the kill process functionality in the static function HungRendererDialogView::KillRendererProcess which is conditionally compiled for the platform. BUG=125672 R=sky Review URL: https://chromiumcodereview.appspot.com/10806079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148258 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
hung_renderer_view_win.h
Add support for invoking the Windows 8 metro style hung renderer dialog box. This functionality is provided by the newly added class HungRendererDialogMetro. The actual dialog box is displayed by the metro driver.dll and the functionality to create and display this is invoked via the exported functions ShowDialogBox and DismissDialogBox. The handlers to be run when the user clicks on the kill process/wait buttons are passed into the ShowDialogBox function. Factored out the platform specific portion of the kill process functionality in the static function HungRendererDialogView::KillRendererProcess which is conditionally compiled for the platform. BUG=125672 R=sky Review URL: https://chromiumcodereview.appspot.com/10806079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148258 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
javascript_app_modal_dialog_views.cc
content: Move javascript_message_type.h into content/ from ui/. BUG=98716 R=jam@chromium.org TBR=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10451047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139242 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
javascript_app_modal_dialog_views.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
keyboard_access_browsertest.cc
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
login_prompt_views.cc
TabContentsWrapper -> TabContents, part 48. browser/ui/views BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10540100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141518 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
login_view.cc
Add and specify Views::Textfield::SelectAll |reversed| flag, etc. SelectAll should be consistent and explicit with range reversal. This dictates if leading or trailing text is shown when textfields overflow. Currently, NativeTextfield[Win|Views]::SelectAll behavior is implicit and differs. (Windows native reverses the selection, while ChromeOS/Views doesn't) Revise SelectAll in RenderText, NativeTextfieldWin, and OmniboxViewViews. Add the |reversed| parameter and plumbing to related interfaces/functions. Add/update RenderTextTest.SelectAll and TextfieldViewsModelTest.Selection. Specify explicit reversal behavior in all the following cases: 1) Use reversed selection (changes ChromeOS/Views behavior) in: a) BookmarkBubbleView::ShowBubble (focus on bookmark title when shown). b) BookmarkEditorView::Accept (focus on invalid bookmark URL on "Save"). c) BookmarkEditorView::Show (focus on bookmark title when shown). d) FindBarView::UpdateForResult (find bar matches are found/iterated). e) FindBarView::SetFocusAndSelection (find bar shown, etc.). f) FindBarView::SearchTextfieldView::RequestFocus (click find bar parts, etc.). g) EditSearchEngineDialog::Show (focus on search engine title when shown). h) LoginView::OnAutofillDataAvailable (HTTP/FTP auth window shown). i) MessageBoxView::ViewHierarchyChanged (JS dialog with text input shown). 2) Use forward selection (changes Windows native behavior) in: a) NativeTextfieldWin::ExecuteCommand (textfield context menu "Select All"). (note: the Omnibox context menu "Select All" already uses forward selection) b) Textfield::AboutToRequestFocusFromTabTraversal (focus via tab-traversal). (note1: THIS IS CONTENTIOUS! Though OmniBoxViewWin is unaffected) (note2: OmniboxViewViews should be fixed later as per crbug.com/134701#c9) c) TreeView::StartEditing (editing tree view nodes ex/ collected cookies). d) NativeTextfieldViewsTest.* and ViewTest.* (changes inconsequential to tests) 3) Formally specify existing implicit behavior (no behavioral change): a) NativeTextfieldWin::OnAfterPossibleChange (temporary selection is reversed). b) NativeTextfieldViews::OnGestureEvent (double tap is forwards). c) NativeTextfieldViews::ExecuteCommand (context menu "Select All" is forwards). d) NativeTextfieldViews::HandleKeyEvent (CTRL-A is forwards). e) NativeTextfieldViews::HandleMousePressEvent (triple-click is forwards). f) TextfieldViewsModel::SetText (temporary selection is forwards). g) TextfieldViewsModelTest.* is mostly forwards, |Selection| tests reversed. TBR=ben@chromium.org BUG=134762 TEST=New RenderTextTest.SelectAll, updated TextfieldViewsModelTest.Selection, other unit tests, manual. Review URL: https://chromiumcodereview.appspot.com/10693160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146520 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
login_view.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
menu_item_view_test.cc
The touch menu for ChromeOS will be used for all flavors of ChromeOS while other operating systems should stay as they are. Furthermore changed according to specifications which can be seen in the issue. Cleaned up the menu separator constants. BUG=137345 TEST=visually checked Review URL: https://chromiumcodereview.appspot.com/10837317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153157 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
menu_model_adapter_test.cc
Allow the Views Delegate to provide the native widget. This is necessary because we will need to construct a different NW depending on the world that owns the parent window. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/10913237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156660 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
native_constrained_window_aura.cc
Keep a web dialog window centered over the content area BUG=147582 TEST=visual Review URL: https://chromiumcodereview.appspot.com/10905290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157072 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
native_constrained_window_win.cc
The last little bit of cleanup before HWNDMessageHandler becomes the WindowImpl. . Removes the win32 api pass-thrus on NativeWidgetWin . Adds win32 message pre- and post- filtering to HWNDMessageFilterDelegate so various NWW subclasses can customize message handling. . WidgetSizeIsClientSize -> HWNDMessageHandlerDelegate . MessageLoopForUI::Observer -> HWNDMessageHandler . Fullscreen handler takes a HWND instead of a Widget. Derived from: https://chromiumcodereview.appspot.com/10867096/ which is already R=sky@chromium.org http://crbug.com/142962 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10892014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153728 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
network_profile_bubble_view.cc
Avoid overriding Bubble's GetAnchorRect() where possible. Use the new BubbleDelegateView::set_anchor_insets() instead. Remove redundant DCHECK, fix indent, revise comments. BUG=none TEST=No noticable changes (placement or otherwise). Review URL: https://chromiumcodereview.appspot.com/10830366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152375 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
network_profile_bubble_view.h
Avoid overriding Bubble's GetAnchorRect() where possible. Use the new BubbleDelegateView::set_anchor_insets() instead. Remove redundant DCHECK, fix indent, revise comments. BUG=none TEST=No noticable changes (placement or otherwise). Review URL: https://chromiumcodereview.appspot.com/10830366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152375 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
open_pdf_in_reader_bubble_view.cc
Reland 156033 - Add an icon and bubble to the location bar to open PDFs in Reader. TBR=sky@chromium.org,jam@chromium.org,avi@chromium.org BUG=140474 Review URL: https://chromiumcodereview.appspot.com/10905304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157242 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
open_pdf_in_reader_bubble_view.h
Reland 156033 - Add an icon and bubble to the location bar to open PDFs in Reader. TBR=sky@chromium.org,jam@chromium.org,avi@chromium.org BUG=140474 Review URL: https://chromiumcodereview.appspot.com/10905304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157242 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
page_info_bubble_view.cc
Avoid overriding Bubble's GetAnchorRect() where possible. Use the new BubbleDelegateView::set_anchor_insets() instead. Remove redundant DCHECK, fix indent, revise comments. BUG=none TEST=No noticable changes (placement or otherwise). Review URL: https://chromiumcodereview.appspot.com/10830366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152375 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
page_info_bubble_view.h
Avoid overriding Bubble's GetAnchorRect() where possible. Use the new BubbleDelegateView::set_anchor_insets() instead. Remove redundant DCHECK, fix indent, revise comments. BUG=none TEST=No noticable changes (placement or otherwise). Review URL: https://chromiumcodereview.appspot.com/10830366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152375 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
password_generation_bubble_view.cc
Update Windows UI for the Password Generation. Patched issue 10829373. BUG=143330 Review URL: https://chromiumcodereview.appspot.com/10919111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155505 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
password_generation_bubble_view.h
Update Windows UI for the Password Generation. Patched issue 10829373. BUG=143330 Review URL: https://chromiumcodereview.appspot.com/10919111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155505 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
reload_button.cc
Replace views::MouseEvent with ui::MouseEvent http://crbug/com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10832282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151418 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
reload_button.h
Replace views::MouseEvent with ui::MouseEvent http://crbug/com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10832282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151418 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
reload_button_unittest.cc
Replace views::MouseEvent with ui::MouseEvent http://crbug/com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10832282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151418 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
sad_tab_view.cc
chromeos: Remove CROS_FONTS_USING_BCI. This was a #define that was added when we were deciding whether we should use the bytecode interpreter or FreeType's autohinter when rendering UI text on Chrome OS. The text had different heights depending on which setting was used, so a bunch of constants were special-cased when BCI was enabled. We've been using the autohinter for a long time, and we'll need to update lots of newer code if we decide to switch to BCI someday. BUG=none TEST=UI text looks the same as before TBR=tony@chromium.org,davemoore@chromium.org,zork@chromium.org Review URL: https://chromiumcodereview.appspot.com/10828336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151928 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
sad_tab_view.h
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
search_view_controller.cc
alternate ntp: persist show-search-provider-logo option at chrome://instant - in the process, move registration of zero-suggest-provider-url pref to instant ui where registration of all prefs are consolidated TBR=estade BUG=150863 TEST=verify per bug rpt Review URL: https://chromiumcodereview.appspot.com/10967022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158096 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
search_view_controller.h
SearchViewController needs more tests Adds tests to verify the transition from NTP to when suggestions are shown, both for "native" suggestions, and "instant" (html) suggestions. BUG=145827 TEST=SearchViewControllerTest.* browser tests. R=sky@chromium.org, kuan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10910232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156679 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
search_view_controller_browsertest.cc
Marking SearchViewControllerTest.NTPToNativeSuggestions as flaky. TBR=dhollowa@chromium.org BUG=149939 Review URL: https://codereview.chromium.org/10917295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157117 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
select_file_dialog_extension.cc
[cros] disable GDrive option on certain file pickers This disables the GDrive folder for features that don't support reading/writing gdata. See bug for complete list. BUG=149184 TEST=manual (all pickers listed on bug under "doesn't work", no longer shows gdrive, others still do) Review URL: https://chromiumcodereview.appspot.com/10908262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157012 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
select_file_dialog_extension.h
[cros] disable GDrive option on certain file pickers This disables the GDrive folder for features that don't support reading/writing gdata. See bug for complete list. BUG=149184 TEST=manual (all pickers listed on bug under "doesn't work", no longer shows gdrive, others still do) Review URL: https://chromiumcodereview.appspot.com/10908262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157012 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
select_file_dialog_extension_browsertest.cc
continuing from http://http://codereview.chromium.org/10823241 This intentionally doesn't change the ChromeOS behavior at all. They all still use the default FileSystemContext. This code also exposes the normal and media URLRequestGetters via the StoragePartition, and cleans up a bit of code that was accessing the URLRequestGetter in odd ways. Also, it makes Workers correctly use the Media Cache for Media fetches. TBR=benjhyden,sky,davemoore,piman,mkwst,kalman BUG=85121 Review URL: https://chromiumcodereview.appspot.com/10909182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157284 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
select_file_dialog_extension_factory.cc
Part 3 of Move SelectFileDialog implementation to ui/base/dialogs/ - Actually move the SelectFileDialog class to ui::, leaving a compatibility header in the interim. - Because of linking reasons, create a factory interface for the SelectFileDialogExtension to use to inject itself from chrome/browser/views/ui/ - Because of linking reasons, move SelectFileDialogWin in this patch. - wstring code moved to win only files. BUG=134529 TEST=none First Review URL: https://chromiumcodereview.appspot.com/10695066 Review URL: https://chromiumcodereview.appspot.com/10698168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147263 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
select_file_dialog_extension_factory.h
Part 3 of Move SelectFileDialog implementation to ui/base/dialogs/ - Actually move the SelectFileDialog class to ui::, leaving a compatibility header in the interim. - Because of linking reasons, create a factory interface for the SelectFileDialogExtension to use to inject itself from chrome/browser/views/ui/ - Because of linking reasons, move SelectFileDialogWin in this patch. - wstring code moved to win only files. BUG=134529 TEST=none First Review URL: https://chromiumcodereview.appspot.com/10695066 Review URL: https://chromiumcodereview.appspot.com/10698168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147263 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
select_file_dialog_extension_unittest.cc
ash: Remove old files and update DEPS whitelist. Plus sort-headers.py that I forgot to do in the latest patch. BUG=125846 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10832287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151627 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
simple_message_box_views.cc
browser: Put simple_message_box.h and chrome_web_contents_view_delegate.h into chrome namespace. BUG=133088 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10689095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145421 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
simple_message_box_win.cc
Ensure that message boxes displayed by Chrome in Windows 8 metro mode pass in the metro core window as the owner if NULL was passed in by the caller. This prevents the message box from getting displayed behind the metro chrome window resulting in it becoming unresponsive. BUG=148973 R=sky Review URL: https://codereview.chromium.org/10928184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156627 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
speech_recognition_bubble_views.cc
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
ssl_client_certificate_selector.cc
Switch SSLTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10916348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157292 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
ssl_client_certificate_selector.h
Replace views::Event with ui::Event. http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
ssl_client_certificate_selector_browsertest.cc
Removed calls to URLRequest::URLRequest in favor of URLRequestContext::CreateRequest This patch is by departed intern shalev@chromium.org, but it failed to pass the CQ for reasons unrelated to the patch. Original review at http://codereview.chromium.org/10870060/ . TBR=mmenke@chromium.org,michaeln@chromium.org,brettw@chromium.org,ben@chromium.org,zelidrag@chromium.org,phajdan.jr@chromium.org,pfeldman@chromium.org BUG=142945 Review URL: https://chromiumcodereview.appspot.com/10910044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154550 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
status_bubble_views.cc
Exempt status bubble windows from status bar darkening BUG=139936 TEST=None Review URL: https://chromiumcodereview.appspot.com/10905080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154890 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
status_bubble_views.h
Exempt status bubble windows from status bar darkening BUG=139936 TEST=None Review URL: https://chromiumcodereview.appspot.com/10905080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154890 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
stubs_aura.cc
linux-aura: Fix build. The stub implementation is necessary for all non-chromeos platforms. BUG=none TBR=thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155297 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
tab_icon_view.cc
Enables HiDPI favicon to be displayed in tab strip on CrOS BUG=138550 Test=Manual Run ChromeOS with --force-device-scale-factor=2 Go to a website for the first time. Favicon appears in HiDPI in tab strip on CrOS. Review URL: https://chromiumcodereview.appspot.com/10824296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151942 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
tab_icon_view.h
Enables HiDPI favicon to be displayed in tab strip on CrOS BUG=138550 Test=Manual Run ChromeOS with --force-device-scale-factor=2 Go to a website for the first time. Favicon appears in HiDPI in tab strip on CrOS. Review URL: https://chromiumcodereview.appspot.com/10824296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151942 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
tab_icon_view_model.h
views: Extract TabIconViewModel into its own header file. R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10736063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146990 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
tab_modal_confirm_dialog_views.cc
chrome: Add TabModalConfirmDialog interface. BUG=125846 R=pkasting@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10972002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158793 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
tab_modal_confirm_dialog_views.h
chrome: Add TabModalConfirmDialog interface. BUG=125846 R=pkasting@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10972002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158793 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
task_manager_view.cc
Add GPU memory tab to the task manager. Each renderer process will have all of the resources that the GPU process has allocated on its behalf (including WebGL resources, compositor resources, and the backbuffer) included in its printed total. The GPU process will have the all resources currently allocated by the GPU process in its column. This will be approximately the sum of all other rows. The row for the GPU process is printed in ()s to draw attention to the fact that its size includes duplicates from other processes' sizes. I happy this UI scheme (having played with a few), but I'd wider feedback. Note that we do not account for swapchains or for backbuffers allocated by the browser process, so those allocations are not counted in the total. BUG=140157 Review URL: https://chromiumcodereview.appspot.com/10854076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152233 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
theme_background.cc
Replace views::LocatedEvent with ui::LocatedEvent http://crbug.com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10828265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151362 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
theme_background.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
theme_helpers.cc
Cleanup gfx::Canvas now that 10562027 has landed Bug=None Test=Compiles on Mac and CrOS R=oshima,sky TBR=sadrul,sail Review URL: https://chromiumcodereview.appspot.com/10701063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148123 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
theme_helpers.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
toolbar_view.cc
Fix toolbar keyboard accessibility if bookmarks bar is shown. If the bookmarks bar was shown on startup, toolbar focus searching was broken because the code that tried to override the focus search order of the location bar container got undone when the bookmarks bar became a sibling of the location bar container. To fix this, overriding the focus search order is now done dynamically when the toolbar gets focus. Adds a new test for this case. BUG=151747 Review URL: https://chromiumcodereview.appspot.com/10962048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158559 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
toolbar_view.h
Fix toolbar keyboard accessibility on Views (alternative impl). This broke when the location bar got moved out of the toolbar's view hierarchy, it no longer became possible to tab through all of the controls in the toolbar including the location bar. To fix this, I have AccessiblePaneView provide its own subclass of FocusSearch, overriding GetParent and Contains so that the location bar is considered to be part of the toolbar for focus searching. Adds a new test that should catch this type of regression in the future, while hopefully not being too brittle so it will still succeed as the toolbar changes over time. BUG=145835 TEST=Press F6 or Alt+Shift+T to focus the toolbar, then Tab to all of the focusable controls, make sure the location bar is included. Review URL: https://chromiumcodereview.appspot.com/10949005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157914 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
toolbar_view_browsertest.cc
Fix toolbar keyboard accessibility if bookmarks bar is shown. If the bookmarks bar was shown on startup, toolbar focus searching was broken because the code that tried to override the focus search order of the location bar container got undone when the bookmarks bar became a sibling of the location bar container. To fix this, overriding the focus search order is now done dynamically when the toolbar gets focus. Adds a new test for this case. BUG=151747 Review URL: https://chromiumcodereview.appspot.com/10962048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158559 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
top_level_widget_views.cc
extensions: Extract the dependency on browser_view from extension_input_api.cc. BUG=125846 R=aa@chromium.org,ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10908053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154950 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
unhandled_keyboard_event_handler.cc
AURA/X11: Handle VKEY_MENU accelerator on content area -Moved the code to handle vkey_menu to focus manager. -Unify the code between win/aura/gtk to handle unhandled web keyevent. We were using different code path for unhandled web keyboard for regular page and login. This should fix this issue also. -Improved focus test not to use fixed wait. This should also speedup the test a bit. -Removed OmniboxViewViews tests that runs only on views/gtk. This is no longer supported and we can re-enable for win when ready. BUG=99861,106998, 108480, 108459 TEST=manual: set focus to content area and hit alt key. the focus should be set to wrench menu on release. Review URL: http://codereview.chromium.org/8907029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116541 0039d316-1c4b-4281-b951-d872f2087c98
14 年前
unhandled_keyboard_event_handler.h
views: Forward declare NativeWebKeyboardEvent instead of including its header file. BUG=125846 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10918262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157033 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
unhandled_keyboard_event_handler_aurax11.cc
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
unhandled_keyboard_event_handler_win.cc
Move NativeWebKeyboardEvent to the content namespace. TBR=ben Review URL: https://chromiumcodereview.appspot.com/10383239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137865 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
uninstall_view.cc
views: Remove wstring usage from UninstallView. BUG=23581 R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10909140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156552 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
uninstall_view.h
views: Remove wstring usage from UninstallView. BUG=23581 R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10909140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156552 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
update_recommended_message_box.cc
Move application lifetime functionality off BrowserList. This makes no attempt to really rationalize/simplify this flow, just get it off the BrowserList. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10409022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137927 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
update_recommended_message_box.h
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
user_data_dir_dialog_view.cc
views: Eliminate a wstring temp variable in UserDataDirDialogView. BUG=23581 R=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10837198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151225 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
user_data_dir_dialog_view.h
Remove redirection header and add "ui::" before all SelectFileDialog usage. BUG=134529 TEST=compiles Review URL: https://chromiumcodereview.appspot.com/10820034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149111 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_dialog_view_browsertest.cc
Move ui_test_utils::RunMessageLoop to test_utils so that it can be reused by content_browsertests. BUG=90448 Review URL: https://chromiumcodereview.appspot.com/10822030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148514 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
web_intent_picker_views.cc
Switch WebIntentPickerController to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10959045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158650 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
wrench_menu.cc
The touch menu for ChromeOS will be used for all flavors of ChromeOS while other operating systems should stay as they are. Furthermore changed according to specifications which can be seen in the issue. Cleaned up the menu separator constants. BUG=137345 TEST=visually checked Review URL: https://chromiumcodereview.appspot.com/10837317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153157 0039d316-1c4b-4281-b951-d872f2087c98
13 年前
wrench_menu.h
Don't show the zoom bubble when the settings menu is showing on views or GTK. BUG=128816,128070 R=estade@chromium.org,sky@chromium.org,khorimoto@chromium.org TEST=Hotdogs > +/- zoom (shouldn't show bubble nor jack focus) NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10878013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152957 0039d316-1c4b-4281-b951-d872f2087c98
13 年前