Aavi@chromium.orgSwitch WebIntentPickerController to use WebContentsUserData.
| 文件 | 最后提交记录 | 最后更新时间 |
|---|---|---|
Adjusted action box menu position relative to omnibox and action box menu button. BUG=147287 Review URL: https://chromiumcodereview.appspot.com/10905296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156958 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Adjusted action box menu position relative to omnibox and action box menu button. BUG=147287 Review URL: https://chromiumcodereview.appspot.com/10905296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156958 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix up views web intents location bar decoration. R=pkasting@chromium.org BUG=148885 Review URL: https://chromiumcodereview.appspot.com/10917280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157301 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix up views web intents location bar decoration. R=pkasting@chromium.org BUG=148885 Review URL: https://chromiumcodereview.appspot.com/10917280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157301 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Get rid of GestureStatus in favour of EventResult. BUG=none Review URL: https://chromiumcodereview.appspot.com/10912063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154721 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Get rid of GestureStatus in favour of EventResult. BUG=none Review URL: https://chromiumcodereview.appspot.com/10912063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154721 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
aura: Long launcher tooltips should elide at end. BUG=133292 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10834207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150704 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch to new assets and fix corresponding constants related to ev bubble, tab to search UI elements and the content settings bubble. Assets checked in in http://codereview.chromium.org/10896009/ BUG=137351,137717 TEST=manual: To test EV bubble, invoke it in the omnibox by going to paypal.com. The bubble should be completely inside the omnibox with one pixel padding on top and bottom. Same checks for tab-to-search bubble and content setting bubble. Review URL: https://chromiumcodereview.appspot.com/10899009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154144 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix toolbar keyboard accessibility on Views (alternative impl). This broke when the location bar got moved out of the toolbar's view hierarchy, it no longer became possible to tab through all of the controls in the toolbar including the location bar. To fix this, I have AccessiblePaneView provide its own subclass of FocusSearch, overriding GetParent and Contains so that the location bar is considered to be part of the toolbar for focus searching. Adds a new test that should catch this type of regression in the future, while hopefully not being too brittle so it will still succeed as the toolbar changes over time. BUG=145835 TEST=Press F6 or Alt+Shift+T to focus the toolbar, then Tab to all of the focusable controls, make sure the location bar is included. Review URL: https://chromiumcodereview.appspot.com/10949005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157914 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix toolbar keyboard accessibility on Views (alternative impl). This broke when the location bar got moved out of the toolbar's view hierarchy, it no longer became possible to tab through all of the controls in the toolbar including the location bar. To fix this, I have AccessiblePaneView provide its own subclass of FocusSearch, overriding GetParent and Contains so that the location bar is considered to be part of the toolbar for focus searching. Adds a new test that should catch this type of regression in the future, while hopefully not being too brittle so it will still succeed as the toolbar changes over time. BUG=145835 TEST=Press F6 or Alt+Shift+T to focus the toolbar, then Tab to all of the focusable controls, make sure the location bar is included. Review URL: https://chromiumcodereview.appspot.com/10949005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157914 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
alternate ntp: clip middle omnibox when resizing browser window - when resizing browser window, middle omnibox wasn't clipped; it would float in the root window if the browser window is too small to contain it - fix to make LocationBarContainer clip its child LocationBarView - LocationBarContainer's bounds is resized to within its parent's, while LocationBarView's width fills it but height stays the same, allowing the former to clip the latter without resizing the latter BUG=145744 TEST=verify per bug rpt. Review URL: https://chromiumcodereview.appspot.com/10907038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156675 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
views: Pass sort-headers.py in all files under this directory. And fix the cases reported. TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153418 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Content Settings bubble does not display RTL text. This is the case because we manually draw the string in the bubble without taking RTL into account. We fix this by using a views::Label instead that takes care of RTL when drawing text. BUG=78907 Review URL: https://chromiumcodereview.appspot.com/10949024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157675 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Content Settings bubble does not display RTL text. This is the case because we manually draw the string in the bubble without taking RTL into account. We fix this by using a views::Label instead that takes care of RTL when drawing text. BUG=78907 Review URL: https://chromiumcodereview.appspot.com/10949024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157675 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch ZoomTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10959054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158510 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
alternate ntp: focus border of omnibox in ntp - another attempt at drawing the ntp omnibox blue focus border, as a filled rounded rect with a mask, on top of the standard omnibox border - fix to remove the white outline around the omnibox border - fix the left and right edges of omnibox border to the same thickness and brightness as those of the top and bottom edges BUG=135466,150871 TEST=verify per bug rpt Review URL: https://chromiumcodereview.appspot.com/10957010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157876 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Get rid of GestureStatus in favour of EventResult. BUG=none Review URL: https://chromiumcodereview.appspot.com/10912063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154721 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Get rid of GestureStatus in favour of EventResult. BUG=none Review URL: https://chromiumcodereview.appspot.com/10912063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154721 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland 156033 - Add an icon and bubble to the location bar to open PDFs in Reader. TBR=sky@chromium.org,jam@chromium.org,avi@chromium.org BUG=140474 Review URL: https://chromiumcodereview.appspot.com/10905304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157242 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Reland 156033 - Add an icon and bubble to the location bar to open PDFs in Reader. TBR=sky@chromium.org,jam@chromium.org,avi@chromium.org BUG=140474 Review URL: https://chromiumcodereview.appspot.com/10905304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157242 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change browser/page action default icon defined in manifest to support hidpi. To support hidpi for browser action default icons, ability to define dictionary of icon in manifest as default icons is added. Defining images of sizes 19 and 38 is allowed (other dictionary values will be ignored). The image to be painted will be determined based on screen density. Similary, for script badges, default icon is determined using 16 and 32 px icon defined in extension manifest. I have extracted actual icon loading code to extension_action_icon_factory.h/.cc, so it doesn't have to be implemented for all platform specific solutions. BUG=138025,135271 Review URL: https://chromiumcodereview.appspot.com/10905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157309 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Change browser/page action default icon defined in manifest to support hidpi. To support hidpi for browser action default icons, ability to define dictionary of icon in manifest as default icons is added. Defining images of sizes 19 and 38 is allowed (other dictionary values will be ignored). The image to be painted will be determined based on screen density. Similary, for script badges, default icon is determined using 16 and 32 px icon defined in extension manifest. I have extracted actual icon loading code to extension_action_icon_factory.h/.cc, so it doesn't have to be implemented for all platform specific solutions. BUG=138025,135271 Review URL: https://chromiumcodereview.appspot.com/10905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157309 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert extension action icons code to use ImageSkia instead of SkBitmap This is needed to support hidpi for browser/page actions. BUG=138025,135271 TEST=manually checked that browser and page action buttons are displayed correctly. Review URL: https://chromiumcodereview.appspot.com/10827191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151399 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace views::LocatedEvent with ui::LocatedEvent http://crbug.com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10828265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151362 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Replace views::LocatedEvent with ui::LocatedEvent http://crbug.com/125937 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10828265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151362 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Convert CalculateMinString() to string16. BUG=23581 R=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10219009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133956 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Add bookmark entry point histogram for bookmark prompt experiment - How star icon activate ... mouse click, gesture, keyboard, accelerator - Counter for (really) bookmark added. UMA("Start") = number of star icon activated. The document of bookmark prompt experiment: https://docs.google.com/a/google.com/document/d/1N27VfFla4jfdjolxI50zns8HydnWKM7A6zBgpWUY9rM/view BUG=146233 R=sky@chromium.org TEST=No user visible changes Review URL: https://chromiumcodereview.appspot.com/10917062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156247 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Get rid of GestureStatus in favour of EventResult. BUG=none Review URL: https://chromiumcodereview.appspot.com/10912063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154721 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove Instant v1 API. In the process, refactors the Instant code so that all logic is centralized in the InstantController. InstantLoader now merely forwards messages between InstantController and the renderer. BUG=none R=sky@chromium.org TEST=Instant works as before when enabled from chrome://settings/. Review URL: https://chromiumcodereview.appspot.com/10836031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150795 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Enlarge size of touch target for several location bar buttons without affecting visual layout. BUG=129751 TEST=This issue affects layout code for the location bar. It should not change the visible layout at all, but in touch layout it should allow you to click just outside of the icons for many of the buttons (e.g. the bookmark star) and get a "hit" on the button. This change needs to be tested with the following different types of buttons in the location bar, in both touch (e.g. Win8 Metro) and non-touch layouts, to make sure the layout looks right: "Chrome to Mobile" button, content settings button (e.g. blocked JavaScript, blocked plug-ins), page action buttons (from extensions), the location icon (far left of the omnibox, normally) and the bookmark star (far right). Review URL: https://chromiumcodereview.appspot.com/10519008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142124 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Remove the rest of #pragma once in one big CL. For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch WebIntentPickerController to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10959045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158650 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Fix up views web intents location bar decoration. R=pkasting@chromium.org BUG=148885 Review URL: https://chromiumcodereview.appspot.com/10917280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157301 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Switch ZoomTabHelper to use WebContentsUserData. BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10959054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158510 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Avoid overriding Bubble's GetAnchorRect() where possible. Use the new BubbleDelegateView::set_anchor_insets() instead. Remove redundant DCHECK, fix indent, revise comments. BUG=none TEST=No noticable changes (placement or otherwise). Review URL: https://chromiumcodereview.appspot.com/10830366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152375 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
events: Move some files into ui/base/events/ BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 | |
Refactor browser window zoom handling and enable zoom icon on all platforms. On all platforms: After this CL there should be zoom icon in the omnibox when on a page with non-default zoom (- for less than default, + for more than default). If the zoom is reset with Ctrl+0, no bubble should show up and the icon should disappear. If tabs with different zooms are switched between, the zoom icon should update itself for each tab without showing a bubble. On Views and GTK: While changing zoom with Ctrl +/-, a zoom bubble should show up if you zoomed *to* a non-default level. If you quickly change to a different tab after changing the zoom level, the bubble should disappear. BUG=86817,128817 TEST=Compiles, passes tests, doesn't regress current zoom functionality. TODO=Zoom *bubble* on Mac. Review URL: https://chromiumcodereview.appspot.com/10736028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152744 0039d316-1c4b-4281-b951-d872f2087c98 | 13 年前 |